From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A761C369BA for ; Wed, 16 Apr 2025 16:11:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AC4228012F; Wed, 16 Apr 2025 12:11:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45BF428012D; Wed, 16 Apr 2025 12:11:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FB3B28012F; Wed, 16 Apr 2025 12:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 113C328012D for ; Wed, 16 Apr 2025 12:11:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 83B571609B5 for ; Wed, 16 Apr 2025 16:10:54 +0000 (UTC) X-FDA: 83340395628.29.E77A884 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 2E05440014 for ; Wed, 16 Apr 2025 16:10:52 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R6BkqG/X"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744819852; a=rsa-sha256; cv=none; b=21D0SpbNjoJB3ohmF+EwAi6Zx8ZxDsJQzEzwb6ygGSTyAzt3SMDFDn17WhPxpDlWW4w1Wj IpgQYr1IX7V6XBspG3/t6fKF2czrPic0mZIiP2iWtkiKis379GcF6dG4/OHxA9+S+Zpjoe ojs2HRKomc+nkqZ1PkfNXcumFKV5J1o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744819852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o6ARJki+qaXMp4MS04T2ajKyOGVrN2invKy0HZHX3Is=; b=HX3zTyf6D8/NqmMKvukHK3FFM6LH4TvPfgbbuay6OqJ8/Ehvx1jpALemwy4UK1jxyYfoWS 76hYRgVZg2f11rLxmMX7+18BgQnEQ2Wi3XfxGrQ4I0PwbMrtgicahKr1Ep2WOeXkEXOcDs i7RgqepsVdDSZI10H1mthpb3ghdGv9s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="R6BkqG/X"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744819851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o6ARJki+qaXMp4MS04T2ajKyOGVrN2invKy0HZHX3Is=; b=R6BkqG/X3YBd6D5qYpyUqmG55o29Mmg8CtuDjKFunpIZnZALnZ41laPOHD18fad6zDzM4w ok9Wcdn+HGKMh9DlYo3kZujbchdOfnLsq3eSx6wCkmf7COMIOkLDWthTRJtheHtv0jOudj ciM1G20z0yJR3aTf9Y3JkHxLwGI9YBs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-9kjtkUZZNnqd8R33-8ripg-1; Wed, 16 Apr 2025 12:10:50 -0400 X-MC-Unique: 9kjtkUZZNnqd8R33-8ripg-1 X-Mimecast-MFC-AGG-ID: 9kjtkUZZNnqd8R33-8ripg_1744819848 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43eed325461so41845635e9.3 for ; Wed, 16 Apr 2025 09:10:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744819848; x=1745424648; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=o6ARJki+qaXMp4MS04T2ajKyOGVrN2invKy0HZHX3Is=; b=ESJk2JpjLH+dl+umiZy76S7SXXDsRuLMwa0kIbTacl0fjs6rx6HqTBUGa9y8fnTKNt 9swkSModi5rDUwaqTo7xfSA6NO1aP/HbQENQ8NySJSIxfs2RpilVGOQ8sTX+X1p7z9aA Cq/iKJRATD7S9slrMqXDzYwPCF75DG+q9ekIzcx6c8jO+xxR+RR8Dgzq18CDwZnsSrqr ZYnaXF3HlbxlivwgNHTSfmPJbRqwYakMMng7KDaIpz2ly7Klva+OIDxsniRzVCglXB9b pLfYDosncwL+qJWOfW9TtWe8HGXmYRxxAh1Oh8zZq9641Vu584C3kKI+GNDgskmNZImI yLbw== X-Forwarded-Encrypted: i=1; AJvYcCVMQaYf58kturjeX+9B4FPSh4OvWL5SbnP1PlFmSe5+vWaD1VAwrcVehd2t0beR9JUU+LS3uktmnw==@kvack.org X-Gm-Message-State: AOJu0YyU5EWBJ7fWtfRnERO5YbzzN3MvZ5ctZUn0lI/+7QHS3F1b2n2+ a74ulFkVPhZJzql3SOLqqOWMQOCE8I1+ttGCWllTAsR5I/o051UdYJN402+iBM95XYdOI9B4kpM yrIMGNy7vMahGAPTeBvRxkZJanVgbaq/p48wKhHzFfXpOrMWX X-Gm-Gg: ASbGncvFPEFixvjlN/jKkxjAKxRjdFiMJY07lZEsFzXk6c5fdh23nA4u+L1onlOLKso k94qBQuRM7rdNO2MWJxjIkeDT1eU4VhTm7/DtzadV8WGt0agadbfmFN/UwLor770gZC2GlUX3jX GbZLZasyZ7zHa5/d+C6A02w8aZZxTrTDGTTSTXCgjFdj/9XPjF9hdmMFu7Bz583IqefDILaKb5x VO5J2ay9cJTNqdXsd5OrtgwdgOpoGCwMpmYoGVxKya8Ahci+QXikFCbdfkK75bUGSgaGxh2mAHN nTM5htnObh8TkKBs+FPSAcznHBkNjdTnMumUsF2kHanKWKcrt/yKzNVFQAC7CfHjUtbH+e63wiO bB3Ja8xK5d+lDqHXXghmzuva4eq5YOP+K5zPK0w== X-Received: by 2002:a05:600c:5494:b0:43c:fae1:5151 with SMTP id 5b1f17b1804b1-4405d6ae57fmr20633705e9.25.1744819848170; Wed, 16 Apr 2025 09:10:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfLCIMoVAMXKFkQlkSnsh6Z8XgTYyYys8PDrFPT+NPDNYsQ5O8pnSfMYztcFTmVbaTdPycrQ== X-Received: by 2002:a05:600c:5494:b0:43c:fae1:5151 with SMTP id 5b1f17b1804b1-4405d6ae57fmr20633215e9.25.1744819847680; Wed, 16 Apr 2025 09:10:47 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43ce0asm17572713f8f.70.2025.04.16.09.10.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 09:10:47 -0700 (PDT) Message-ID: <27d13454-280f-4966-b694-d7e58d991547@redhat.com> Date: Wed, 16 Apr 2025 18:10:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: fix dereferencing invalid pmd migration entry To: Gavin Guo , linux-mm@kvack.org, akpm@linux-foundation.org Cc: willy@infradead.org, ziy@nvidia.com, linmiaohe@huawei.com, hughd@google.com, revest@google.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250414072737.1698513-1-gavinguo@igalia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250414072737.1698513-1-gavinguo@igalia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HlSoMBNo8IgMeP0hY_3LdfVtP6VeyLTKphlSVwZ9wAk_1744819848 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2E05440014 X-Stat-Signature: q48aptwrdbxa6j1tjeped1neyk14kehn X-Rspam-User: X-HE-Tag: 1744819852-482990 X-HE-Meta: U2FsdGVkX1+WeaEozIKAoGBsEhxMxm6ZnQPdLllqKr8MBYLs+kF208PPnDE50mkX/CRf2Gxh4JEyOjQNaWrJ7OS+v56RRwptqVirZoJTBe7s1HjACsolP89+BQWTyieI9udmHcAz2ZDAXnWXCdDJXPffgoOfD6llFJ20YSLmP/X0VShPrKNG7UfOMmKkI+dQ76LoLaE8Y42t19ONNuBRT1g72DaMDJukLKLuinQfBZHmdVbj5kwkom0l6T+Vfc9QB/goSDy3GgkycaZ2hpZzVDnYYr2GnVXF04dAUsJB96jpuPKtfWh7U8TI+INB94ieyOdTZ1bzF4CHZOez8LOZ/7NIyiHRkC1act90iS3EObr1aNiJZgBGPDy4I88QkRxYlOoPmv3vPPaw4Mmg9frwJOii0t3mERRfZ1lEidZF3BehT+VQPSdIMfDr9z/ApwuPpqVyXU1nBVo+1CLbrmqOMaxuJHFcxo3eCP4WJdXfMEEU3S0FfZPJGSRv2euWBK3cabSOPpoVp6m6QMaxJTpeSZWaEuZNqDWPEwKtJcgpgEYv4xa4S0CcSjQumYKXX1AL4PgWeLGEYHwL5zLb51mq8JGEyz8N2GxGww0koGYPGfMcn2Wub/BIUc63lpHzZxQ5V++SdN5tMtF+EVbO2a9yPN9O+l3891DP+D5og2CcsL1h93FMqjK2jm6jHpu8YZUVkP3o11uJJv76Fb5OBOBR9mP9VKQ0tmJ1ACWI/9TA2DGcH+Eh4HFgPo1qw206KybAIeAXqN6UDveZw0Su5jrsTmSwA711m7/9bRp0nvuvefcaT8Z0C2x2QrHBSmR1SuXmU5RS5icW89aR8hkc9ky7xDmGdJ8D/7eKc6b5qrsYT++n7otLKKsKxloCK/cgppYKb79MbYjIsocVklkITMldSUHrgYBAxg+L1gKdYEnPptUS0uBH3mYzRhYMbmlTSVN2Dr2kmUwdbu/DYfSc7ay aQ4IoPd2 qbOs2a4UmuIlcHxwYOshMbqm77cdAA0AXaPjgiwxsCE5fQyVlzXr3wzVYpwIhR/m4SJYsCRnwg2iycOU7rVm7DLZE4UT4jkf0OcdoCAtrrhAV3ZTyuPjykFN8ag4h7XHsSdQz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.04.25 09:27, Gavin Guo wrote: > When migrating a THP, concurrent access to the PMD migration entry > during a deferred split scan can lead to a page fault, as illustrated > below. To prevent this page fault, it is necessary to check the PMD > migration entry and return early. In this context, there is no need to > use pmd_to_swp_entry and pfn_swap_entry_to_page to verify the equality > of the target folio. Since the PMD migration entry is locked, it cannot > be served as the target. > > BUG: unable to handle page fault for address: ffffea60001db008 > CPU: 0 UID: 0 PID: 2199114 Comm: tee Not tainted 6.14.0+ #4 NONE > Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 > RIP: 0010:split_huge_pmd_locked+0x3b5/0x2b60 > Call Trace: > > try_to_migrate_one+0x28c/0x3730 > rmap_walk_anon+0x4f6/0x770 > unmap_folio+0x196/0x1f0 > split_huge_page_to_list_to_order+0x9f6/0x1560 > deferred_split_scan+0xac5/0x12a0 > shrinker_debugfs_scan_write+0x376/0x470 > full_proxy_write+0x15c/0x220 > vfs_write+0x2fc/0xcb0 > ksys_write+0x146/0x250 > do_syscall_64+0x6a/0x120 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > The bug is found by syzkaller on an internal kernel, then confirmed on > upstream. > > Fixes: 84c3fc4e9c56 ("mm: thp: check pmd migration entry in common path") > Cc: stable@vger.kernel.org > Signed-off-by: Gavin Guo > --- > mm/huge_memory.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 2a47682d1ab7..0cb9547dcff2 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3075,6 +3075,8 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, > pmd_t *pmd, bool freeze, struct folio *folio) > { > + bool pmd_migration = is_pmd_migration_entry(*pmd); > + > VM_WARN_ON_ONCE(folio && !folio_test_pmd_mappable(folio)); > VM_WARN_ON_ONCE(!IS_ALIGNED(address, HPAGE_PMD_SIZE)); > VM_WARN_ON_ONCE(folio && !folio_test_locked(folio)); > @@ -3085,10 +3087,18 @@ void split_huge_pmd_locked(struct vm_area_struct *vma, unsigned long address, > * require a folio to check the PMD against. Otherwise, there > * is a risk of replacing the wrong folio. > */ > - if (pmd_trans_huge(*pmd) || pmd_devmap(*pmd) || > - is_pmd_migration_entry(*pmd)) { > - if (folio && folio != pmd_folio(*pmd)) > - return; Why not something like struct folio *entry_folio; if (folio) { if (is_pmd_migration_entry(*pmd)) entry_folio = pfn_swap_entry_folio(pmd_to_swp_entry(*pmd))); else entry_folio = pmd_folio(*pmd)); if (folio != entry_folio) return; } (can likely be cleaned up a bit by moving stuff into a separate function) -- Cheers, David / dhildenb