From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D60E9C7EE23 for ; Tue, 23 May 2023 09:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5563A900003; Tue, 23 May 2023 05:51:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50533900002; Tue, 23 May 2023 05:51:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CCC9900003; Tue, 23 May 2023 05:51:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2DA05900002 for ; Tue, 23 May 2023 05:51:20 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CEE8440596 for ; Tue, 23 May 2023 09:51:19 +0000 (UTC) X-FDA: 80821051878.16.20F7CEF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1930040017 for ; Tue, 23 May 2023 09:51:15 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=APdWfCdW; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684835477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Utz9GyNMlitUDGZqJTc8z9BwJtSeQQS1zcXV/HWkrQc=; b=acED21dKDW44bExDlVTVG3U0RorHBq0HWfi4XOQqh7KMFOo+MrpftvCG0JdAkmdi2pNswK tneeIxpm0ntsc8mMXp0BwxF5aZQ56DuxwhLDiPPunhBMY+sjsikH19qXbrZrAo1Qw7Zqg2 g7H8cwPTVpjp+A4sP2wlTnNwqYVe6M0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684835477; a=rsa-sha256; cv=none; b=U/NJFerPl/qHHMdIvKzusWJoxOYz/68ex/4RRTu0Z/T+NdT8Rohl6lgEGY5qw0yGBFGeQ1 3FPjSijGJMbU8w8YSy21vbivliIcaYUzBrx+wGdybHmfEcsFND/wJ9YOetRtsXQAjHWid6 eB6c7KoFHmdzApIHMb68S7jyGh58MK8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=APdWfCdW; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684835473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Utz9GyNMlitUDGZqJTc8z9BwJtSeQQS1zcXV/HWkrQc=; b=APdWfCdWWMb0hJ6NaKJLqObCr15WMbNULHmn3wy2pMhM7w/OZiRKF+ctlCovhY4OAgoqB3 wXMm0Iz7JVOvTlsWKG9uhKeMRKmwoN5gNsRMlB3qTStyMrIUBMh1z1J+18qS+dQw2V4Q9y Ku/QxgXbICLn4qQD7XGWvfI7tVZmbso= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-atlPilxbMdKpOLrzHMi4ug-1; Tue, 23 May 2023 05:51:12 -0400 X-MC-Unique: atlPilxbMdKpOLrzHMi4ug-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f60f085cd2so31365e9.0 for ; Tue, 23 May 2023 02:51:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684835471; x=1687427471; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Utz9GyNMlitUDGZqJTc8z9BwJtSeQQS1zcXV/HWkrQc=; b=RZ6+VvuV7C5N0ripAEvBIOBKfH9gslf5m37jRfTgG1pC2x9+hGAaZjA3vaykJ8Hl7I 2gKtRAEp6OOxT75bXPVdXgquWNialPBp7mrUFymKwiDUUm80VGt2Yh4Br02TTJSZkmRK +3SALbHZg62eMiBwoKtzCzhTIhM4AjC86jWhlN8wrq67ILyWMsigqxzxXrdNYV00Eppe I7Bn6Lccl7jgVZ8GrtPG7QiiNA5iWorwlHE10qnF4LETuLCxMEoXZRsGpmifodAz4O+P Ew/yIdAHCVZzXeBBl26QD5cZz03qfo5E8aHOG/s6FyhT09FsljZvGfkwF7TbjQ48RzkM BEBA== X-Gm-Message-State: AC+VfDw7gMbjj1an/u60wEtb59wOAdvgCFGRl0JlR58PvUCj8CCeIxms 05s+eRzQ5UTWuOC8BXktf52Dklhn92dVXqYnUEEhMwE/xzSRMWj/L6uXd9tb3HiVN104r1F2lk6 tjGnPZfW8DiU= X-Received: by 2002:a7b:ce95:0:b0:3f4:2b13:f0fb with SMTP id q21-20020a7bce95000000b003f42b13f0fbmr4348320wmj.13.1684835471413; Tue, 23 May 2023 02:51:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6qNSzaVQMTj006xrZmNmFSzew8J6RqPIk3CxqLL4G+jJQqoKMsg5evkWGjoS+PFJnOZ5AJQw== X-Received: by 2002:a7b:ce95:0:b0:3f4:2b13:f0fb with SMTP id q21-20020a7bce95000000b003f42b13f0fbmr4348305wmj.13.1684835471048; Tue, 23 May 2023 02:51:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c00d400b003f42894ebe2sm14284952wmm.23.2023.05.23.02.51.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 02:51:10 -0700 (PDT) Message-ID: <27ca0db1-2648-3ea7-3a26-208bc580b72f@redhat.com> Date: Tue, 23 May 2023 11:51:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 2/6] ksm: count all zero pages placed by KSM To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202305221842587200002@zte.com.cn> <20230522105229.4066-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230522105229.4066-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1930040017 X-Rspam-User: X-Stat-Signature: b8ctxpjzfmqdj59ot7fijp8n9zhrkbqq X-Rspamd-Server: rspam03 X-HE-Tag: 1684835475-106441 X-HE-Meta: U2FsdGVkX18hJ/MtZfWf3BejmTJr2NJ3+MD5NCEyNLF+H0q9qIOUGBbOtGdRPGH37wRUZdEwSTNg3NnyRYtjI0/0Gjza8OCsuZbMUOasX9kp9zpGCB4PSIy0f2K+8Yi4zz9l50FUdIOc56WOto47cEy4fimOXEE4u3ZPgkUW7oYgMwNNEUeTEA2t8y/kt9eVmQx2TXorEk5lzCi6PVtDQki2Yl5hfKDpJ4IRMaWsABknEgfSdbJM3JdhGj7ZJV+ENsQ/KQ4crDersxzK+nKmXNiaHSzNOhbV9FYFksqS4r8n6u2PZ3fs79/oAVnkXyJjUpnc1PmB2QVkxv/Q7+F4psn1YcDyrTGv9kNLEOMGepHGh5yHYnwaoD6Tl8XWJPEiCJZnyrHofQ1bK7iqdtmEJmOjRIXHziYm0XfgmMsFhJsHLjyX6GIvVKwEv4VGeAfVAw7LaUxDGuRKeVR/DyvIb6Bk5btsyqFkJoK9EYIBI4uWnIYd16jXuxFkoOPF9kGqcUkng7RCMZNvkApi4yD6seK8s0BR+SRUginE91EGvWIDqL66TE3p2LgVjQsQhjGxXLfhcBCTrSN5X1t66bttw9vuzvp2F/6XSFQJOY38or1x+5Z8nghOGKWo/MUbfXdxnRlZxKsXTE1xCtJNHhb2+O0+nOVBjX3G0lQtWqDn/GxCXxbr56hYXOP3GWfYA/LR+yYfX4bU7X2tBsb5aY0VbYM0qRW9ETo/cKoDZsTeXyHPGvvwDVg2noq2ebQB4LXIt9ThjNwfmOY26vawmMe90CyKbaUqvONRwP3gHCMmOv9P1RqqQReyJv+JV/rFULFIs4PD0veFhMPv9Q2Gy4kO144Y6J3bvkLVAlgEVF43E9/0epyBY0drxcl5MjYUP2cQYPbmVPShdnDzLAryXjmJXfNau0mOhhTFmAxI3OpCipLB9+6mWKGNVyAN43CLGVPmHKHC/4JW+ZBfXt1YFCf UYZ+AZ48 iFDL87cVgSqgL5BzSfbHunUqe1+n5qBRtCEqa4ZVSygpLFsE0NCEweoFEAmqxT5FcxoVCd2KFDSuzrWqu+ERHHtdk4tL9NbJVlYXb7cqGzgdMi5zCyHVqEi6GCA1rzBAfoKZI5ImzuyAeLrIg+A1gY2FPG6/3cXZJckKFXXy6rADrflREaEtLyPeBadWYRNbJx30zLgoWDSATBso++RBplQLWR2THtXGVrRFV8KUyRN3aNLfJfnY3imQRTaB17cuAJHZqqTZaL2epAlsnBTtMm52Q0YOTVcEZuL0WxSAYXdpKEVAX6R42udw+ttUAg7yMh5+D6XdIuS5ZLjoRAV7d5UJ97Hl0f4SnW5fwO9TkGl8TewWATiWvFI23zN4dbnYqz2VS5h81uxNxWsRmjNWWyszIXZhA+F5OXpa7mr45lYa1buq1PfyKW0lfzQUHAOMRz9gF0bYxl43qmXohRwd/h7hAoiODrLt4Wd5dKMJvEmOaqjVBeZbF4PXuj7/OVom+usM2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 12:52, Yang Yang wrote: > From: xu xin > > As pages_sharing and pages_shared don't include the number of zero pages > merged by KSM, we cannot know how many pages are zero pages placed by KSM > when enabling use_zero_pages, which leads to KSM not being transparent with > all actual merged pages by KSM. In the early days of use_zero_pages, > zero-pages was unable to get unshared by the ways like MADV_UNMERGEABLE so > it's hard to count how many times one of those zeropages was then unmerged. > > But now, unsharing KSM-placed zero page accurately has been achieved, so we > can easily count both how many times a page full of zeroes was merged with > zero-page and how many times one of those pages was then unmerged. and so, > it helps to estimate memory demands when each and every shared page could > get unshared. > > So we add ksm_zero_pages under /sys/kernel/mm/ksm/ to show the number > of all zero pages placed by KSM. > > v7->v8: > Handle the case when khugepaged replaces a shared zeropage by a THP. > Oh, and just a note, such version comments should go below the "--", such that they will automatically get dropped when applying the patch. (Usually, version information in the cover letter is sufficient :) ) -- Thanks, David / dhildenb