From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676D9C35274 for ; Mon, 18 Dec 2023 11:55:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00C868D000B; Mon, 18 Dec 2023 06:55:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFE708D0001; Mon, 18 Dec 2023 06:55:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC60F8D000B; Mon, 18 Dec 2023 06:55:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C9B2A8D0001 for ; Mon, 18 Dec 2023 06:55:05 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2FDDA1115 for ; Mon, 18 Dec 2023 11:55:05 +0000 (UTC) X-FDA: 81579782970.26.1FB14D6 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 442C414001E for ; Mon, 18 Dec 2023 11:55:03 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="L+sOn/L8"; spf=pass (imf23.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702900504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L/ZTRFB8KMknyEn1OANya2XOBJMhR0NStgi+5UdJh4Y=; b=Ed5/SFYxFsKTt8kU8nRT1Y+8zzANN0FrvKkuRwTnmLnyqTx1C4PsUHKqnUykO2rJ57d/qO UKGK19sFCNFOT5DHPUipBywu32tXHQhjLlTRUU1xVc7YpA33Pkj03od3bdd9Koxhm0rvzp iN99EUzUPE0YCc8TZzCpuIVfDDaXHg0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702900504; a=rsa-sha256; cv=none; b=dEBa8WR6YgRM6qdVCfRtYkqHfCRYFhUYqdX9aU05w1Dm7o5PaD0iX2YHFQuG4d+L+f50/3 SptZWcNf8QGETf2IHP+1r8Ml010aRBKud+LovprlcDeIh5AaYJEuuUrgNi9eqbURJVg3U0 O8Kws+iL3aqeHeqrXeHrrNEdoOgB/uA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="L+sOn/L8"; spf=pass (imf23.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-28b436f6cb9so2103998a91.3 for ; Mon, 18 Dec 2023 03:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1702900500; x=1703505300; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L/ZTRFB8KMknyEn1OANya2XOBJMhR0NStgi+5UdJh4Y=; b=L+sOn/L8rsDJU04QUqOQrybvXvP5jDjv0pb/z36VSCaUioGkrFsvUTdyy8/TqQ24V1 bxxSDq/mcXayy5w13LB2AY6pC2yXmsJWjtnL39d1V6wsLXhQz2nVusufT4y28oT98neD WXrPGGP3FaHclcZ0NBryz2NuRzj/PeqIny6DfkdOXwprhKMUghBgVwgPxXqD1AUMjO7P /q4paRSVCH8di2I0k4wzd8hI9GjLQWFjDRVhfkq7a9jy1qx5h7Rlu0y1c77EA3iN7AK8 u33GJhhQAtnI01FqVfRj9fYjLIJvdA+t2oz5Sk3bCiKbZJBZ1WnvHnVHC0NVQXLtEEz4 SZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702900500; x=1703505300; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L/ZTRFB8KMknyEn1OANya2XOBJMhR0NStgi+5UdJh4Y=; b=S5RELRC5cBkiqVjGPk2yPndWzU6/knSvDoLG/IbDPj5hgxPln4qEhO3mI28mga6nan ykALICwui5XPMYGA3ZDEaTRIfBUdmO34Wn4kvFbQgbSjxNKJ/tZJlUS1haGFeAnZSoJy ehbOkr8jVUcUC4ksXW0PwYmOPH47V58lwiOixzvcVhl25uF67LQELv1eP3ZwdhKuQYaS LHN20R75tUlpZCA4JbOhY5Kt+E1eigUOeT29eRswFovjvT2/4KYLhsJzHX9vZK+9ymRO RK/U0+YGfmP36Wli3Z68AgPecu4uhNHUsczINSFF3MsT/Up3NA9zMB7wEuv+TB+N3/sz EvHw== X-Gm-Message-State: AOJu0Yxx9fcJS4H4zbbN+R6juf3eHtwW3v6huVNiwbABAuNCwi3oVONX G8px1bUvOUtwefjwPTarPPHEpQ== X-Google-Smtp-Source: AGHT+IFX+JEJt0kMbu4r/pT+K+Ae87LI+JcegzzYIsYDypkQbvs0634QI0zRFUUHW0FedU0ubT0K4Q== X-Received: by 2002:a17:90b:4b12:b0:28b:6d24:be81 with SMTP id lx18-20020a17090b4b1200b0028b6d24be81mr801108pjb.55.1702900500392; Mon, 18 Dec 2023 03:55:00 -0800 (PST) Received: from [10.254.38.164] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id qa15-20020a17090b4fcf00b00286da7407f2sm7602250pjb.7.2023.12.18.03.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 03:55:00 -0800 (PST) Message-ID: <27c8af2f-c931-4d36-9db9-112de79ec3cd@bytedance.com> Date: Mon, 18 Dec 2023 19:54:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] mm/zswap: directly use percpu mutex and buffer in load/store Content-Language: en-US To: Yosry Ahmed Cc: Seth Jennings , Dan Streetman , Chris Li , Nhat Pham , Vitaly Wool , Andrew Morton , Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chris Li References: <20231213-zswap-dstmem-v2-0-daa5d9ae41a7@bytedance.com> <20231213-zswap-dstmem-v2-6-daa5d9ae41a7@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 442C414001E X-Rspam-User: X-Stat-Signature: 984gpuhwnszjcb77bjms8dep9gis7r5d X-Rspamd-Server: rspam03 X-HE-Tag: 1702900503-310506 X-HE-Meta: U2FsdGVkX18XJF14MMjnR8X4Fjt0tMS6enbi6OaYrPQRVYMxoOJ22LVA8guaagaAS0lq0FOYLBhJdywR+3O4c478k/4gZCYOWmnPL6ylQWcfj8QRsymeqn9hwKdHgUFHH4ZESDngWrDEbfctwSrV0cgEW+y993cwG8QROisnGwqIrSl2eB9Y0JoUINdVqoOfypuEEJGNMqWqQzBjhYYdtsm653yQxnaipsZ9Tb6dgO4if82ykJo7i4L0zmFp/dwgsXbDig0RY4WnPcE3/hr21CEXxMZ5HyA05SsOo8QtPoscbD4td238sGIhF5Ia7qxrWWKwKLO0SV19EiTAab9k9ehnXPE1Wt9jJIKF+daZyTA1CaF+bqk2MPL77BNSE1HVKa3FHo6H7rLoLvOcVqBUgB5PZe1NuHxk6vEhy5Vt7x4wWTKq9KozX2cqc1x00zs6F9GUTTj4eKXZ2NohJ6JnPUwmXR0hFFSDOOJqosHvEnNuIN7UY6qG+SzV0Fjfk/ZMMncxw9y/X4Hk/KfxgVPk0bBl6W4qfMbma/CX9hfdb/PKt+yW6/knmvenUSUsa7YJRURXoMvoUlVYGjreVDopyuEcYlhfnNGNbRD3gGotRYzIyHLY+dQyvNCPqg7AtAqvjerpEOoniUkIMJ0o1z5IbMb9JEZqbzg+z8jXMkh6XiqblcbX2061gJjq+G1l7kg8pzs7m19Xa4yU6IjnaSBUaqxkiexd5xZvQhmIaW5+D2sjiki40027hE15U5VECxTxj4vGeuQ9xlUzINXM33cFJRvK59hm8h5icaAtcR5+Ir+R0x5kkozRs7lS84LzcoXjkASMEwf5d73tV9W8dYSQcKepBZhNuDwj3z6ovTrHV8kKDrraCkbh2EX+iqYCat4Dy3oMLy2E4Dwj0B1mUTHEAm7C6JlKf7Br0aokLG+nCzNWWBEBskOb6/C8bRCV52t2FhbI0SNkU/makLu03lt 7JJfntQo dPZKgB8EywdoLVB0lxDe0xr6Lhh7j7DuBWX5aMWoQWGGkMn+6JY2rF0AstZtmRp7xbpdNMXexzLl0YdVttAh+mkCUW/7UZg7n4jEFfR2NIrVQHdtviA6bDUa7aCVrVyDGunRW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2023/12/18 17:37, Yosry Ahmed wrote: > On Mon, Dec 18, 2023 at 12:22 AM Chengming Zhou > wrote: >> >> Since the introduce of reusing the dstmem in the load path, it seems >> confusing that we are now using acomp_ctx->dstmem and acomp_ctx->mutex >> now for purposes other than what the naming suggests. >> >> Yosry suggested removing these two fields from acomp_ctx, and directly >> using zswap_dstmem and zswap_mutex in both the load and store paths, >> rename them, and add proper comments above their definitions that they >> are for generic percpu buffering on the load and store paths. >> >> So this patch remove dstmem and mutex from acomp_ctx, and rename the >> zswap_dstmem to zswap_buffer, using the percpu mutex and buffer on >> the load and store paths. And refactor out __zswap_store() to only >> include the compress & store, since I found zswap_store() is too long. > > I am not sure refactoring out __zswap_store() is useful to be honest, > but I am not objecting to it, it mirrors __zswap_load() in a sense. > However, if you want to do so, please do it in a separate patch from > renaming the percpu buffers and mutex. This will make reviewing easier > (and make my Suggested-by correctly scoped). > After thinking twice, I dropped the __zswap_store() part. Right, it's not much useful. Thanks.