From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60E4D69114 for ; Thu, 28 Nov 2024 15:53:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 225BA6B0083; Thu, 28 Nov 2024 10:53:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D64C6B0085; Thu, 28 Nov 2024 10:53:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09DB86B0088; Thu, 28 Nov 2024 10:53:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D9C276B0083 for ; Thu, 28 Nov 2024 10:53:14 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A2225A0431 for ; Thu, 28 Nov 2024 15:53:14 +0000 (UTC) X-FDA: 82835947698.21.C7CBBDB Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf05.hostedemail.com (Postfix) with ESMTP id A7C41100004 for ; Thu, 28 Nov 2024 15:52:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732809189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HlwFaUh0H7sT91e3trC2cCQM0ZxW8gKAZWgWwXpF+XM=; b=JMGK8A8N0ZmCniLmBhIrPIPRVD1Ke8Bl29RFohPj5GBVSNdi23C0QGIW7DIN6XO/DXYcDy QRYimyT4qQbTXGyUicN5b4/wVRQrSJmyx9FGRAkqJYVcOiudGd0D6Ed1UsYMjinfsM83ez 6jiDSELCGrF1jvmC0qtkTLyz2QXQkIs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732809189; a=rsa-sha256; cv=none; b=UygdSXMhlySrTlnPJjXXciCOLocLgZlpZL32LjpzyqAdiqxqjWZrIEidB5YGtYGJtD9x9e C9IV35PAZGjZPeJMWAbz8D5095oNzCK7Ik+GOdm+0CHroC1lKH9T5VgdtZ0NOsQE0ysMq+ IcyaTi8nze4uJXrS1fyGkGurcf0c4OQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-304-SDpqaHlOPaSaQN7EJINjig-1; Thu, 28 Nov 2024 15:53:07 +0000 X-MC-Unique: SDpqaHlOPaSaQN7EJINjig-1 X-Mimecast-MFC-AGG-ID: SDpqaHlOPaSaQN7EJINjig Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 28 Nov 2024 15:52:53 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 28 Nov 2024 15:52:53 +0000 From: David Laight To: 'kernel test robot' , Linus Torvalds CC: "llvm@lists.linux.dev" , "oe-kbuild-all@lists.linux.dev" , LKML , 'Arnd Bergmann' , "'Jens Axboe'" , 'Matthew Wilcox' , "'Christoph Hellwig'" , 'Andrew Morton' , Linux Memory Management List , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , 'Lorenzo Stoakes' Subject: RE: [PATCH next 6/7] minmax.h: Simplify the variants of clamp() Thread-Topic: [PATCH next 6/7] minmax.h: Simplify the variants of clamp() Thread-Index: Ads57ipn63eWKuUFSOOk3Sda6NOThQHuL4sAAAGWieA= Date: Thu, 28 Nov 2024 15:52:53 +0000 Message-ID: <27c5b7e0a0a2492191d5f3716cd9b473@AcuMS.aculab.com> References: <8f69f4deac014f558bab186444bac2e8@AcuMS.aculab.com> <202411282222.oF0B4110-lkp@intel.com> In-Reply-To: <202411282222.oF0B4110-lkp@intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: t1-eKnb1QC6oXer94w2URZ206zu7jKdLtvfqRRDPAzY_1732809186 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: h8g8h7m54beyepfiqopgpb8efj98aewy X-Rspamd-Queue-Id: A7C41100004 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732809178-442755 X-HE-Meta: U2FsdGVkX18UiZZbzYYoMq6uviwDEV1PRbVCusxmrfuYkg54HvemKQbI3W0z0+lfv7NvApNAbKvAFpgpyewKND2dItxyIfXf+7ToIivPN6Ui+Ng/fKnHDMZZp1h+IOFSqlvNzgXZJpdbjrmuRTY8sbqZIlyvS+xPoW6FRzTzFlNEwhqDUeMjN3xvxLjyzNunOBychLtqyFItp8OTbr/txlbWqFr0DXHLlbvLy7WRhVoOlkwxbjjfZZ6UTW9WTsh6n/5IAmz4d7G1d3Jxg5XbvdeVsTMFo5KWzAIA6/ylVu/r57pM54KTVU21OcaXbWEDEvCBLiBv7ZG5OZVKMawWYsJRTJM8JXFfiU6QMYCpEAGc6nQuuLJ6DWFf7htay9OZEv10wZBlTZBNeFyXDk6KuQlF5reYf7Oe3bKwIyBA/oF5qyX30bjrdZnnsMAOFh1VwrC+ud7EiQpfGJnlAiYXquV/GRl746W8PwNkQA8Qm7ol8uNt+bCkbps53ICQVtPqko/WOYEVeaTv+Lr7TZo4jybJJIZstvIJbQYHNx7/MaX0YDssYJhE7ByQg5E8C3Dl75JfwFdF66Uz1izlJV8uZkkl+3f3LNYIKODQxHSIX4Ajeo6HHkh4WSZcoC7KvGNj87/K15ch8nZpiwwgsIlBty/7kKofZLA88+TiXPOkLi1CB9G/vsftiOpAjJrmMij/+mBZvFTZ+55LpGea8vKjBxiV53b+4sftpzj0a1YEvtICOBSpkSyfEisEG7GJ975/nQLMxt3Oty3zQ/98NqAhW83knX2Docetm/dM3pWrHuWFzGjkd/OwUM46PBFq5DlM/yz0ZHfzSQMgv0Vq748MNShxixko59IZWFkkxq07jyF9QU+jLr5vUMN3XhFJB6jk4PasYnl09LunCtdJe1xn3UXJbkttKJ0297En7njcryUzSdaSTr1/eb6ocZXuH16mcvlUPMqj2LgMMyaOXxL f1f21NWB NJ9+H9mGNRzno+wYzzCcC2RzVG6NkrR++n7uETjPFpBpVCwtixSw8VoBsoOnOhQid9GbUmVV1ewpW2TRCMeduyIeIfXiz5J4Lrdi9nLjjT4xLEZPh5mKphAPAuHEjQZCyG2Zna89z0fM5gn9XZhbyyVNOJ+nEO1vE24ExSr6Kqqq6mT50leQ+DuUoXG+aEAYPBDNt2Zkzk4wvd9bnllLCCfbpNAQhOobpv8mcizwmQ1XwREv01Yn5zEFTI4nNcUqqPNEJafNQjmHJfP8uR302lTTdCrjj4y85QWcE3SihRHz18N4LBwNHxhREhzX20WIjdyCuOH4ni0Ea2vV58V46Umy7Tk5Tlst1C+kykLOn5bwLGQcbQZyEyOZk3DdQB8LyAG5X/CcbJ3QrkKr+j8454JjZS9gTyliGLQ4pqlkdx1I0XBFtWeQDjDGiWiMEqm+cT5FjYJ5hVy2eLT8kHX3dIG8O7y4H9nNkqEtsS2NgXN3xsJLINhYa3x6CK6Q5/fUAHeGOM2SbjqE62JX8WnaCdyBsz3XvFR8i3vWcUakqdz8YiwyULAPdCKxwYDLJ+1gVzubY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: kernel test robot > Sent: 28 November 2024 15:05 >=20 > Hi David, >=20 > kernel test robot noticed the following build warnings: >=20 > [auto build test WARNING on next-20241121] >=20 > url: https://github.com/intel-lab-lkp/linux/commits/David-Laight/minma= x-h-Add-whitespace-around- > operators-and-after-commas/20241121-152617 > base: next-20241121 > patch link: https://lore.kernel.org/r/8f69f4deac014f558bab186444bac2e8= %40AcuMS.aculab.com > patch subject: [PATCH next 6/7] minmax.h: Simplify the variants of clamp(= ) > config: s390-allmodconfig (https://download.01.org/0day-ci/archive/202411= 28/202411282222.oF0B4110- > lkp@intel.com/config) > compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project > 592c0fe55f6d9a811028b5f3507be91458ab2713) > reproduce (this is a W=3D1 build): (https://download.01.org/0day- > ci/archive/20241128/202411282222.oF0B4110-lkp@intel.com/reproduce) >=20 > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202411282222.oF0B4110-lkp= @intel.com/ ... > vim +414 drivers/iio/magnetometer/yamaha-yas530.c ... > 65f79b50103067 Jakob Hauser 2022-08-13 407 =09if (yas5xx->version =3D= =3D YAS537_VERSION_1) { > 65f79b50103067 Jakob Hauser 2022-08-13 408 =09=09for (i =3D 0; i < 3; = i++) > 65f79b50103067 Jakob Hauser 2022-08-13 409 =09=09=09s[i] =3D xy1y2[i] = - BIT(13); > 65f79b50103067 Jakob Hauser 2022-08-13 410 =09=09h[0] =3D (c->k * (1= 28 * s[0] + c->a2 * s[1] + c-> >a3 * s[2])) / BIT(13); > 65f79b50103067 Jakob Hauser 2022-08-13 411 =09=09h[1] =3D (c->k * (c->= a4 * s[0] + c->a5 * s[1] + c-> >a6 * s[2])) / BIT(13); > 65f79b50103067 Jakob Hauser 2022-08-13 412 =09=09h[2] =3D (c->k * (c->= a7 * s[0] + c->a8 * s[1] + c-> >a9 * s[2])) / BIT(13); > 65f79b50103067 Jakob Hauser 2022-08-13 413 =09=09for (i =3D 0; i < 3; = i++) { > 65f79b50103067 Jakob Hauser 2022-08-13 @414 =09=09=09clamp_val(h[i], -B= IT(13), BIT(13) - 1); > 65f79b50103067 Jakob Hauser 2022-08-13 415 =09=09=09xy1y2[i] =3D h[i] = + BIT(13); > 65f79b50103067 Jakob Hauser 2022-08-13 416 =09=09} > 65f79b50103067 Jakob Hauser 2022-08-13 417 =09} Duplicate, very buggy code... It very much needs BIT(13) to be signed. And it shouldn't ignore the result of clamp() =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)