From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 652A4C02194 for ; Thu, 6 Feb 2025 18:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E50316B0085; Thu, 6 Feb 2025 13:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E00A46B0088; Thu, 6 Feb 2025 13:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79A1280001; Thu, 6 Feb 2025 13:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A884A6B0085 for ; Thu, 6 Feb 2025 13:04:24 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4AFF3C1392 for ; Thu, 6 Feb 2025 18:04:24 +0000 (UTC) X-FDA: 83090294448.14.25A4A49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id A2F701C0022 for ; Thu, 6 Feb 2025 18:04:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ijrKv/ZQ"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738865061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2iLngwadKtjP/PPZuVV7/kgfyghHfqUDPiEJHU2hVxY=; b=oUnJt0rvPt/HPE60XBimTaE/TyzdBoiQfxpT1Ue4fvIsl0W/Bx78sOOksOiwWRp0cMxkDz ECoqA6zqTlX3zxfn3xi8ZO5HhbnJ1W7UJ7HUkUGIa6QmIILaTFTSpZvo2nCswlOS6N4VkN aAcDXoyrWwjxs0mzSIvugeWggLirvxc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ijrKv/ZQ"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738865061; a=rsa-sha256; cv=none; b=FQABssBwIDhAjLz1gTRZDXxqcR8RqJoMDel/qTQp3S8HL5qplngQCL6npDYrj6ZPNCQAu7 v4RraxbRDzx//+vU/NtDvx8sciw5s0Bl8y3GdCCvBzoBIBTRSZRErHwz1eX9q4i+iDAGRM D29+WXGWcBTin7JJGDp13MHL6ZecDAY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738865060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2iLngwadKtjP/PPZuVV7/kgfyghHfqUDPiEJHU2hVxY=; b=ijrKv/ZQKiDeaPv9MAefb2ZTHCOg+piXMTTbvoO4uSX4vmgwpuMh6WmRXRu5qXyLi+QQzi eRP8FZUBbLy6BV7Kpmxcy2tMog/TrvybThW4aB8gTrXo49ZpOQyFjuSbqG2sH8ehi2pOu1 7OkgRx6btc3C2DpfBawrnLqEYQE53cQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-cQAqoiKUNWec74pBfz6LFw-1; Thu, 06 Feb 2025 13:04:19 -0500 X-MC-Unique: cQAqoiKUNWec74pBfz6LFw-1 X-Mimecast-MFC-AGG-ID: cQAqoiKUNWec74pBfz6LFw Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38dbe7b6087so552007f8f.1 for ; Thu, 06 Feb 2025 10:04:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738865059; x=1739469859; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2iLngwadKtjP/PPZuVV7/kgfyghHfqUDPiEJHU2hVxY=; b=L7SIeD2rlZaNheA0gjbAt5YnVMWdaB7uoFNvjO4vGJGpVIY68qs+K7VgkfrNbjIiRg nLyISLHyS8uMfsS3tumkMU/b+U+kLS5sdZYuGGF+EihMVfC+oBLxU+AhTuVtFqH7TsJ/ Zhjj2WfPO4lAcxvZxTdthOt1nZPMHEwHuOWs2Yh+Y9LbVKTy/HgtOwlb6kse4Cu/rs0C rRsy5iCGl6QmP7jHF7+DQN94c8WyhkDWzUl6K2cQsTmU7Jbjl3603ZfyrBPf6Fj4gSaq Zl7gwxC3/k12LfNXU14QeRlNuupbUOBIKwvZQsWcFaXhOgJ0d5t7xdA/h9SInt41kiuJ khTg== X-Forwarded-Encrypted: i=1; AJvYcCUnxK2I9YTs/WfJ3HClGcixQxuJ5ZSdNORfjdbDSG719J+EXuc9Ezg3MD9tLk43iigskSDZ5Bx5ng==@kvack.org X-Gm-Message-State: AOJu0YzO5d3xyirqke7IsizL/DoNt6kD+kl8zxNqy/3wmjrCgVekh5Ov /HsX3YHmpJo9gBcKlI4iOBKixyK7POR0TItmkD57OxCDgiozH3y+XfwWAgYwdpXU/XHJBuY4z2R 8IHtADydBorqYnh9gbyz4pJtXMO2HWs6uNl4Kf7+W3XlfQbnS X-Gm-Gg: ASbGnctrd59RsX7f1ApIrUc+6K9WG8co/C43iRSqGJy60PWWyvf1HzmTTS8f54Rz14S FrvCv798K6GnLuzcUGm4uziQ0y/DChf8kOmN/h1Ko0u9Pani0tFR0ysdULAh//yvIaTyX4odIQ+ 76pgV9UzBptZ0jB6tGjCUOoRa3oTbetIhyZUS7bVIoQWgZ52GnruWboSULrOm0Og7IogV6O7/gQ VizRXcPgplsdzeaUzEvr+dnZrT+MLwo0lM3ZCHE3lbqVB+61Z7+82FVeiY3M+PakoPjb7bXWk9D mE6q2+kfacHj3Qgn/5D4ce81sZWBaxuqIvzxp6BAlAXmdtSHhLDJg+wxeTWDQ5IQJEE9fvoP2Nu 2ISufzWv8ozFSXXLB6OtE/UAvtGCyUZuI X-Received: by 2002:a05:6000:18ad:b0:38d:ae2d:f06e with SMTP id ffacd0b85a97d-38db48ca915mr5947581f8f.24.1738865058662; Thu, 06 Feb 2025 10:04:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3HxpDV6xjqpzJhQ93aTQD5J/RbAQKck/VmexSIwLXyJ1yhaWNL5QfiD8VtN7YRU4Ifik2JA== X-Received: by 2002:a05:6000:18ad:b0:38d:ae2d:f06e with SMTP id ffacd0b85a97d-38db48ca915mr5947488f8f.24.1738865058060; Thu, 06 Feb 2025 10:04:18 -0800 (PST) Received: from ?IPV6:2003:cb:c707:3000:a06b:56f1:d152:db83? (p200300cbc7073000a06b56f1d152db83.dip0.t-ipconnect.de. [2003:cb:c707:3000:a06b:56f1:d152:db83]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbdd368c9sm2349013f8f.34.2025.02.06.10.04.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2025 10:04:16 -0800 (PST) Message-ID: <27b8921c-5f1e-4cd0-95b3-2f19244b7f3b@redhat.com> Date: Thu, 6 Feb 2025 19:04:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] rust: page: Support borrowing `struct page` and physaddr conversion To: Matthew Wilcox , Jason Gunthorpe Cc: Asahi Lina , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jann Horn , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <1eaf66ba-b2d3-448f-938b-913f17ca98a4@redhat.com> <20250204183933.GJ2296753@ziepe.ca> <1d379007-97c3-4bb9-93da-1a828f955fc4@redhat.com> <20250204202656.GL2296753@ziepe.ca> <08ce9562-9ded-4d95-a495-b60f90d75490@redhat.com> <20250204204947.GM2296753@ziepe.ca> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: grpRcC-fBucyR0sM1QqrU1w7-vP18fsD-WSXl0SDoLc_1738865059 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A2F701C0022 X-Stat-Signature: kqak3h3ewzcmhabuh8qtt6j9ujmisq35 X-Rspamd-Server: rspam03 X-HE-Tag: 1738865061-37428 X-HE-Meta: U2FsdGVkX196yjHhKcq/UnYRH67k0YcshV9jM5qhSaaqjphXA3tEcrFwm9Z0AXSamCQXXiay+r6ME1OSGySnFdqdNKKZZM3A8cCWlxI/s2pTijWQELpWcF9AZsR3QpCACi6AFjUT7rtbHKxx3Q9XiliKhtRax+kDB6tdgUnLG/Owm65UA4NJo8bqUsAfN6bXOcQRudT9PcyAufwNQpruBiHzzgMyE65CWRv1RnYGCxkV0We86kh1jH9RbeaDshFreXWWMgVDuocWz5DdUbRE62v0b8dHmxgtXQchFRXzaZHriAYbWDEq2B/8AVJEPVUuNZpOQReXB0DDDCrgPuKsxXAHYzRHlKOnOnj6YyDBx8S46MIVkUTbpU/iI9HwEua7ZOr4uaG4G7RRwKf+VDmRXR64nQYbRgLVlCBuKtmCn2mwc8QtW226jcEef5kxIszQFjNr1B/7wjuSGZkjxt0ZVOhBCF0AW3NFrYYwwHJatCpJ4EwHoCHi3oY4bA4FDQJ+YJuJlwuEnvKijOUqqEytI9O9/hJ6z1cmSVqAuJj22hP7wIZTLsrwHVzM6avQc5QBDN3TqH6cgK5W9GZic5fMZHGFotUTNVC2MlzmGFdu5kOQZt8Mmv2Fer3MtULCLmxRFMdQjORlhGpxeOBouO2FpYbBO2wt0kbkIfWGown/Dpz2OYF+cZnIvffbUdsenhbqq4fPvKkrkEIccpVzAQ2Z0PBdP2XrDxepgaljCGFUgDYTxiVWz7GOgQz1xXadqVqwFnvLm3fsEzqkFYis0In4/mXp+gNprjchr7E4NG9z3FkWaBBUdv7spLazNSnPZa/ZN13uWSvJTAZ0W4jpuhYQ5CCj8+fbbCzhnBHtGD0O3dWvGYeG1NtmPFgfuvBVBioqgTqBsh/yYyq9gdSQWBfjZRS85L6B/4ttWVvBB+r1TXRXTA66TLJWiunYmgGaSkN6nfcVK9bayCDXEIFPpyt CC76eKbs xMqeJ5A1fD10WxZAjuUCsRZZgUGokJXUOUT/3EQZmASh+7jMaKjktUCNVaDtMGIx7vUflyDb3AYg9wsYX6hWf6p19A1qfK7H4SH3p7NvMinA8JtgjVru+kPL68W7zuFP3yzt5p97TB53iY2WpdeXkgJCngqKXRlXuSpJvc0J3bLs6CR+7tfCY1s0Dh2Lrnmkqnt9DPMxrPn04MzrQOuwhHD5m/Hu5cL0H9x4zcSDab3233c1p2iF5HmtMmSmkqL/7HJ88hka7it7VzhbDVy/zoNTm50wofQoc+xGSnO1VCfrKsVlTYKdnC6DRddRC5ODnbftn4O7EGTzYFuxe2QQOXulJIn84+6ouviiiKXiGih980gLHTSO0NtRayXczVZv1orBQPuHDlUasyuzi/DRcTcu68bOn6h/WXghSf1UCKt4Wtbz5rSKsfx7F7LZgYrY+siUYFPG8tuxQz+18cxgdMx93xg== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499700, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.02.25 00:17, Matthew Wilcox wrote: > On Tue, Feb 04, 2025 at 04:49:47PM -0400, Jason Gunthorpe wrote: >> The phys_to_virt() I mean is on the page table pages themselves, not >> on a leaf. >> >> All page table pages came from alloc_pages_node() and you'd do >> virt_to_phys() to stick them into a next-table PTE, then >> phys_to_virt() to bring them back: >> >> phys_to_virt(virt_to_phys(page_address(alloc_pages_node()))) >> >> Effectively. > > except for s390 & ppc where the page table can be smaller than > PAGE_SIZE, so you really only have a physical address that can be > converted to a virtual address. I recall in the context of IOMMU page tables we don't perform this packing. So what you say is certainly true for process page tables, but likely not for IOMMU etc in the context of this series. -- Cheers, David / dhildenb