From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46839C43381 for ; Fri, 5 Feb 2021 03:12:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B9E7864FBE for ; Fri, 5 Feb 2021 03:12:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9E7864FBE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C5E16B0005; Thu, 4 Feb 2021 22:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 175F26B006C; Thu, 4 Feb 2021 22:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08C666B006E; Thu, 4 Feb 2021 22:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id E3A496B0005 for ; Thu, 4 Feb 2021 22:12:25 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B0DDD180AD820 for ; Fri, 5 Feb 2021 03:12:25 +0000 (UTC) X-FDA: 77782741050.06.snake89_2800d30275e1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 929991004E3C6 for ; Fri, 5 Feb 2021 03:12:25 +0000 (UTC) X-HE-Tag: snake89_2800d30275e1 X-Filterd-Recvd-Size: 2085 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 03:12:24 +0000 (UTC) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DX0mf3pmMzjK9y; Fri, 5 Feb 2021 11:10:58 +0800 (CST) Received: from [10.174.179.241] (10.174.179.241) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Fri, 5 Feb 2021 11:12:13 +0800 Subject: Re: [PATCH] mm/rmap: Correct obsolete comment of page_get_anon_vma() To: Matthew Wilcox CC: , , References: <20210203093215.31990-1-linmiaohe@huawei.com> <20210204123807.GE308988@casper.infradead.org> From: Miaohe Lin Message-ID: <27b33f18-7c5e-8b0a-abea-f4eef01e6285@huawei.com> Date: Fri, 5 Feb 2021 11:11:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210204123807.GE308988@casper.infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.241] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi: On 2021/2/4 20:38, Matthew Wilcox wrote: > On Wed, Feb 03, 2021 at 04:32:15AM -0500, Miaohe Lin wrote: >> * Since there is no serialization what so ever against page_remove_rmap() >> - * the best this function can do is return a locked anon_vma that might >> - * have been relevant to this page. >> + * the best this function can do is return a refcount increased anon_vma >> + * that might have been relevant to this page. > > Just s/a locked/an/ Many thanks for your review and reply. > there's no need to mention again that the refcount> is increased. I think it's ok to mention again that the refcount is increased although I didn't find out where this is first mentioned. Thanks again. > . >