From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B897ECAAD3 for ; Mon, 19 Sep 2022 11:29:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D8996B0072; Mon, 19 Sep 2022 07:29:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 987B16B0073; Mon, 19 Sep 2022 07:29:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 828C86B0074; Mon, 19 Sep 2022 07:29:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 731B56B0072 for ; Mon, 19 Sep 2022 07:29:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4D40E809D2 for ; Mon, 19 Sep 2022 11:29:09 +0000 (UTC) X-FDA: 79928613618.17.46EB43B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id D6A6BA00D3 for ; Mon, 19 Sep 2022 11:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663586948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s+/Mc8w+aIXPz5w8iN1lc+Tc4tSmEaC40xw3lps1GKM=; b=iBq4wHjuWNpSgT9RGAFqQ9l1Y3HivgyIDou4gc0KZXf3oIhCX0ks1dFS5Uo7PCCmY6CDim 2wqiLhSPA1PbbTSxHjmCYcPBr+j459hyRe9YaVCimf6l7K7Z4m/kLsoQCn7mL3bWIeUKlf +9Zj0dLxoB6KdHj9c3XTt8T4MZLmiLE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-654-ZWZhpnNQPz2X_DhVFN7EwQ-1; Mon, 19 Sep 2022 07:29:07 -0400 X-MC-Unique: ZWZhpnNQPz2X_DhVFN7EwQ-1 Received: by mail-wr1-f72.google.com with SMTP id d25-20020adf9b99000000b0022adb03aee6so1634285wrc.6 for ; Mon, 19 Sep 2022 04:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=s+/Mc8w+aIXPz5w8iN1lc+Tc4tSmEaC40xw3lps1GKM=; b=HmlA+O0wqoqY4b5eLM6/aXkgAp8SBdme65Wf+P8FV2W7+mTLfAInG2+5VF5MV+Hprc cCm0mncI12n3wEHYgcN+mEtjdcWfsYAZEJ/0wquflz+brhSTaEN2RGjVQudpxhjQo641 iWKRUpmh3W42zZA0V1xrYJyG7D7G6XQQNwMmwYXEC4w3TwS4o/94Xvl7saLR/NjkUACh m45/2P1b6Ln3LkU99o+5Wod0GIr817Ffrm9yHOIQgeUmObihqvw1LBjNiZKX2I/AeVKM YOPhSH1UVCo4Dxb5miKX9GVdsBawQQsQCb47owi0410h+hQg7aS2XHe/CvzHqiq7vdIh nd4Q== X-Gm-Message-State: ACrzQf2dhl6mW8Gb7WXjAVBf63jOHag3qgIPxtUoEfo3A9YL/089B7gZ UrkiLuRWfQ/vk5OmApY1x+0HnIZYo5t3fv6w2qSDIhiixvtQ09tuowqtC6NLa8TyWm3wT3+IbEi Et9Cam1df4TQ= X-Received: by 2002:a05:600c:154a:b0:3b4:c9ec:41df with SMTP id f10-20020a05600c154a00b003b4c9ec41dfmr6343138wmg.109.1663586945983; Mon, 19 Sep 2022 04:29:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6tHZnjWz3j8PnHqbfxWuekW8WuxqAfOmQax0sp9LqrjbwLphoQoKDKMKbudkqw99jwjjL8kg== X-Received: by 2002:a05:600c:154a:b0:3b4:c9ec:41df with SMTP id f10-20020a05600c154a00b003b4c9ec41dfmr6343123wmg.109.1663586945682; Mon, 19 Sep 2022 04:29:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:c100:c136:f914:345f:f5f3? (p200300cbc703c100c136f914345ff5f3.dip0.t-ipconnect.de. [2003:cb:c703:c100:c136:f914:345f:f5f3]) by smtp.gmail.com with ESMTPSA id y6-20020a7bcd86000000b003b33de17577sm13136490wmj.13.2022.09.19.04.29.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 04:29:05 -0700 (PDT) Message-ID: <27ac1a9c-5f44-a25c-aa09-844debbb88f8@redhat.com> Date: Mon, 19 Sep 2022 13:28:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 08/16] mm/page_alloc: add missing is_migrate_isolate() check in set_page_guard() To: Miaohe Lin , akpm@linux-foundation.org, osalvador@suse.de, anshuman.khandual@arm.com Cc: willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220916072257.9639-1-linmiaohe@huawei.com> <20220916072257.9639-9-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220916072257.9639-9-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663586949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s+/Mc8w+aIXPz5w8iN1lc+Tc4tSmEaC40xw3lps1GKM=; b=HPH7NgaTxocaRyzHaqWILBOd0EvnDjDgahtCvp7Wf/LpeGuS1LgLhrxgOGM67CfYv2poB7 GuzPLIeT66LPukcY6ai4u8pwj03JdYxGjf1tW+32T5w+WTF1APSh7ncvLGQ3gGIJUQfKDI FTTAqDd1DIm2xTl1xu/lS7PDgdeHIMk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iBq4wHju; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663586949; a=rsa-sha256; cv=none; b=HtycJ9BXbwmNVvPYjDBXXA+YyYT5fgUzZr2PFE1hOVxHQXcrV8BACnfYS5IVqSQmaNEfKi pbchelJCP6EfQPD2JOJ+wZUYGVcI6YzfJqqVqfmEOidkCd5BvnsP5UBlqZU9AHwUh3vso0 UrxatnAoHGlR5Gen06r1Vssng+VTLng= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iBq4wHju; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Stat-Signature: ud8471x4xpeay1t8offecboaabkybd4h X-Rspamd-Queue-Id: D6A6BA00D3 X-Rspamd-Server: rspam12 X-HE-Tag: 1663586948-500390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.09.22 09:22, Miaohe Lin wrote: > In MIGRATE_ISOLATE case, zone freepage state shouldn't be modified as > caller will take care of it. Add missing is_migrate_isolate() here to > avoid possible unbalanced freepage state. This would happen if someone > isolates the block, and then we face an MCE failure/soft-offline on a > page within that block. __mod_zone_freepage_state() will be triggered > via below call trace which already had been triggered back when block > was isolated: > > take_page_off_buddy > break_down_buddy_pages > set_page_guard > > Fixes: 06be6ff3d2ec ("mm,hwpoison: rework soft offline for free pages") > Signed-off-by: Miaohe Lin > Reviewed-by: Oscar Salvador > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb