From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31B6D6A221 for ; Thu, 14 Nov 2024 20:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D444A6B0085; Thu, 14 Nov 2024 15:04:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D230B6B0089; Thu, 14 Nov 2024 15:04:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C09C36B008C; Thu, 14 Nov 2024 15:04:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A3B816B0085 for ; Thu, 14 Nov 2024 15:04:40 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31C541413C3 for ; Thu, 14 Nov 2024 20:04:40 +0000 (UTC) X-FDA: 82785776304.19.D20E07C Received: from prime.voidband.net (prime.voidband.net [199.247.17.104]) by imf22.hostedemail.com (Postfix) with ESMTP id BD96AC0025 for ; Thu, 14 Nov 2024 20:03:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=rue3X+pQ; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf22.hostedemail.com: domain of oleksandr@natalenko.name designates 199.247.17.104 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731614547; a=rsa-sha256; cv=none; b=HTjzMyv6P6Gs2DHAQT9aXpxEB4V4xSq/c/YikXSiq+pkPAmUaPSwAnm25Nl74Cleg5Iolb dtW0SvpN+aSF0tzRVEHddI9d6q9+hfhXv4SiMyHQfKaB2805sNUGNzNh8A84rpNM8p4heg 4AwLZurDd85RRR7XMduCD1pXjXu0iZk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=rue3X+pQ; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf22.hostedemail.com: domain of oleksandr@natalenko.name designates 199.247.17.104 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731614547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nczuuQn4zwyaCr23BO1zixTYdoxGSf2bXN4HXwIwYyE=; b=tg+KAbVslvmUNgTIo9vTBwA6tmHh2MbwLz14LIfhkbHb/X7xvHafH5vbk2vZdK8BjI5Yz0 xRyye03Awx3lGvvKMJnx2oiR17W7uZ5GJ9SplqO2lik37SS9Bre1say27W+2Or4mQiHlFQ Nu4uQBMourYqAY3WCByIMB6uFrUaCtI= Received: from spock.localnet (unknown [212.20.115.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by prime.voidband.net (Postfix) with ESMTPSA id B5DC36159C23; Thu, 14 Nov 2024 21:04:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1731614675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nczuuQn4zwyaCr23BO1zixTYdoxGSf2bXN4HXwIwYyE=; b=rue3X+pQeaxTjJgJRBZPzy9fKUO+uMTO0Q4HBbs8/tgiWnLKpEpmTpRsw9K0dZdpJF7gj1 NgbmOSMEBxY2d4ALwyqtsYV+491rFqN1ebhk9Bpyk7CbxTu0KLIeZjgS0Ny43VVcTlX0/K oMGM57KWYWO6tBTc73kVfTWE92YyQKo= From: Oleksandr Natalenko To: SeongJae Park , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Wladislav Wiebe , motiejus@jakstys.lt, vishal.moola@gmail.com Subject: Re: [PATCH] tools/mm: fix show_page() build error Date: Thu, 14 Nov 2024 21:03:57 +0100 Message-ID: <2754934.mvXUDI8C0e@natalenko.name> In-Reply-To: <20241114190204.1486-1-sj@kernel.org> References: <20241114190204.1486-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12549902.O9o76ZdvQC"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Rspamd-Queue-Id: BD96AC0025 X-Stat-Signature: uaq9rumcf9wuuwazmxe6ky3y4c9mo8yf X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731614622-984919 X-HE-Meta: U2FsdGVkX1/9NjxHU+4veRHcYVMn9czCPcMx0ohx3r50JN8F2biGL7GLOvfRWm+CnPQNoV5dZr6X96lb3DZ4lv5XW3tfJvjKkBb02N3rnJO1cMcSZHyuzebOPrU2Cq+Fg6p+Nh7Mn3VzsDfGrEYcjyW8qF1kkSqptRhSGZKXaEWPScIMULeqXaEEKdIJdH8leK3Cxr7lEjRfCr2MtD1Y/JN/h7kiYDf0astDBvvQ0H49aEp0kgMnaoeTiCGj0ZjDt/ERd3xEPDgL0oj4drOR4e7Uf24Aun5fJg99DJPZ3j2P6ErU5oEuFSUUxzdzYOZk4YlF1Y8T7gTVUBdA0bPZFldQ1wYPJuvCbHF0FJawaa/Tt2Y1yQpm/+93ebjkyfaJsACWBtdZ21sMPucOkLBZwvDom1cLx3CT9BJTTqMaouq6C5bNV4LK2ABL1eRt5c40uDwYeEtLNy1gB1iErYR1/Cg3ChFYkCBd4CqqCVR1OSsc4D6piwpajcGxDy+m4eTJ2eHkmFejpxvfPLZ1vZrXUBgR9NaJ/Pco+U0YgVAHnm4OKvuYXSq02xuKqJeawGBLqhKhM3HvW+FeU0exWrut+ZVA0t/2+OqtLLnA94B0EHFOTccd3dr1hF5Nui+UB86iiZPzW2pS5z6KHJoTFEzrluhfO8n4pWhXj7qwz1I3S96ONFW3486tjp/xSV4uCYg2Dv38y68V68e0RlcOAy8CLx4W6kdSQQL945SXs5i2hhEsoEhkwpKPnBMo0cdwlmHi/r84DeaaWv37Pynm5oF3WRNKfbw6WxjL2FDQtQnQuccbU+36Tji5uytcWAYFHVdfDEg1evnTZoiRm87ePOrOZDEgzVmmU4YTn0KzNulIkpFbH2BB+n72axrOxyuLDv4BY0V1dMy/cwnDGuzQh3erD1C42eSSOdGKKuw3neubUkTXrRd8bE3yFxrJ4MJv0IYOjdRdP8+GmKkU1wBnftv A9f+fm// nEE+X1rrIqGCXjBWB6TXuJs2AwpNewFHwPAmkQQUHllVbwTUzU5sgFVmGyj4ATEWxZQ5R52fnGMXjqmRsk2Qk+ul+08ugasf41LqrEFvyX1WGxi6z/CieO9l4+5Cmu5+UHm40w6IbjQqogrEC/Vm1dxIEsSEPtqmX7gTxxrR0F74Tx7V/kJhgvtdI80mpRQh4eHY4LWJVyeotEMD3A9vp7yRwH+faPRAmf2jQcl58CLDcMfOebfwsmcFh1Bn2tw3yC1E55YbjGqtyPJE0edZS+GNeNzQX+x0VweNX+oNc/uXMVv1IiPmIdmVWQ67NPYnzHSHr+RfV9a4UfKF+gnLo1zPRtYzoyuwvK1nYjziqLOag/ezdm1opELoQNd1VZKgVUP9S/eBncF0+pfCQDGyVSNZsOiYQbgHhS3Ac3WNPcK2VwW8q6pwHTX+SX0nYt4OuhwnA7P/EIDWtAMEigCrJCnqjDzLVC5/BTbFabMn0l3bnkRCfxD9pny6izkGXG8MeFJTE/AdD2YO33g31+GMz/dWJnyIrLQytJ2C02ZFTEVrIQ/ve8JAblDuhibWVWwgsVA4leRJ/bHHR+I8uu2bwuMSphHeyjmhQO2yT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --nextPart12549902.O9o76ZdvQC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Oleksandr Natalenko To: SeongJae Park , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/mm: fix show_page() build error Date: Thu, 14 Nov 2024 21:03:57 +0100 Message-ID: <2754934.mvXUDI8C0e@natalenko.name> In-Reply-To: <20241114190204.1486-1-sj@kernel.org> References: <20241114190204.1486-1-sj@kernel.org> MIME-Version: 1.0 Hello. On =C4=8Dtvrtek 14. listopadu 2024 20:02:04, st=C5=99edoevropsk=C3=BD stand= ardn=C3=AD =C4=8Das SeongJae Park wrote: > On Thu, 14 Nov 2024 11:01:40 +0100 Oleksandr Natalenko wrote: >=20 > > At one point I needed mm tools for debugging but couldn't compile them = due to the > > following error: > >=20 > > gcc -Wall -Wextra -I../lib/ -pthread -o page-types page-types.c ../lib/= api/libapi.a -pthread > > page-types.c: In function \u2018show_page\u2019: > > page-types.c:423:49: error: expected \u2018;\u2019 before \u2018if\u2019 > > 423 | printf("@%" PRIu64 "\t", cgroup) > > | ^ > > | ; > > 424 | if (opt_list_mapcnt) > > | ~~ > > page-types.c:416:65: warning: unused parameter \u2018mapcnt\u2019 [-Wun= used-parameter] > > 416 | uint64_t flags, uint64_t cgroup, uint64_t= mapcnt) > > | ~~~~~~~~= ~^~~~~~ > > make: *** [Makefile:23: page-types] Error 1 > >=20 > > Trailing ; was forgotten, so add it. > >=20 > > Fixes: ece5897e5a10 ("tools/mm: -Werror fixes in page-types/slabinfo") > > Signed-off-by: Oleksandr Natalenko > > --- > > tools/mm/page-types.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c > > index 6eb17cc1a06c5..bcac7ebfb51fd 100644 > > --- a/tools/mm/page-types.c > > +++ b/tools/mm/page-types.c > > @@ -420,7 +420,7 @@ static void show_page(unsigned long voffset, unsign= ed long offset, > > if (opt_file) > > printf("%lx\t", voffset); > > if (opt_list_cgroup) > > - printf("@%" PRIu64 "\t", cgroup) > > + printf("@%" PRIu64 "\t", cgroup); > > if (opt_list_mapcnt) > > printf("%" PRIu64 "\t", mapcnt); > > =20 >=20 > Just FYI, a very similar patch has posted a few days ago: > https://lore.kernel.org/20241112171655.1662670-1-motiejus@jakstys.lt OK, if the other one is taken, consider adding my Acked-by: then. Thank you. =2D-=20 Oleksandr Natalenko, MSE --nextPart12549902.O9o76ZdvQC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZUOOw5ESFLHZZtOKil/iNcg8M0sFAmc2V60ACgkQil/iNcg8 M0tyMRAAx/f9+m0I2GFJTL7oHbbD6MW4YSQoFj4/YkaOLppR8+n1wtKXnwhRwyWT NC0ckOg6v964BV47B4gQdA7O3T1IeTK2zS+tqTVMTzzkZLcg4niUrIhVJ/vgBlor 3SHZA1xIxPoERvWb2BqvefZwfllCab+WHtBW4ypU2mEM0a3XCHMxh/MyT7r4wE3X tW2ejGc9XsrKGtI71f0GXuE1kGwxM7DUcAG/W7hWbbgjER+JWJehylx+NPfCBkiE O5rozTzKGEwyAsBKgxnTymcynviffSf2+MzzYFXQ8HnRnSyvVRJAZr65j8GzD0Eh Avg7w/8M/mr3Sko7oBvS+NzmvCNMqWiVoySPOjEKJd3r6vVcD4YirnIc32zm9DRu IY+doPwVzoL3hpIAHPrkdIotF2zt5cLTMIIVZh0qoA/akmogRdLZT5I79ITL+i+N kwhFbW0dzUyyTgksPgvKg1iYkTiY2ptwpme83/ZbK67wBUnCxk0GKYIFIZK/oVIB 5CGv0eSAe8aU62p2m2hndnriYMwWBx2yo4r6X+3d4V1ooweXTUDO/bPlWWYg+kXC 0bIBa5LJuvlZY1rJj3mullPc4Iq2bJpzyl4yBIv3tUfb5jvWBa8lgl0th7nQFOEB zsReBUuKvJmCshSCqroANdmxssMbIxeNgQAXTpNAAF1JoBh+gRw= =uieD -----END PGP SIGNATURE----- --nextPart12549902.O9o76ZdvQC--