From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D170C4828E for ; Fri, 2 Feb 2024 11:22:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFD846B006E; Fri, 2 Feb 2024 06:22:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD026B0075; Fri, 2 Feb 2024 06:22:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9C8E6B0078; Fri, 2 Feb 2024 06:22:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B7AFA6B006E for ; Fri, 2 Feb 2024 06:22:28 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8FD79140F78 for ; Fri, 2 Feb 2024 11:22:28 +0000 (UTC) X-FDA: 81746625576.02.6E613F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id AD785100004 for ; Fri, 2 Feb 2024 11:22:26 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SULuE76m; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706872946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=phAeAzLfyQ/CrxIFbQUdpYZ4of5jPIIreKqGaxUEUC4=; b=o6ngOlD/aL2/RMI+3HNbioFhh1tQqBpyghQK2BM4CkNn/S7I0v1Fd3kdoBdKMm7ZR+fBDT T3eQdg2QsCqTyAsIFjZDSeVtj0xIIFPLF6lVEC1c0FCeRn5fkdGAwfGuOmWlT01qjzNPTa NCOdFDBBkSaLRnhuoYb0CNDzxOGm/pI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SULuE76m; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706872946; a=rsa-sha256; cv=none; b=An/a3XA7fsVAZ2Bk+jhqt/WVmJoE+shdrDRIz6wmkRCta3Rv+YpNxaBJk2hWSm6V5Pkyzp n+1Sd800/rSL4bEZHR6+kbQxcF7HKTb8P+3UNQSvyC30kltf44U2Jrv5l9w+D1yZtEEWSG 1D0oPHxzmweiozANNREVNJFpaR8kzy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706872945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=phAeAzLfyQ/CrxIFbQUdpYZ4of5jPIIreKqGaxUEUC4=; b=SULuE76mmlzOqZ6y5zOIjhdt23pTZxyYgsiRc3geNZWApFTJplhLgD7mSFlwaIEdLbQTHD kERLpyhfgDD5ZCGDn+UNtQFpkM0QFpD71g/NDnmB2bf5+9VCQndCQGj434T0tRipIT+G+P TmbOW6HGPKGvgDuUTrvqoumzW7tbXEI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-0nH4mioWNhGzdV6rQVrNLw-1; Fri, 02 Feb 2024 06:22:21 -0500 X-MC-Unique: 0nH4mioWNhGzdV6rQVrNLw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ECE3329AA2D1; Fri, 2 Feb 2024 11:22:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id 06A27C2590D; Fri, 2 Feb 2024 11:22:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <2701318.1706863882@warthog.procyon.org.uk> <2704767.1706869832@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, lsf-pc@lists.linux-foundation.org, Matthew Wilcox , Kent Overstreet , dwmw2@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [LSF/MM/BPF TOPIC] Replacing TASK_(UN)INTERRUPTIBLE with regions of uninterruptibility MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2751705.1706872935.1@warthog.procyon.org.uk> Date: Fri, 02 Feb 2024 11:22:15 +0000 Message-ID: <2751706.1706872935@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Rspam-User: X-Stat-Signature: fsinc485od38jxst157xjxhe8k7fgisw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AD785100004 X-HE-Tag: 1706872946-818116 X-HE-Meta: U2FsdGVkX1/n6KfPlC6laXPtxekKGQaDavRaxyYURC4PSv0RjzwHHOH7BLt4dO9fwVbvh4BS6yr3tJr0ZapNSn+cyynY4LQdeDB+EFpmvLFhSjr4GuwEFXKkNM5IBTM9RRabPJXk1EN7pl7nSGVCLZcQZssaxm6sg5qwqZ26hcqEuqbjn2Eui2a+z9Gho7zNQJLCJ7xA2LJiy5tj3A/W1TUGULQuXQEL+OXcbaqiqeBGuY6VtQHCHdH3PT/tagZOTyAfy9TB8v3zswreIUavYWp4v7bfwn6bPPEJx37AANGmiJxu4sEfq4YJUobODG7OORnjtQ0E8HHMs8GuOMPIucnQnBhB6rUEU1WMLpBOgrbsakvZLrfMXyJEXKYYeUYBx9n4olSujEsQ/uURbHmMsrWGOj5lp7hHCMFmlXSPRfxj1B9rUC3aeN9K818w/otbL7XhutMcXGxplJuxOMb8VfI+T3j18l8i8pd7AODhLPE5a0+T3lEaAu0tdm8mSKDhqONAfSjCc6sYmzTPB2S5tnxG9qzN1Jb+rsPH2urjbNx1z/tOoUoIQJErxhKJKPA6YDIBhWbUIX8IXxE2y597IBb6dduFwxmurbAJBTE3vVerTSk1C0cftrBA/O/6zo2hj0jvdi+EEOb5EYTOyjMaWFwiHXPa6vdlXO13u2iqY2myID+D6l7iHoiVzj5Q4D1Ww9iNeKYdKl4PPdPamPLwBoRxRxdMS5rUyTsYhwY6OoUBEm4UmKypw9fILtYWPy1oT67zgXJereinNFVZlhZVl/A4QRbLBT7CF6Dizmtlhz6Kx4w5WTwJV+R/HDfQN4WniMIi16thEZNyzmFfwMuU1x7H4s67lc3G1Zcn9Tmwvi49lMyiW2heBL5UVhOjfaJCR5neqI0nBWjKFvqyjYoqfKLW8g+n2MbwISH8F0jO53IF7W1BfdUMRVn6hSh+g5v1Vn5T6bqE+XqxQNfGua3 k3Nyxp69 1vOTd/K7ZTwMZ28sQotoCqeSv7rXntzzC/pRv/VngvzpZ0PdiztQmcZ6aGxl2HMkPUY163elJWWbVnGl+UX1WR5RuxuCfk96E4mgXmzSNKoojsNBuDNhPT3nYnqR2Ctbt0jZytE5A1GHpGtdohgxCtAUGNIRM2+/Gsho28sIb8gUr+gRZ0N7BeeboA+fRscNvjWDsAr4ubdOt0Ns= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Miklos Szeredi wrote: > Just making inode_lock() interruptible would break everything. Why? Obviously, you'd need to check the result of the inode_lock(), which I didn't put in my very rough example code, but why would taking the lock at the front of a vfs op like mkdir be a problem? > For overlayfs it doesn't really make sense, but for network fs and > fuse I guess it could be interesting. But overlayfs calls down into other filesystems - and those might be, say, network filesystems that want to be interruptible. David