From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3D6ACD4F23 for ; Wed, 4 Sep 2024 19:56:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 834968D0006; Wed, 4 Sep 2024 15:56:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3B28D0005; Wed, 4 Sep 2024 15:56:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6353B8D0006; Wed, 4 Sep 2024 15:56:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 44DDC8D0005 for ; Wed, 4 Sep 2024 15:56:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E30E8C1179 for ; Wed, 4 Sep 2024 19:56:39 +0000 (UTC) X-FDA: 82528113318.08.5A523C6 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf27.hostedemail.com (Postfix) with ESMTP id D9BE640009 for ; Wed, 4 Sep 2024 19:56:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EEMM0Yv3; spf=pass (imf27.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725479772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXKm5OoeNAj97zv6xdsq0+8Sntxl3zYdIrsZpJIIln4=; b=2Dn/E4xW7oGIZdDdUJ8X/+ZleOtYzLfka7XE052sbw9wcya/sFZUgGbn4iqTeFV5wOrWyy /cGaY/wkgdHtEobmx4FUHGgvxbkJuWIV13qUykBp31vYwmbxWrlXYWRGmy6LGdFogBv5WL PQEX7O53OifJx6nJqmzKyJDHk8D5UK4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EEMM0Yv3; spf=pass (imf27.hostedemail.com: domain of groeck7@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725479772; a=rsa-sha256; cv=none; b=C5+gNVK2h6Tmb6nLlpVQ2QGDL5FO4YUjNjLUZBz+B5CeOxz0dSPuJShgZv0hzWGBVjzgQA gjkwqD7zjnm6nwgr5d419gTIkDk7COMGALU9lVwj2QSRcOOmblmebubTdQ4Q6FwTnX/vVI EkKIvd/mf7FSqaUCMPn7iej/vuJNuOs= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7d4fbe62bf5so36036a12.0 for ; Wed, 04 Sep 2024 12:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725479796; x=1726084596; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=SXKm5OoeNAj97zv6xdsq0+8Sntxl3zYdIrsZpJIIln4=; b=EEMM0Yv3cAXp8BHZi92EhrFeMMrZmaaK7FFsA6BJFFQW9StvRM/MzLJFhQBbk00FVe wfy4t68bvI6b9DsaNY1tJ8xBOwQf9+rwgPckKBKxUDOdzB+blbqETZZbYeafMMY71tZA WwNW7V9vkFToA37yHWA4rkWC8SXHbATqbvpwBXTvYpipcLn6IFU6YqfcIkPgvT+1wFsr A69o50jPURg0DhbkhKQMmcJU+0+MZakRjeFiZ8w4a5R7kibuqGuhmKcTPZEpezP7hmfT xrZtcioEwKqSQ3bC/AY5IO+JWVYBRm8hqNtE9ZaG6KX8e/6F3VzwATsETUD3if9qz2hV 0pJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725479796; x=1726084596; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SXKm5OoeNAj97zv6xdsq0+8Sntxl3zYdIrsZpJIIln4=; b=haVG+Ru2h4gshJgvSEye3Z9mkCUjUomEPU/QHFTFLz0YIXs78b+ICJ8Q1hfTXSf2nu P0Syj3wk6TyQalME6adzZCEejrNT0k8As3UhEvBH2TqM3HcJbsiMjAuw/ex5ZzoX71EK IrO0UlOK+l1kEnK681qrG5TykQAVf99Fo1d2YMwF/fYo7XUIsfCz97+x8UltVIASOACQ E4w9JyrTCn35vgKqNKfrcOI8oDS+7cFMR+JaZjeZVoJPt9QFd477p50m3ZQRVVQheK2O bl0B/C37XVimdVNunPM1vIF4h/RvOVrO0RTDIbMTVPs5Pa/uYQ8Gnc4ujttfmPgLnItC gQvw== X-Forwarded-Encrypted: i=1; AJvYcCUF6u03Ag6KdaSVEbNkfiE1nEvK6KPDQybtMailXw/9EiqKvjP3OcJ6FJuwhlwhjfyJ4JdbgAq5Mg==@kvack.org X-Gm-Message-State: AOJu0YxTOCDzsY6YNNjfvnhu52YqnJxakCWFddzwuo3KS6t+LYvJvfVU zqcVo13bAs2HoNgg+UY33RTVHlCGbmub6TWGu1VhAwv7FzgMC6kK X-Google-Smtp-Source: AGHT+IGINGeaim4TRvhIQEM6ykwPKxm1evYG+kcEU10qSCo5XXM0SNJkXOvufjI9dUiZdkGv7hyW3A== X-Received: by 2002:a17:90a:1109:b0:2cf:eaec:d74c with SMTP id 98e67ed59e1d1-2d89728e55amr13615483a91.16.1725479795574; Wed, 04 Sep 2024 12:56:35 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da788d1db1sm3145888a91.44.2024.09.04.12.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2024 12:56:34 -0700 (PDT) Message-ID: <274f253a-e44e-431b-9dd3-a499843be96f@roeck-us.net> Date: Wed, 4 Sep 2024 12:56:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/damon/tests/vaddr-kunit: don't use mas_lock for MM_MT_FLAGS-initialized maple tree To: "Liam R. Howlett" , SeongJae Park , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , Brendan Higgins , David Gow , damon@lists.linux.dev, linux-mm@kvack.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904005815.1388-1-sj@kernel.org> <20240904011840.973-1-sj@kernel.org> <54zu64vxrhdxr4wtmwbewga44shu4f7lz4ffx2hxhag46b56hn@qgrgfrb6mhbv> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: knctfimhdkybmoh83rqfjsnz9unb85dy X-Rspamd-Queue-Id: D9BE640009 X-Rspamd-Server: rspam11 X-HE-Tag: 1725479796-508031 X-HE-Meta: U2FsdGVkX1+9cRzCHaB9fs7wlvslWwD0nRd4tVW0TOuiKN4xgpN1SzZNGP41dmuv+qGvKCSt+KBW8FYm0HNPqC5XJMNneZRhk/va3ZZ3gbkBzMBzhTk766hvsVFSpkKdQrWLn+a7qHKdpi58tanEq9iRszl8BWSHqMxcEIClULisj/N7QymAbMQhuJhVkmDhh3NFuxFYOiaQrHd/Kg8JPT4vsHORJUed/9/1uK4oU0+QXA6qrwAY/KGrQW7YoGbjPT1/aZ9ljs94lqEJVbS3ojcI/9+lfxdaYkTdtvqq63AV6bRALLzBcPTx35EUFJLFv46u38Dt8DFTJIhlrbctRPcYzAitHH34Wr7M//tSu0y9gTrDrBXQY8SGfo6KYoEbFuA5c3vI2CbB9ro6FDVfeq5hEkU+rOXWm5tT3TSRGnx2xB5jC39zxlbt0Zdzi6we4o+EVmKxb0gZvN2+P7Lm9xpTLLy20uU7xVaX1S2tMZEMaa9ExsONFXPclond5FB2vTmniQaWBg2Lvp4/YtktEp6X7cUtnql/zUTErMeaoQsErUgsmhZR9DWUOBkgZJ5mGFgGfQZececoXf1/3dabsDTVZzhlj0HPskRRQ7kN+eRg6a9/bfrSvCLpb6Rj7tSEqbWmP1jLU/TEn2H6pfi6wwwSSx4Nwj5wRwN66KRWjaqnjtHWAklgk3cw94EqYbNe4H3DqqS/KMKFJA12l8wXmqJr2DovOlaw2HFDvup410SEaE4ANHoOORzVgJq9PpC9q6OIO+XHbTHG5ifWMjT7Q2iNOrk1nEAkfG9zN8DR358XXcXdFFdPk97GCJSzsW8LXyjidu/nT87FMJKS6+Vf+uLVRD/OO2YEKiewxCO2QO/SDz6s6EXKcssLfPJ3nc47M8XWcGrJ1DgpvtMAq9SNvVEqCZCgg8N+mZT7IR5vEPIHXp22s2nHW8tHzf3Qhz5BjyY+jd2vWJimObkqKQl dBMJ2XgY DfoQBWD3lx9emh5H2hL/a728CntD9xkeuzEO/q9RrP51GkWKNJP7GPBpA9QQhfSrXihdwfM3yZEX3qr+/vkCt9ULFp2/B91JB4wmWyt5gOlUco0rvFIFix0MnQr0Hw9ykaN54YktSnsGNl0oEJo5q+q7Nei9ScS6DmJSQ20ViXS6illMhjfweCEjv4v1DgwBzchBG36m4A5R3r2y/6J6uv/iDjpGrByX/fkl0+buG51I3hMja0idcFB7v5PMeZJvULuCNaYsGTAHwFA9VhTOaDRLDm28RhiaGhYcZGdlKxMn0wriV6tHCLPYy7vx3p2Pg3kumY49R1SNyNPsmu4PR2pAXWOXSt9lKsB85UqAhfeKGD5kd7rH5lY+CodnabxKdgjYWQIrxy65YJSxMOgx/gDWj7WHKE92uKdHch5+Xrhrai4sQulw99sHQ3BzXAgmfh1nY1cHrAnVKUKD7MM/unUm/apXeQD65eqjzgHfYd1B/T15DeFlKmVlOQi/H+8iQLXr+xWZUZpJ+xjUS5/fEzfcVbXeqzm8LMWHSV0JWIkm46BTw8fNFCilDv6ZyPGiIRbuersXueHdwaBsyPqtRM2sps/eOzgz3Qh7bQXrQiI4yl80DT0vUXpX44Tr5O8tEzhljGxzkookvJSkM8lzPt9Y9Zd315MedWgPZ0aMAn2XM3Xcjfxc7s5JJOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/4/24 12:26, Liam R. Howlett wrote: > * Guenter Roeck [240904 00:27]: >> On 9/3/24 20:36, Liam R. Howlett wrote: >>> * Guenter Roeck [240903 22:38]: >>>> On 9/3/24 19:31, Liam R. Howlett wrote: >>>>> * SeongJae Park [240903 21:18]: >>>>>> On Tue, 3 Sep 2024 17:58:15 -0700 SeongJae Park wrote: >>>>>> >>>>>>> On Tue, 3 Sep 2024 20:48:53 -0400 "Liam R. Howlett" wrote: >>>>>>> >>>>>>>> * SeongJae Park [240903 20:45]: >>>>>>>>> damon_test_three_regions_in_vmas() initializes a maple tree with >>>>>>>>> MM_MT_FLAGS. The flags contains MT_FLAGS_LOCK_EXTERN, which means >>>>>>>>> mt_lock of the maple tree will not be used. And therefore the maple >>>>>>>>> tree initialization code skips initialization of the mt_lock. However, >>>>>>>>> __link_vmas(), which adds vmas for test to the maple tree, uses the >>>>>>>>> mt_lock. In other words, the uninitialized spinlock is used. The >>>>>>>>> problem becomes celar when spinlock debugging is turned on, since it >>>>>>>>> reports spinlock bad magic bug. Fix the issue by not using the mt_lock >>>>>>>>> as promised. >>>>>>>> >>>>>>>> You can't do this, lockdep will tell you this is wrong. >>>>>>> >>>>>>> Hmm, but lockdep was silence on my setup? >>>>>>> >>>>>>>> We need a lock and to use the lock for writes. >>>>>>> >>>>>>> This code is executed by a single-thread test code. Do we still need the lock? >>>>>>> >>>>>>>> >>>>>>>> I'd suggest using different flags so the spinlock is used. >>>>>>> >>>>>>> The reporter mentioned simply dropping MT_FLAGS_LOCK_EXTERN from the flags >>>>>>> causes suspicious RCU usage message. May I ask if you have a suggestion of >>>>>>> better flags? >>>>> >>>>> That would be the lockdep complaining, so that's good. >>>>> >>>>>> >>>>>> I was actually thinking replacing the mt_init_flags() with mt_init(), which >>>>>> same to mt_init_flags() with zero flag, like below. >>>>> >>>>> Yes. This will use the spinlock which should fix your issue, but it >>>>> will use a different style of maple tree. >>>>> >>>>> Perhaps use MT_FLAGS_ALLOC_RANGE to use the same type of maple tree, if >>>>> you ever add threading you will want the rcu flag as well >>>>> (MT_FLAGS_USE_RCU). >>>>> >>>>> I would recommend those two and just use the spinlock. >>>>> >>>> >>>> I tried that (MT_FLAGS_ALLOC_RANGE | MT_FLAGS_USE_RCU). it also triggers >>>> the suspicious RCU usage message. >>>> >>> >>> I am running ./tools/testing/kunit/kunit.py run '*damon*' --arch x86_64 --raw >>> with: >>> CONFIG_LOCKDEP=y >>> CONFIG_DEBUG_SPINLOCK=y >>> >>> and I don't have any issue with locking in the existing code. How do I >>> recreate this issue? >>> >> >> I tested again, and I still see >> >> >> [ 6.233483] ok 4 damon >> [ 6.234190] KTAP version 1 >> [ 6.234263] # Subtest: damon-operations >> [ 6.234335] # module: vaddr >> [ 6.234384] 1..6 >> [ 6.235726] >> [ 6.235931] ============================= >> [ 6.236018] WARNING: suspicious RCU usage >> [ 6.236280] 6.11.0-rc6-00029-gda66250b210f-dirty #1 Tainted: G N >> [ 6.236398] ----------------------------- >> [ 6.236474] lib/maple_tree.c:832 suspicious rcu_dereference_check() usage! >> [ 6.236579] >> [ 6.236579] other info that might help us debug this: >> [ 6.236579] >> [ 6.236738] >> [ 6.236738] rcu_scheduler_active = 2, debug_locks = 1 >> [ 6.237039] no locks held by kunit_try_catch/208. >> [ 6.237166] >> [ 6.237166] stack backtrace: >> [ 6.237385] CPU: 0 UID: 0 PID: 208 Comm: kunit_try_catch Tainted: G N 6.11.0-rc6-00029-gda66250b210f-dirty #1 >> [ 6.237629] Tainted: [N]=TEST >> [ 6.237714] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014 >> [ 6.238065] Call Trace: >> [ 6.238233] >> [ 6.238547] dump_stack_lvl+0x9e/0xe0 >> [ 6.239473] lockdep_rcu_suspicious+0x145/0x1b0 >> [ 6.239621] mas_walk+0x19f/0x1d0 >> [ 6.239765] mas_find+0xb5/0x150 >> [ 6.239873] __damon_va_three_regions+0x7e/0x130 > > This function isn't taking the rcu read lock while iterating the tree. > > Try this: > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index b0e8b361891d..08cfd22b5249 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -126,6 +126,7 @@ static int __damon_va_three_regions(struct mm_struct *mm, > * If this is too slow, it can be optimised to examine the maple > * tree gaps. > */ > + rcu_read_lock(); > for_each_vma(vmi, vma) { > unsigned long gap; > > @@ -146,6 +147,7 @@ static int __damon_va_three_regions(struct mm_struct *mm, > next: > prev = vma; > } > + rcu_read_unlock(); > > if (!sz_range(&second_gap) || !sz_range(&first_gap)) > return -EINVAL; > Yes, that fixes the problem for me. Thanks, Guenter