From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89077D5B16B for ; Tue, 29 Oct 2024 08:42:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 141D46B0096; Tue, 29 Oct 2024 04:42:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CB686B00A6; Tue, 29 Oct 2024 04:42:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B066B00A8; Tue, 29 Oct 2024 04:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B77BA6B00A4 for ; Tue, 29 Oct 2024 04:42:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5318E120FD0 for ; Tue, 29 Oct 2024 08:42:14 +0000 (UTC) X-FDA: 82725997032.26.D2B94DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 05B3840009 for ; Tue, 29 Oct 2024 08:41:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GWHTqsXy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730191157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PqbOX4o8QekAaeoqJJoSgx1RF08bM4J0RQCBXWiRBhM=; b=XHPM/3hvfkrz42amxkhKHuqAWcQbj+R0DZtFJLKuvVhrLMco50wOaHi0p229V9hMUbH051 ti5MVCoN7AiZm3xr3s+EXA/FGPIinaoOp6ztfEn7jQlEzqw/0Plxqbz+gHSfxYgWJhQTg+ dnJi9R+0wwcIXpgqGQ4FPO93JRUj9gs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730191157; a=rsa-sha256; cv=none; b=P5a83WVn6PRTanoD0g530EZYkUveIvzPGjWUIuAfq+UbV9ikSXu2vD3sQsLg034bVQpeYA H+2YSPbtGX+pENorRDaEop6g5h84APRyhinAFm0incAwKmOUTXfBr87TpUc9E/Kf18ybmM 84euhA0z9zuZ0y7xWxL8RdIdYPb6A60= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GWHTqsXy; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730191331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PqbOX4o8QekAaeoqJJoSgx1RF08bM4J0RQCBXWiRBhM=; b=GWHTqsXyAMexIcfyX0TdwVEXg+mvF6I+sMQhGbUcPsey+IF7U//04p7MMqzmBGvbg7URJO 3s2rjBOPuVH6+BjCBGwJQ1qwPR621j7Djgz2mM0/t9PqnjScDd2WI984Jz+kP0jcwiVtjU GWSsnZGBKPkUvDeYmtw8obkyQq6ZMkk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-J1XB5E3nMI-VcMakTcpA7g-1; Tue, 29 Oct 2024 04:42:10 -0400 X-MC-Unique: J1XB5E3nMI-VcMakTcpA7g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d56061a4cso2808889f8f.2 for ; Tue, 29 Oct 2024 01:42:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730191329; x=1730796129; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PqbOX4o8QekAaeoqJJoSgx1RF08bM4J0RQCBXWiRBhM=; b=JyHn2QHK2jlv5P9cxApS6ifiOBlrraWu/r5+NzVWjORqXLZTmsx1aqM9HJRsauCOBY IEh/U7LEf0Ioux846re7CDwlrZsDq+1pmGgMlU2RdMFpBxe1yfnsqSrcNbpv8wnJRqlW QwejXR/9f1N8gp4ZvQec2rhnmLpI5s6fkX/HVPnDvFcC/ETDdkiM9bJvhPxIL6spO6ym m2Rs5T84ozTSOf8LstMfDOMntZd1XmUqfD4MON2heGm1tbxNB28WDMACtmq2n01wYN8X qXkAFtTuTwzeV7IYFarDX8bnPCicsnuj2HFczDVuNjsaNsja86nUescuSrhZ6dg7sTNQ vdpw== X-Forwarded-Encrypted: i=1; AJvYcCXbcy7qWX3WdsB6ekfiyKTlS+kjE9oEnatWOO3ORpQYwcjHop4plYJyan1L1rWNIr4xEuC356uYYg==@kvack.org X-Gm-Message-State: AOJu0YzyHfndL8+HUyWV+t7IyPcA/qdE1bzmRR/A+4Iyz8sl7MIPZZX0 SO33C4GLB476kpTUPoAODqB62AU0IGY/sDW3a8t3eVcNp0HVYrqqq7VgZGXFZHa4/IaFjX0nUq4 trRpRnRnIm11DmXy6QnjxRobflK9sCtyojByT8ugBnAcT6fbc X-Received: by 2002:adf:fa0d:0:b0:37d:45ab:422b with SMTP id ffacd0b85a97d-38061151206mr7912551f8f.31.1730191328783; Tue, 29 Oct 2024 01:42:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkqy6rsL1i7Ev7KcWcbSehsFZ0lln9PRMREV86SvLrdNJXDt6aeixci7eexjHQGLRbm2i2KA== X-Received: by 2002:adf:fa0d:0:b0:37d:45ab:422b with SMTP id ffacd0b85a97d-38061151206mr7912538f8f.31.1730191328273; Tue, 29 Oct 2024 01:42:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e? (p200300cbc72d8500d87aed8e1e805a7e.dip0.t-ipconnect.de. [2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b92f11sm11784289f8f.101.2024.10.29.01.42.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 01:42:07 -0700 (PDT) Message-ID: <273b324c-b7ea-40aa-8eab-faa6cd697bdf@redhat.com> Date: Tue, 29 Oct 2024 09:42:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: use aligned address in clear_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org References: <20241028145656.932941-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241028145656.932941-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 05B3840009 X-Stat-Signature: s1ype1hoa8nh1fjs86591d7743zwxakn X-Rspam-User: X-HE-Tag: 1730191300-867501 X-HE-Meta: U2FsdGVkX18ZNqYjQnvStr9YYE4ojdfP248QuuXfCerzKYH5ROoq+L/TLJyacAoe6mKe46xVJnFsbLrksKEoOGzZBKdU+k/AeUDlEgdmNW3UHvYpoc7lNqLGlnU42+LroQ9eEs+pLhjBTmyfQbjCr1sMjyxuQD1FnNhuEB5BPoeuXee8Q3CzkOrSDBLD2fHYpnKQHKIHwX2rqfJYVwQVrnK0qa+408SRNm5IyEY1FSb9rIFQ4BmGUSXHXeMJVrUBJN0+xh23Wq4CFZRiSJ3BBxUrWkqhSNp/DXFkhYCjbQHVttsTlEIeaXFcrd9pp4R4JqgWkKW9IS8Lg5oJvhXmPxEcNgW3UujPUtrhhnvWlwhkNhJ96mEp2lXxMJevsskOX/Wnvk/G4CrcXXfdmUCDIwsonMethRmbePAethXqZ2eHfSeMQoDJP6ZCUnPzBr3Q47mkUFC6Ho0gXX00saDEgWlL7yCPI5mYryP3V9bZ1tUNjwqoVNWn9tVzz1FgfZ8XOvgdAAqgQjxFJzrFE6REDl4iYpDY0MKo0eHouPJUrnEvPsBXblyBqp9DtHUgVcsrHQPx42CMVONG/f1sDBT/ben02lyw2yJv+p5IK3XuzKfMfAFvem9SPItAlkUjKuMidQScT3MxovwLehBzQrVnTzCXaSbzJMcXD5IiLAdMQvatxlB7TOUa6kBsj5kxZmSa0pbP0W2lbEavKWR7roGnPiPF69Kj2VQ3BSvwD7Fo9sAx7D46DI62aICXdneUTH8uTDKPZ5wThEefnNBEBk5el+Bo42E3JYwkD6G+VY0zDO+jjEs9sLbYwhSqenhgp8XzMSTt70mITCTz35iYUJoY9RXMqnDGTQCfTi1BGIzixIq/6va4vN3Z1BlRgc7RGYczroacbiBguiRz4wZCvouEUZ8O/SekL261v8ZMRA5HgaRhRsr+6XwpQWF1gqoukegXXHIjXxRsFB0zc0KRzB3 h0MixeGu skgH5pz3aUVuAC+vobaGZeDoNnvTE0WAySzLglMIRsqlk7EjZAPvA5wZ/1n5CdApnduoIXC/jUeVPOEkKdsoiPO9VX00fSXR8ezs5d6HKeCuSKPxAXJltESicNjocCFCXtP91fZ8F6OTM3XQ4fdqP/DiYzgXVYkBYvC6dvs+YCCMjR8nUSFdBYuaVNw7yCZKGGcTv5Iv3kSRE3FatOKsavaKkOk2+8u1s1sKpCg/7s1elDNhVXzscQmUIORRMmDcv1FsaWNNVJDUNnyz9xOuUoOosgMYzLhU/jBuIUQtk0DflyGcOlrYW+y87OixOqXpp8nsnke9+6RlqwfgPIHatJOv0dPuG5Whx7I2yXBFFXH9pMciC2IG109EtDqB9I5vZGmtatRU9z0TVySEHKX8zAT58cNymrsrL/pZL+O8KmHwq4FSqr+L0GOI8gwmAoWT+p3IypUyffvZ43n1st+DsCGu890UbMtdHTvwxdCI/oGTArlU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.10.24 15:56, Kefeng Wang wrote: > In current kernel, hugetlb_no_page() calls folio_zero_user() with the > fault address. Where the fault address may be not aligned with the huge > page size. Then, folio_zero_user() may call clear_gigantic_page() with > the address, while clear_gigantic_page() requires the address to be huge > page size aligned. So, this may cause memory corruption or information > leak, addtional, use more obvious naming 'addr_hint' instead of 'addr' > for clear_gigantic_page(). > > Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to folio_zero_user()") > Signed-off-by: Kefeng Wang > --- > v3: > - revise patch description, suggested by Huang Ying > - use addr_hint for clear_gigantic_page(), suggested by David > v2: > - update changelog to clarify the impact, per Andrew > > fs/hugetlbfs/inode.c | 2 +- > mm/memory.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index a4441fb77f7c..a5ea006f403e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > error = PTR_ERR(folio); > goto out; > } > - folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); > + folio_zero_user(folio, addr); > __folio_mark_uptodate(folio); > error = hugetlb_add_to_page_cache(folio, mapping, index); > if (unlikely(error)) { > diff --git a/mm/memory.c b/mm/memory.c > index 75c2dfd04f72..84864387f965 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6815,9 +6815,10 @@ static inline int process_huge_page( > return 0; > } > > -static void clear_gigantic_page(struct folio *folio, unsigned long addr, > +static void clear_gigantic_page(struct folio *folio, unsigned long addr_hint, > unsigned int nr_pages) > { > + unsigned long addr = ALIGN_DOWN(addr_hint, folio_size(folio)); > int i; > > might_sleep(); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb