From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16536C7EE23 for ; Mon, 27 Feb 2023 14:50:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B5996B0072; Mon, 27 Feb 2023 09:50:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 565D16B0073; Mon, 27 Feb 2023 09:50:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42CFA6B0074; Mon, 27 Feb 2023 09:50:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 323016B0072 for ; Mon, 27 Feb 2023 09:50:08 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C5C08805CB for ; Mon, 27 Feb 2023 14:50:07 +0000 (UTC) X-FDA: 80513356854.19.840C9D4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id EE1A14000C for ; Mon, 27 Feb 2023 14:50:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MSi6pmch; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677509406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xVFwiCBVIfFFR8kctTViBDKk1JETgkz4F8ffh+Bi2ks=; b=6j45jvo2OhE1IhcjNqSCv3tWKevmlflc6pkXJrxD6oB1unp+RrEu6FFyp/UusYy3M9InLN ftaOEe7hVUaI2DKB7cS3HKjqcPUIBoCV+aB4F+9gf5lBC5HP6HZX1mrBvigbgGsWC5HZnz TGP2mavBzBo81iRMzrj2Aey710lEu/A= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MSi6pmch; spf=pass (imf07.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677509406; a=rsa-sha256; cv=none; b=ktNZtagNWU0GrnJMk5ojzlKWkr16s72kVEqsTt7uO8cjDe1suQxPycF1H6Fv+Jmke8fpkW lujcsBhVdmLwnoYk5n2ZVmGqXm4mT60ElWsK8hqwv4X6FvtslUYxVhxPSLc1nxZVz9aXTx XeHYxSVbrwnYw40b4yiZyyujQRkf61s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677509405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xVFwiCBVIfFFR8kctTViBDKk1JETgkz4F8ffh+Bi2ks=; b=MSi6pmchD705itdvYdhsp2iUdLgacitW1FZeAfSTZQLEf+eujnlnSoDhnmS9qtdCqYvG+F HdWXPzgxLXMcijiG7ownNMIR3WgWqeMqYCavPybZMyJlPWgoaOZW7L/hatcUdeM6Ncejlz /sANjKTzc56erLJZzujkPxIe5aiD50g= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-dV-XsYO5MwWkEY5Fc18XgQ-1; Mon, 27 Feb 2023 09:50:02 -0500 X-MC-Unique: dV-XsYO5MwWkEY5Fc18XgQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B4A32A59570; Mon, 27 Feb 2023 14:50:01 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4476243FBB; Mon, 27 Feb 2023 14:50:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230202204428.3267832-5-willy@infradead.org> <20230202204428.3267832-1-willy@infradead.org> <2730679.1677505767@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , linux-kernel@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 4/5] afs: Zero bytes after 'oldsize' if we're expanding the file MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2736266.1677509399.1@warthog.procyon.org.uk> Date: Mon, 27 Feb 2023 14:49:59 +0000 Message-ID: <2736267.1677509399@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: g6x4t4h6ixx8zc1mu7179q1gy9xihnm5 X-Rspamd-Queue-Id: EE1A14000C X-HE-Tag: 1677509405-771038 X-HE-Meta: U2FsdGVkX18/K3ybymLGAUw+ksOOvZSl3I3MaVirKgEDHYs5BNUhWCo6gGtwre2VwBvXW0fd9eJQuAcB2PaDxhv1mjBuqLY8sAFMRBSKW2ulSDUJenPdhz7zCekIZ6uVXdMNTOAaf5lIXBiH7w76bHu9Y5oyK2to7DS0I0P7DE3p7gyoH/9UIiLScjpMxkDM8GE/Akkfob+JcTjPd9QEyU7sKJdY6Nhuslcx+s5NU4vpURX7fSVqOKQ4w0VtDOHGeybyrdw+kSU/J9vw5BbOz+zj0TaUhX+N4tulVSMmikID2P0bbkRlpDmGWZGUmRjmw76WwKb0Bu7bmdb952AtLnOLsGc4Q8jkJSfJvnr/aTUd5REfQlHYlpQKlJvptrluC0Lz/GWu2CooKm3Pg6PU5CqfJ13yVHKmRoCSfFpF/i6AmXlUTgSAGodUF4e/NbhrDIkpgFtU3ZHLaYxbaJGWhUERqg+hK9WIA3LmisWXhBLrmZwQx1xM7mvM/ppI6XsKcZU8kZEpCRho6xYbl1PbOhzFKeRyrkMNBeVbICFL0yWu6tiH2aYM9yRf4LNUnl86yqhivJ22Pkx16VYXzjLxckqq5duKUqq6KYVIXs9JDf8uV8+2W4qPQFXVD1uB/J5o7GBFKX3h7NZgrtoNksNl2je7WUT10olEI5r+2soOoMhdST0Vzcj52FjjAfr8h9C/Ume1qubVjKSyUwj63uJSY+n8ZOcGZPw7M3KSl58AjxCuhnCmY29Wyt6vmlwfyW/WfDR35mTfkP6ZMdCuzBNWZ4mNFZRWiBIrBxzbqRdTCuFY4FGJUtuv2uQ02QdyZqijgTdd2foEdrI1bH8Jn0pjosrR2A9SIQ32q5VwLPw2DgDtQsTayudVNsxyuDc2vOkuMYVQYNQSsST/7iW4af72T+l8aiwDAXRKtx0vKnNgjzhE7V/3XP5LrBn8lzLD1YhF3jkdIYVQ7SWsk1KGEBE J+9Zz8ZP j0leR3GvaPzgEmnc0uNZI8KDBw1w+mbi6sTBMlD9DX9BL75IReOUa5IuNg0kFH5Ehp8xamNS3/lNEk6Nw+aXs/wBr6zs2BiUYpZ69fezA7VIwrMgNQAALFMof2RTX1Py6N44/OBbjMWOLcJjJIgUEzxpIfWpzkqxZTSRWHgD3NmErsWXlUp9Igfa8vvHo3kZRi5mYBpTg2lnOs1pw/3c3lwg2Iks3fTzrUaGsYGGIToSF96s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > I'll send a patch series with all of this; it doesn't seem terribly > urgent. Do you think there's a similar problem for AFS that Brian > noted with the generic patch? Probably not. To avoid deadlocking itself, afs uses a mutex to prevent writepages racing with truncate (vnode->validate_lock). commit ec0fa0b659144d9c68204d23f627b6a65fa53e50 afs: Fix deadlock between writeback and truncate the afs_setattr_edit_file() call that changes i_size and partially clears the pagecache is applied to the local inode before the mutex is dropped. David