From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA63C0044D for ; Mon, 16 Mar 2020 14:37:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 71B702051A for ; Mon, 16 Mar 2020 14:37:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="av1SeK0N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71B702051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3BA56B0003; Mon, 16 Mar 2020 10:37:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC646B0005; Mon, 16 Mar 2020 10:37:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C023C6B0007; Mon, 16 Mar 2020 10:37:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id A980B6B0003 for ; Mon, 16 Mar 2020 10:37:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 330ADE097 for ; Mon, 16 Mar 2020 14:37:47 +0000 (UTC) X-FDA: 76601479374.28.eyes82_43e67477aac63 X-HE-Tag: eyes82_43e67477aac63 X-Filterd-Recvd-Size: 4882 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 14:37:46 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 16 Mar 2020 07:36:09 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 16 Mar 2020 07:37:45 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 16 Mar 2020 07:37:45 -0700 Received: from [10.2.168.33] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 16 Mar 2020 14:37:43 +0000 From: Zi Yan To: Christoph Hellwig CC: Jason Gunthorpe , Jerome Glisse , "Ralph Campbell" , Subject: Re: [PATCH 1/5] mm: don't provide a stub for hmm_range_fault Date: Mon, 16 Mar 2020 10:37:41 -0400 X-Mailer: MailMate (1.13.1r5680) Message-ID: <27343039-37F4-440B-8BF0-EC59CE2E2A53@nvidia.com> In-Reply-To: <20200316135310.899364-2-hch@lst.de> References: <20200316135310.899364-1-hch@lst.de> <20200316135310.899364-2-hch@lst.de> MIME-Version: 1.0 X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: multipart/signed; boundary="=_MailMate_F73A8D02-07AB-4C62-8E70-1C60035CC50C_="; micalg=pgp-sha512; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1584369369; bh=PZVdBKkN3jhRrDXVfZJZxljvchsa22WjbsLC7M2Y4nE=; h=X-PGP-Universal:From:To:CC:Subject:Date:X-Mailer:Message-ID: In-Reply-To:References:MIME-Version:X-Originating-IP: X-ClientProxiedBy:Content-Type; b=av1SeK0NgamhgDQJ488tutbGAQ6tjkgStQX2SKNxd8AZRdW9d03RBM3Ij7knhvEpC Uguoe/wPiQYEyyK6NwTXtAMzhuFWYK5zxW87+Ys0L1DO76nz7FLRhE4nl2XDuEqks6 s/iIMdGLgCNFP+QRCT9Ch96bf8JIKGMjVNlmoA4XvmIJUfoa2PIr3anmX7dtWNCoO0 ZXTu9AFYamNoFb67n7jwE6lJmjqYAfE5slHb5eEcCzav68jq0kOvk0INc1FfYf6saK mq8lhhUDAfkSWUqOPEHayzbhWfRgKR2NRQ+krinF2/T9jfsXr7gsfWT7xoCJQLUSHx wZESmMFEvdRGQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_F73A8D02-07AB-4C62-8E70-1C60035CC50C_= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 16 Mar 2020, at 9:53, Christoph Hellwig wrote: > All callers of hmm_range_fault depend on CONFIG_HMM_MIRROR, so > don't bother with a stub. > > Signed-off-by: Christoph Hellwig > --- > include/linux/hmm.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > index ddf9f7144c43..c102e359b59d 100644 > --- a/include/linux/hmm.h > +++ b/include/linux/hmm.h > @@ -225,17 +225,10 @@ static inline uint64_t hmm_device_entry_from_pfn(= const struct hmm_range *range, > /* Don't fault in missing PTEs, just snapshot the current state. */ > #define HMM_FAULT_SNAPSHOT (1 << 1) > > -#ifdef CONFIG_HMM_MIRROR > /* > * Please see Documentation/vm/hmm.rst for how to use the range API. > */ > long hmm_range_fault(struct hmm_range *range, unsigned int flags); > -#else > -static inline long hmm_range_fault(struct hmm_range *range, unsigned i= nt flags) > -{ > - return -EOPNOTSUPP; > -} > -#endif > > /* > * HMM_RANGE_DEFAULT_TIMEOUT - default timeout (ms) when waiting for a= range > -- = > 2.24.1 LGTM. It compiles with and without CONFIG_HMM_MIRROR. Reviewed-by: Zi Yan =E2=80=94 Best Regards, Yan Zi --=_MailMate_F73A8D02-07AB-4C62-8E70-1C60035CC50C_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAl5vjzUPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKihMP/1n1zyTrNoEmReoWnEYv5aUsXkMNqWWL6sJW eclzuL/e8yacmshwOAThLIkQ+QHjOxrkb2WuzvZO0da1/Mh3BS7fQ7lTmeVjN3py Tss29O2ZbYeMmBuuCRx6oPNi6CISQ/pNGPGMSyJv2/NpauOiChDTiXwyxwjtRx4p msR5olWEnhyTQFnQqN4HfL5qK2+O0qBT9AM5wpJ5MGo7CupNNx3Q0+5KZYVPNpO4 vyPrI21HzpvDFz1kbhuAxT3s24WrMCFeggIpVogLBUNUCaBpIO8T4btjfiKehTjm GpknkB3zwTiCj/gdhhnRhGpBN6lgYaW9pnfC7DuQeB5lMyJc4k5o+Mazf/tSkQP3 F9u9/oXmPwilfXRKqcy6m4W7cox3WV1mUYTsVyEsSIXnnVhKH5wpE20VO4UXKMRQ D6Gy+aO/SbOlG1e2noiNu1qfGwz9upjtf9Or4m4Ilxaz/aeoQHJbvBlUR9MGCtKp Xqddr6GSAQjETZ0LFPjAEhK83TLOl055NleSd5IMLfEi0OsxpjhDOiFqrI0iPFy3 BftPXVkxNoKaw2vQUPjD5Oh+6MU3N3jdizK6/3mLQnqQAjLyN2qi4XZu92H0EX0Z VrvgGJrznlv0+cQKr3WOvRH/iuA1gsMlWXqATY+w//ww+rFXEqxG5dCJS5mJ2u0j Cn6O46AG =ebqe -----END PGP SIGNATURE----- --=_MailMate_F73A8D02-07AB-4C62-8E70-1C60035CC50C_=--