From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7960C64ED8 for ; Mon, 27 Feb 2023 13:49:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406756B0072; Mon, 27 Feb 2023 08:49:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B7076B0073; Mon, 27 Feb 2023 08:49:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27E026B0074; Mon, 27 Feb 2023 08:49:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 193C76B0072 for ; Mon, 27 Feb 2023 08:49:36 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C90784048D for ; Mon, 27 Feb 2023 13:49:35 +0000 (UTC) X-FDA: 80513204310.11.0BF6EC6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id EDD5320014 for ; Mon, 27 Feb 2023 13:49:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uon7j15w; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677505774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mbh0k81SJj8KXcQWsPETE7GSsJc/6C/vn1XuCZ3ElNk=; b=SSiB4792j9dENwzBzrA3kC48uqvvKKwo4th6IMM0FwZcj+7/O03skMOIRs74obdzS19VXl oLYdHPrHPiD/K0aEjptVTl9hWu0/3L3CkEZWY4DnMn7w4UNdcXb5JCCN3kao1ylkMBM6ap NzY2Ho3IiFJ83z24zTd7SCjpwOK42eo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Uon7j15w; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677505774; a=rsa-sha256; cv=none; b=QYvZc2UYbvcC1b/ilKdreZEfyLndYoWQUGavA0HJZqtpSwcdERxejXzqNLAyUhupEOW3KG uYRkRE+5EHT0XL/SokrfFD2s2G+zw8cZsRkhnXjkEhW6ktjuzcVvhUqA7gRD9Qe488O0bg 0qL12fW8vcm/j2/uZ/ded96gN0qFZAQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677505773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mbh0k81SJj8KXcQWsPETE7GSsJc/6C/vn1XuCZ3ElNk=; b=Uon7j15wU++yk+aNeA+60EdwdxV/xnUR4fjRhduq4IXsnbeIxrVM2xlBjWGbYXyWcywNQf slcYjqmSy2PlsiA28gTWIha5ixtTBxMi2AuHQFxme2aO8UdOY05dmCo+Y0V187KEQU54fj 2aZH23dk7ylmSx5LlUW443H3og6FfkA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-612-SA1C-3EVN9iuDzHDZrUQJg-1; Mon, 27 Feb 2023 08:49:29 -0500 X-MC-Unique: SA1C-3EVN9iuDzHDZrUQJg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EEC33C21C21; Mon, 27 Feb 2023 13:49:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28010404BEC5; Mon, 27 Feb 2023 13:49:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230202204428.3267832-5-willy@infradead.org> References: <20230202204428.3267832-5-willy@infradead.org> <20230202204428.3267832-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , linux-kernel@vger.kernel.org, fstests@vger.kernel.org Subject: Re: [PATCH 4/5] afs: Zero bytes after 'oldsize' if we're expanding the file MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2730678.1677505767.1@warthog.procyon.org.uk> Date: Mon, 27 Feb 2023 13:49:27 +0000 Message-ID: <2730679.1677505767@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Stat-Signature: b61bu35ie47ryk6zubxksf6yu5mzzmsd X-Rspam-User: X-Rspamd-Queue-Id: EDD5320014 X-Rspamd-Server: rspam06 X-HE-Tag: 1677505773-142040 X-HE-Meta: U2FsdGVkX19juAwtWxVBEkLLVHtmrxHUJNXjwrGSUPisKXMdLh9wuB27zWNiBsoQmQqTe2wh4SSgWPGfiCRMpvvbjg2te/tFwsBLaoO4XKmkvbkETUWsjFFpTIm5QEOneyxnzEN63Lc9y0Et1McqeufB1RGlmKs/rSN9ziOFuJEpn4LT1K6viqgXBLl1BzAQyRwdu7KDvvgt3NJ1hPt+foBCkVkd54o0PSl75mJWARLv8fbYINasc5cVoUv95bKSyXyY207Dt2w2veAr3nN2125zV5BgG+2QdQxlrpbPfMpdZc385FhqDDvRifHGVixr5aLO0VCp5S41Ggjl2xs2EOMOV0ri7M+6Lyn6YlP1s+u/5c2PCTL487iP4oGl1fdeXHsxbAvHaByXqFMTX/O53Rzd8RvtkP8hJxshkLI8lDGeVMUUgx0JbaHP4Iz2T60uvmhhh0zJKxm8IDW67uaRl16+7FdpT/EQrdA1HkklIhhQjU114oR1x4yeoikPsRsfVLgtfAaDGo3JOBn27pzL5oRE7LTVetSpHwH2to9MZ8CoFZXGxbhxdWm+wpa7J6A49bNGh+jtvOhumnVK5deSQNLHePfsrAOlExMfBLgpyhNdzIVcYNqB6i/1BULObi5tbnNbmvZ50Mzr4WzfVx9Bx94dFseSekl13e3ipeTE8rzw2K05XDIyQmXtLua1XfK2JyTUhHaKSnezEvyrPg8Jaz6SFZ0alYZ6cypn8+/uiHVlbfMh+I6RoXGhOfyt/UYe4GldYi+0gU1tlT1qEvfBs7aJlixN0PGY6DmSdBoGvoS/drtgukbINbmwxNtzcoeglseDlaKgg/gBYpEjcqtfJYe/jaZHRAX8/oeT3qX7e8Y9yxh3shcTKY6738SQAztc/mlKKaZRaH/diHiig1i9ehhxVbc6XaI1IsXHMi+DFvNgMCJ9g7ZoFu1nnovB+VQWH0qBXeXKcbkstqmbisW +LmuopWv oCVZFoymYa8wWh/8KqPbvwM6Yy6PNEX3v8gvIYorhHLx0qNnt37OupOIdqJ7vrizBcLHnzXXptncKRMAQOAISGvmJEf0t6rE4HzXDKYU8CC7MLhTtTbrXFAa4KlfyZTb/Wu2CXfmBhlEcBYFfDlmqlgBrKci3DxYanGDcWWfkt81M/vmgh/dGOpxsEV9snSB0LOfp1OyRA7BsQivHOi1NFVokNk/muM25cZZSyQd4ElGeT1yORnh+Cu2w1hnAaS9Qwfq8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > POSIX requires that "If the file size is increased, the extended area > shall appear as if it were zero-filled". It is possible to use mmap to > write past EOF and that data will become visible instead of zeroes. > > Signed-off-by: Matthew Wilcox (Oracle) That seems to work. Do you want me to pass it on to Linus? If not: Acked-by: David Howells