From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D3ED68BE8 for ; Sat, 16 Nov 2024 11:24:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4516B00BB; Sat, 16 Nov 2024 06:24:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 953B16B00BC; Sat, 16 Nov 2024 06:24:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD506B00BD; Sat, 16 Nov 2024 06:24:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D64A6B00BB for ; Sat, 16 Nov 2024 06:24:58 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B89F4A182A for ; Sat, 16 Nov 2024 11:24:57 +0000 (UTC) X-FDA: 82791724470.25.D7D669B Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by imf07.hostedemail.com (Postfix) with ESMTP id 148A740004 for ; Sat, 16 Nov 2024 11:23:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=e6HMrvPi; spf=pass (imf07.hostedemail.com: domain of Julia.Lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731756098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anlUiHWGDGyJ8xswjmMdLXKoB6PZ+VXioMuGFa77dbg=; b=i/5IY5KlmBIhShm0/7wfRMfQ39wtZQ/YiAZg/NeHIhXWfMr8lQRlU9c9isBbbPdcLXPuQ4 vYlKuVURmS8kQRgxZgyrR3YEZWTSy2yK0eS9cVz5l/Rqf6qgvb1WqaBrT6lRUvfKa51EdO ohzRJlmDAnrUoZm+beEmwZRA8L9wapw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=inria.fr header.s=dc header.b=e6HMrvPi; spf=pass (imf07.hostedemail.com: domain of Julia.Lawall@inria.fr designates 192.134.164.104 as permitted sender) smtp.mailfrom=Julia.Lawall@inria.fr; dmarc=pass (policy=none) header.from=inria.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731756098; a=rsa-sha256; cv=none; b=0fF34Y2AdTCtsmim9Ib1okjXcz/l/KtqrCOMtbyh+GHKcKqzwGOhbtfs4iWdLFzZz4E+/P ekdu0aV2SBd+DyrjVQtCCc8c5xa9GH7IitHq+FjdrjzKkxFExGweA6BH3/BZ4AHm8sd7KO mKhO6yp0USt4suZBJ7L+jWqL5Fkg4Jc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=content-transfer-encoding:from:mime-version:subject:date: message-id:references:cc:in-reply-to:to; bh=anlUiHWGDGyJ8xswjmMdLXKoB6PZ+VXioMuGFa77dbg=; b=e6HMrvPibM0Fbpr/ONm0hFVcMKT8wC0+mQJzKmTLL/6XVEyPLKe8HZWV 9C9LRPkcO6Hd6rCjzjqag+sCK6WeODO+KGVznFmYkAs5A6UnqgiSZB6Nc xXNWMuA+9KGLx3MmUi1yOamiphAXkkAK5LOz38Lay2oYzEJOtPfPHDOwT E=; X-IronPort-AV: E=Sophos;i="6.12,159,1728943200"; d="scan'208";a="101793166" Received: from 105.39.22.93.rev.sfr.net (HELO smtpclient.apple) ([93.22.39.105]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2024 12:24:33 +0100 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Julia Lawall Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 05/21] powerpc/papr_scm: Convert timeouts to secs_to_jiffies() Date: Sat, 16 Nov 2024 06:24:20 -0500 Message-Id: <272B86FC-5CC9-4A3A-ACE0-F268E4E61C3D@inria.fr> References: Cc: Christophe Leroy , Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?utf-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen In-Reply-To: To: Dan Carpenter X-Mailer: iPhone Mail (21E236) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 148A740004 X-Stat-Signature: q9gudskz6wf3dftbadkh1s75363wm8jq X-Rspam-User: X-HE-Tag: 1731756229-142364 X-HE-Meta: U2FsdGVkX1/gGohkRgd7fdxfgsAH6iM6bfl7047iM/ERzbM59KP4eCz1Q/UCeJkQJSyRSMQo0KKMEoqFmRvblVNBznWk5SLS9+bqMJtVl1+K2F9+84vbSEL2006d7pFWNp6MJrqwksCSV6C7hm9zjtbPeo4QtMJb2Ka/ez4Mg3uC0QCewVUJkzVx1YXr3/p/GESpZ7w6PMLS6b0jnGkmJZXGC84pbXhPsY/oKW/w4WnUwYEkrMylHyOHA8He4W/66OPz1AatzUThGJtmdPGhJ+hxmUOVhTGyIcHd6Qx4ucbL6OyGWcNee1cq/WJItbaXH+msZ//AySzzs2rHFiDwzbKGJNn0eIthle25fG3qVrKVqVNvm5MKtBkMDoByPeH9xK9Kf/FBAT25IEz4Lie3Se5+JXYJD9OF2c5AlhkTFs1wFTFZM1v0aOzQT2wMjKlOgNYMbb3mQr1C1lD6KT5U8FKtBa+Hhy4v+RR25LYggp3Sy4ww6V22soGR+3YwNosKH2kXKu4nSvRsoh/5m9VO0puThX0JCfTxaLpb/v5x/DhrCVVc0tR6HNaZI83bDtMdC2dWIGs2Vg3VokSk/YXSFHrrzMNSqUkBoHXOrxc9V3v+3PKJ4db3SMPKOLnF792AKGAh2/mO/qsoh8j/zUh+ZUKZis3EzahBkXVD6EiY7fcSsjjMT0iKAw5c7DJniTErPxNB0ETgvOvCm/uwIbmBRSuaRrLHuK7CaPb6uJ7FxwlLk7sPz625uUtQr36ODAZIBCwHCapQEWdIcUU8A8q61q/IFKJoAmRggWcZ3QkxNryHreD/kgRu4m6+xISvlc7xe4PbheEOnWS7O5xXxS0p0hPV82cbkZANRxaDcXtm2V/AoImdxF/IouV6D3+P2kdZ8jN/KEx+2Rl709GL2gg1jRGjOiQRmUNgFoO6UPJTLkgbVBM+xw39yRQSS7YS4uBX3rGg0YbjOb4HAll9olM yzByxXpQ kDpLOGIUVqgIHx6P3Ysa5gH9IW+Bh3tvKD47VuI/6NbcjY/qNOye5J14K0/WZ+xC/HgzBzOglvzAV3hYiK1+lx4MQzktD3RPkilh4wyVfV2FI4CYFBPsgZt/P7U+HtrcFQ2abvozze0cMxNnNrOTSW+YA3zGbv/W+VNrjl4jIVcGFpH7AROdgzW6dYg3pglieDAKO8svmIo7y4tZkVCZ01kq+PQzjzuyQhoS4sTp2T4wyFXh1lUq0ZBj0X9NbHFhZZdDo7z6UR+pv2kmEq47rMing80wE1HM3xhQEK7ocK3WEeB+7xQT+/dbV4Tt0b1666nqBVg4E6t8RC9BVFhyxcdqXPsVpffINVvW5AYLx2R2XFk0C6jNYi7PNYSuY4pdbi39ouaGsX9SjZe1lC44qdvPUz0mviJvFKYcA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Sent from my iPhone > On 16 Nov 2024, at 05:40, Dan Carpenter wrote: >=20 > =EF=BB=BFOn Sat, Nov 16, 2024 at 11:06:55AM +0100, Christophe Leroy wrote:= >>> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/pl= atforms/pseries/papr_scm.c >>> index 9e297f88adc5d97d4dc7b267b0bfebd58e5cf193..9e8086ec66e0f0e555ac2793= 3854c06cfcf91a04 100644 >>> --- a/arch/powerpc/platforms/pseries/papr_scm.c >>> +++ b/arch/powerpc/platforms/pseries/papr_scm.c >>> @@ -543,7 +543,7 @@ static int drc_pmem_query_health(struct papr_scm_pri= v *p) >>>=20 >>> /* Jiffies offset for which the health data is assumed to be sam= e */ >>> cache_timeout =3D p->lasthealth_jiffies + >>> - msecs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL * 1000); >>> + secs_to_jiffies(MIN_HEALTH_QUERY_INTERVAL); >>=20 >> Wouldn't it now fit on a single line ? >>=20 >=20 > Some maintainers still prefer to put a line break at 80 characters. =20 Coccinelle tries for 80 chars. It may have a command line option to specify s= omething else. Julia > It's kind > of a nightmare for an automated script like this to figure out everyone's > preferences. In this particular > file, there are some lines which go over 80 > characters so sure. Earlier in the patchset one of these introduced a lin= e > break that wasn't there before so I think maybe Coccinelle is applying the= 80 > character line break rule? >=20 > There are sometimes where the 80 character rule really hurts readability, b= ut > here it doesn't make any difference. >=20 > regards, > dan carpenter >=20