From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096A8E77188 for ; Fri, 20 Dec 2024 18:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D4446B0083; Fri, 20 Dec 2024 13:26:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 981FD6B0088; Fri, 20 Dec 2024 13:26:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FBE76B0089; Fri, 20 Dec 2024 13:26:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5E8D36B0083 for ; Fri, 20 Dec 2024 13:26:08 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D3E9E120A7D for ; Fri, 20 Dec 2024 18:26:07 +0000 (UTC) X-FDA: 82916166396.02.64DE0B1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 15D4E180004 for ; Fri, 20 Dec 2024 18:25:40 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X7d7lU5W; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719133; a=rsa-sha256; cv=none; b=sNYh+gmuUkz25jeuIPG8me+Lt5e4FxRdQkkfaZVCO9JHqpeY7qP7vVNIafSyhm4agQaapY Dqcp3OMTA1Eq4gInWSbW46M57jXy0XxDATcz/BgiXReidA98JtvxWG7X5m1J9REs1U5hUq W4qm5VrFA0R7a3NwBy3NUvRiDSrICdQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X7d7lU5W; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2MeCLnX166jP9QysgdUZvUW4hrcrcrvTvAIRbIxzP4w=; b=hR41h9YPjS23lSfoa17CJKIQn1iI1LGl6a4vABplAMpZ1l0qLBCQV9bgyITMmayZ9+oD3D TrhRC0SfMp71RZ+6H03T+62RMBQ9MY7nM2aXL8cVmx552ERNqJrJtLAsdkgsa/zjYY6Nsg Pw20zHsc7cVMP5Io/3g+ZhNZxV3QnSk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734719164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2MeCLnX166jP9QysgdUZvUW4hrcrcrvTvAIRbIxzP4w=; b=X7d7lU5WNT8UdyG9XjZpUyZfMMzeD3rc0w6kvpXGEmi9A9vx8sd06T0KTp2RoMu7iPteeh +9463jETtBm/NgENxyLaPnK2PYNav/PLSwGgTLpDYvsyLJuLDJ5edKWUan9LS/KbOku8DZ uKudipUsUGI9kC/Kdal4XgmTNqz1K+Q= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-uZGFE2J2MTOafWo6QzbR2A-1; Fri, 20 Dec 2024 13:26:01 -0500 X-MC-Unique: uZGFE2J2MTOafWo6QzbR2A-1 X-Mimecast-MFC-AGG-ID: uZGFE2J2MTOafWo6QzbR2A Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385d735965bso1311502f8f.1 for ; Fri, 20 Dec 2024 10:26:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719160; x=1735323960; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2MeCLnX166jP9QysgdUZvUW4hrcrcrvTvAIRbIxzP4w=; b=aWQ1eKz8s0ZvIItmGfxz2Lh6D4jwgL+Qmhfdy5w3fDOFe/KfPcg3lURSAjRtJImfiI DjXIgd2GgzbiZ0D1soW6AxPCmWoB4KwENBl0T8dGj5hl31rWE9lkYKHcTtjfd27zc6dn YbFm5YzqjikMCY0f0M/Meld02ac4drScxpAETSX55e/LQI/L+VSkUxt6FXbWxE7DqK+b XU8FIph3r+m5L9cS0+9ygY6rcP8CtRPm0T8M8PhGOWlVf2r7hWueWTKu4+2GRqLo7TqX 9Erpxma8VjcLOd7LXW/nEe9lvYyfkXCujDYIMr24cf82m3Qu+1LcKhjBiwDXl5V1aw+f UZIg== X-Gm-Message-State: AOJu0YyvQYRO44w2QGuAttnqo5c17BhXpDuO7pD4R/L8xT3qCapDNsZF QsuId1vpmL4Ww1kQ059A/9K5bmFPYZhBVRgEcnE8yq8ied46mRTirGm+8e8kF1ABkeH9n52wGQh g5npEo7K5nBeOZJhFtm68uVjhRewxe9gglOxMMJHlq7e8/g/4 X-Gm-Gg: ASbGncuCNgE9k6WvKWFegUZiUNZipPBvshYDaPfvjRXxNxo1FBF6tWRHC8oSAiCyJp8 LIUudtaNk4jEzcH9sMWsyB/IGiELwLTbFe9dL2oq0vv/l5iaxfki/tc2OVS3nWOj9s40KgA06PY i5mSGN6P+VsYNZ3Whos8pI9MjDLIPbWzrecm1ScLDEqz9RLNsAvNc/1dS6rE3ifFTpf4CEiXW4L MkQMA/W0p8rP2lJzD+1hIiQ8hpmAAFAyjr0S3SULx7avxOS6OA6gv2HPXM0B9cGHogayYAZKeg7 AKQzdQwjLkPixmd2/46U/KlAdSkYwoEq1goDNmeoJGzfBz4+4lUPVCm+0h1v4nimOEv2DhWxvfW X91gnrYXw X-Received: by 2002:a05:6000:186b:b0:386:3835:9fec with SMTP id ffacd0b85a97d-38a223f76aemr4373034f8f.44.1734719160107; Fri, 20 Dec 2024 10:26:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/3YU+ZC1R2bkl6mmsYfUhApvx5yXbab8YTN192Xdoh6P9GyjJeB3zD/3ysd0lJIrDOG92WQ== X-Received: by 2002:a05:6000:186b:b0:386:3835:9fec with SMTP id ffacd0b85a97d-38a223f76aemr4373021f8f.44.1734719159778; Fri, 20 Dec 2024 10:25:59 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366127c493sm51804105e9.28.2024.12.20.10.25.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:25:59 -0800 (PST) Message-ID: <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> Date: Fri, 20 Dec 2024 19:25:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add build-time option to set hotplug default type To: Gregory Price Cc: linux-mm@kvack.org, linux-kernel@kvack.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org References: <20241220144518.206208-1-gourry@gourry.net> <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NCGE3k0qliR2oW8WJS5c2SAzhUf1zAlq792fS0oXIEo_1734719160 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 15D4E180004 X-Stat-Signature: 3xz37c8ytnnaf8gr6hwhm887az4gka6z X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734719140-438389 X-HE-Meta: U2FsdGVkX1/upA8GoD1QOqb8JI1dB4N73xJmkHV1G6eKu6G0PmHSD95ks84QUtIxgoCVjf6FOq8iXgB34umeN+kMOJCtcKyx5/8w8IMAnfQL04oIYSqSCCPZH/nVJ5n1EpbC7amnJ28qEQ/Xvnjpd9n+c7+mdX/VyPXDYJZkpYncKYy9L67UQnSOsImKvgjfbXO6UP7FzuEmLpaVbi0Ib7BVggRGhJG3i978f4UuhhbmKmlJUc3XHCQIblgaG4UWJ8Ac1Z0GWFR/hmT036Yfgjyzm+GUg38e6xIsb6OegmXy6AsGI9yFPueH8b03zNjRbelm3/TqSxUt2u40u58WEyvUi5A6IQUCG3Bef41pVQEhVxn7ou7UQ6P6CcUitgGwjpEVlDOExXVJuuoL1lqDxXOpPx57+1BDrwHEGPWGhm8pFdUgfNUKPtpfZlJAoWaPGSQOvkq9kCj1kDBHrs/2OSckL4x1doxdAkPKvqlPZWsDgFNpwj2eZqzEYrUmLqIvL+Cuggz/rXDAkaihY1b2bVx6rTgj9yTEK35MVHf6jMCbBumtG83nSrb/5zzR5Pa47ebIbCZrTlVpV8QgISMzNB1kZOdOwCxh+sFf1FXH8pK0lNf9KPiZQIPYK4qu0SdL+6nNn+OdIdCN5qFZX6EPEL5smF0DhJwVAOehfklzL0tbT8i4ccQWg3uSggk6Oukn9LbvGG1QOja/okR41W4Min3edrkY1QVenXNvoXMOodz7niGks3usdwTgfPObzlKR0L+DfQq9r+afMGNbd+MQ6ohYrdUYKF4VCalorj1qWpMOluH0b5AaybVORJJ2TkytsRfT47oLak/wWt0NmLFpDwO+CDhCHGm3KX71rE/HlrgqmhsdjzLalt+OY3MGitLT7316XzDgBKIbbIIOdwIzJC80VAKHU4FFepUqIPuGiHPY7NBO05+xUajWP1aukdzA8tV21dqRB8vdYl6jznC sEnnUTif 1GGkUz31reHCjo7sv5HSEh2vaEm+7tSvo3C9/gxp6NQlXvO2eKc9wnAAyelv12zmaIaPMb4fV5BiDlREPm+3eva2yetofZ4hSXKIxGnuQXTVch4gAUB3kroKFPpVt08DA0sDHqIZ6tpT4ErTNkObW43+ai523ll/sSBKUSDYq9rJL8KkxDko+C33C8JFZJ/ySQ318aOr36m55SSwErLqdEEmBEipB0fJVwRCX2FD4lq6nD6Z8tRQvdCEvKc8bCIiLie9qyE0LapmZHhOItdXvTWODgGlxI2n5AQ/bdoRv3/wyjk3Rb0Nnk+kNdhBwrQUPmBfY2qwTW39L8Kdlw8HBFj0bbRrT+wz2+TvKf1Jbi2vA9Ucuii/wae2Xvj+Qe7SWTAx6rrxe/Wi7lIM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 17:37, Gregory Price wrote: > On Fri, Dec 20, 2024 at 05:04:42PM +0100, David Hildenbrand wrote: >> On 20.12.24 15:45, Gregory Price wrote: >>> +extern int memhp_default_type(void); >>> +extern void memhp_set_default_type(int online_type); >> >> Please call these "default_online_type". Further keep the "mhp" terminology, >> it's more commonly used. We cannot rename the "memhp_default_state" >> parameter name unfortunately. > > so > mhp_default_online_type() > and > mhp_set_default_online_type() > > ack. Yes. > >>> +config MEMHP_DEFAULT_TYPE >>> + string >>> + default "online" if MEMHP_DEFAULT_TYPE_NORMAL >>> + default "online_movable" if MEMHP_DEFAULT_TYPE_MOVABLE >>> + default "offline" >>> + >> >> Could we get rid of CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE and simply have >> all three types as choices? normal/movable/offline? >> > > Obviously doable, wasn't sure what the consensus was on changing or > removing build options, So I tried for the least disruptive. I don't know of any rules what we can rename/add/remove regarding config options. Distros have to pay attention, but that's why Kconfig asks you what to do. > > summarizing: > > - MEMORY_HOTPLUG_DEFAULT_ONLINE > + MEMHP_DEFAULT_ONLINE_TYPE_OFFLINE > + MEMHP_DEFAULT_ONLINE_TYPE_NORMAL > + MEMHP_DEFAULT_ONLINE_TYPE_MOVABLE > + MEMHP_DEFAULT_ONLINE_TYPE = (offline|online|movable) s/movable/online_movable/ Maybe call them MEMHP_DEFAULT_ONLINE_TYPE_ONLINE MEMHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE MEMHP_DEFAULT_ONLINE_TYPE_OFFLINE if possible, to directly correspond to the actual names > >>> +int memhp_default_type(void) >>> +{ >>> + int type; >>> + >>> + if (mhp_default_online_type >= 0) >>> + return mhp_default_online_type; >>> + >>> + type = mhp_online_type_from_str(CONFIG_MEMHP_DEFAULT_TYPE); >>> + if (type < 0) >>> + type = MMOP_OFFLINE; >> >> How could that ever happen? > > It shouldn't unless someone does something silly like > > MEMHP_DEFAULT_ONLINE_TYPE="i have no idea what i'm doing" > > I just tend towards defensive programming. > >> It's a bit weird that we are parsing strings >> when we can just decide that at compile-time using IS_ENABLED() etc? >> > > I tried to reuse the existing logic attached to the sysfs entry > controlling the same thing. > > I wasn't sure how to deal with the fact that MEMHP_DEFAULT_ONLINE_TYPE > could be one of three values and did not think encoding > MMOP_OFFLINE/ONLINE/MOVABLE > into the config was a good idea. > > If you have another suggestion, I'm open I'd just do it like CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS, and simply do if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE)) ... else if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE)) ... No need for parsing strings and dealing with unexpected values. -- Cheers, David / dhildenb