From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D8CC021B8 for ; Tue, 4 Mar 2025 19:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E9E8E280002; Tue, 4 Mar 2025 14:44:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2755280001; Tue, 4 Mar 2025 14:44:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5305280002; Tue, 4 Mar 2025 14:44:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A527C280001 for ; Tue, 4 Mar 2025 14:44:48 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2CF2D805A7 for ; Tue, 4 Mar 2025 19:44:48 +0000 (UTC) X-FDA: 83184896256.21.2590FED Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id CA3AD20004 for ; Tue, 4 Mar 2025 19:44:45 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwlfISgx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fFtZr7lC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwlfISgx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fFtZr7lC; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741117486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TqyJfscKY6wPCIzvMizjhxcGjT6FdOkeaod0/a9hsx0=; b=nKB4C1KeXpZTgnDFq+7x+r6LIKWi50K5v4U7FD7Mlx7YfYoYHumU1AZuneJTDHiV++fmXw EYk6UeYU2rIu930IhzlJyY6h94fD7/fMfGdaCUsnOkvMeB3Zem8xwuVdjNQCO/1+u6jJ5j FEgQ2FVRr1N843gfWcJ2loPG0Tr3ynM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741117486; a=rsa-sha256; cv=none; b=cZaPPoKpFEvN1uXWik/0Bkd5NP8qQTZJNN14SSAXHtRuvsv+Sj4YRazUrUlStGff4s2b9b yq+WdKkWGwKbAhY94t+uBIvuUvi2kQdpvOeyqLOrnZeAbsYMdR6is3rwNI48ZpWHe0/0cZ wkGsU21LlF5etuJei/PUso6i0yZer6M= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwlfISgx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fFtZr7lC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KwlfISgx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=fFtZr7lC; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3E5261F38A; Tue, 4 Mar 2025 19:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741117484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TqyJfscKY6wPCIzvMizjhxcGjT6FdOkeaod0/a9hsx0=; b=KwlfISgxzInnNK+mCrIDlx6S7ZweHFADm0sr8xfKu+tjGKkUDGk3jJ9tdfFu4tq+GqJRWF B8nTd5GgH/2hiHjaXmiRn+N7f+CTmzyJR3P/YWfiIHawZcBU01mjV7dMuKyTOi/3X0IZBA g9X4oPFp4HFbZvp6k+ZakDaFlniuJS0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741117484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TqyJfscKY6wPCIzvMizjhxcGjT6FdOkeaod0/a9hsx0=; b=fFtZr7lCsWujicLkiVU2HL0qvFTZRJXIF9/aoyt/wHbWHioxx6jQ4rOipVxJjR+FI2/BOu iyRO9kzvMCzDDLCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741117484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TqyJfscKY6wPCIzvMizjhxcGjT6FdOkeaod0/a9hsx0=; b=KwlfISgxzInnNK+mCrIDlx6S7ZweHFADm0sr8xfKu+tjGKkUDGk3jJ9tdfFu4tq+GqJRWF B8nTd5GgH/2hiHjaXmiRn+N7f+CTmzyJR3P/YWfiIHawZcBU01mjV7dMuKyTOi/3X0IZBA g9X4oPFp4HFbZvp6k+ZakDaFlniuJS0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741117484; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TqyJfscKY6wPCIzvMizjhxcGjT6FdOkeaod0/a9hsx0=; b=fFtZr7lCsWujicLkiVU2HL0qvFTZRJXIF9/aoyt/wHbWHioxx6jQ4rOipVxJjR+FI2/BOu iyRO9kzvMCzDDLCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1D36313967; Tue, 4 Mar 2025 19:44:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KZ18BixYx2dbEwAAD6G6ig (envelope-from ); Tue, 04 Mar 2025 19:44:44 +0000 Message-ID: <27111897-0b36-4d8c-8be9-4f8bdbae88b7@suse.cz> Date: Tue, 4 Mar 2025 20:44:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Kernel oops with 6.14 when enabling TLS Content-Language: en-US To: Hannes Reinecke , Matthew Wilcox , Hannes Reinecke Cc: Boris Pismenny , John Fastabend , Jakub Kicinski , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , linux-mm@kvack.org, Harry Yoo , "netdev@vger.kernel.org" References: <95b0b93b-3b27-4482-8965-01963cc8beb8@suse.cz> <6877dfb1-9f44-4023-bb6d-e7530d03e33c@suse.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: dsbsbzeznpmksqf95kbj93p1uqr3n71x X-Rspamd-Queue-Id: CA3AD20004 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741117485-392255 X-HE-Meta: U2FsdGVkX1+BYjUcC/pzdFZlbmDw7c9c8KIZKVSUT/96aNXcXJPl6WXw5xMvwPI8RMpO17XqhgM+CPcIgRPoo8c/oYtmTLbbUx5lqbl6XqSC+bfxHlI32ZQI1wkXoxNNpQ8TY4SE970QX5KiYjAzh17V+n2z20u3wjpqo43Vf1EJbo2h0FYOhVGHfVuZKBabhj9Bqy8iXJwSbhVvBh2soChk8dh0g4KlHd4j8h4bom+LsgB5einXccFD9TpoA6fQlXKp+EMrDxh/MxuxO9bsOYQ9AtDYAzNuG2yUUMO5cCXJ6J6mXK/E5F51GHJUSdZF645YpUFJZDh7eu2OCoMqpXdNJydNzDB5QfQ/bPex4pj39QkAuhau3XwqBKn8uTgMJAa+SBr/asjVULTRXpjZ4k6x6VyAHnHZE8wbsEJvLg9SEm8CNYY+6CM4haDvlXbfIuNhSh0RYXVTEZ8CrkvZXT9uqbuJGaJHvVf3savPMjy/551OqC9tqv7qMHtzgJkfmGWOcWL4HH1gKxWP3FyrCl/p7EXY2TSeOSr9Vq7MUFggvVpdPT7Qxmh/cGT4FGxXcspeoNgVPK+CKb1oP+3p6vLdj//yZy+D6ly7AzIJW+p6gLSsaVp98NS+BQYPpeEtOtevK8Bd5hxrgk4S6mLB9A67N05jZYCPSyGHGFohuMju3lO/XontQj8WS4YTkDp0PVfgXEm0hz5p0LqZYinJm/IUDFB1mx9ITOwAfTkkQ1RqN0BYfWtR9GrQ+qXg72vi4GV7Y5BdM0QkWv4THbMvzI0YG7HFty7qV9JbegkKIYz8LN4FVx+0qFMcI5U58Rb7RgZ/p5blDtq84xVNCWPDnBSGS0jALZkDpI35g+jTkvdCt3Y6eJgT9wlecx9o4Eln19wzagXYDemlB8Lf5HviZ5SwTlOEG6LPv6O+P0+0XE/UeSroPs5W+j4UkKlOukxxHLWjxCE0FHqZDsNrpD1 F+C4WT1l 24HGBr0/+3ekaCkdFI+Zg7pNXDmTe9rc2nBwEIPPIRKPIrjEZ79YKjwNhZag87fPpw0pXOXWI2OGap4ULVO1hJfWkQ7FXVYhg5e2AtGSgnoGz5NF2cbgqptjLXzUXl8QMPLnNBSPzu45gmwuKym8Hn33qqR1nFpnAOPWpkTYpazknWqNvL6/I6fPTvDvTsFJfDnku462C6+Wd4w2whd7t7LRrf8ZpNngMl4Nnp5iJ4bM627hPvO945BJgA9bQCkFlMKWFPTWSwlkKLBL0mTaNriuoNa3n2VRRghk9vvc+mrPqFa3BA9X9MkFYfvo9oaxweWYMdKSXZpTTt7TqCM6A/si2UI0i2ogW4iJSTkXJi7Rl0mCO3ShDdIlUGTpB9THIhmi0R7QFXjsiAGICXepsouu0rA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 20:39, Hannes Reinecke wrote: > On 3/4/25 19:05, Matthew Wilcox wrote: >> On Tue, Mar 04, 2025 at 04:53:09PM +0000, Matthew Wilcox wrote: >>> Right, that's what happened in the block layer. We mark the bio with >>> BIO_PAGE_PINNED if the pincount needs to be dropped. As a transitional >>> period, we had BIO_PAGE_REFFED which indicated that the page refcount >>> needed to be dropped. Perhaps there's something similar that network >>> could be doing. >> >> Until that time ... how does this look as a quick hack to avoid >> reverting the slab change? >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index d6fed25243c3..ca08a923ac6d 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1520,7 +1520,10 @@ static inline void folio_get(struct folio *folio) >> >> static inline void get_page(struct page *page) >> { >> - folio_get(page_folio(page)); >> + struct folio *folio = page_folio(page); >> + if (WARN_ON_ONCE(folio_test_slab(folio))) >> + return; >> + folio_get(folio); >> } >> >> static inline __must_check bool try_get_page(struct page *page) >> @@ -1614,6 +1617,8 @@ static inline void put_page(struct page *page) >> { >> struct folio *folio = page_folio(page); >> >> + if (folio_test_slab(folio)) >> + return; >> folio_put(folio); >> } >> >> diff --git a/lib/iov_iter.c b/lib/iov_iter.c >> index 65f550cb5081..8c7fdb7d8c8f 100644 >> --- a/lib/iov_iter.c >> +++ b/lib/iov_iter.c >> @@ -1190,8 +1190,12 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i, >> if (!n) >> return -ENOMEM; >> p = *pages; >> - for (int k = 0; k < n; k++) >> - get_page(p[k] = page + k); >> + for (int k = 0; k < n; k++) { >> + struct folio *folio = page_folio(page); >> + p[k] = page + k; >> + if (!folio_test_slab(folio)) >> + folio_get(folio); >> + } >> maxsize = min_t(size_t, maxsize, n * PAGE_SIZE - *start); >> i->count -= maxsize; >> i->iov_offset += maxsize; >> > > Good news and bad news ... > Good news: TLS works again! > Bad news: no errors. Wait, did you add a WARN_ON_ONCE() to the put_page() as I suggested? If yes and there was no error, it would have to be leaking the page. Or the path uses folio_put() and we'd need to put the warning there. > Question to the wise: this is not the only place in iov_iter.c where we > do a 'get_page()'. Do we leave them and wait for others to report > regressions, knowing fully well that the current code _has_ issues? > Or shouldn't we rather clean them up? > > I guess the real fix would be to fiddle with the 'bio_add_page()' logic; > we are always adding a 'page' reference to the bio, completely ignoring > whether this page is a slab page or a normal one. > > Discussion at LSF, maybe? > > Cheers, > > Hannes