From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F71CF044D for ; Wed, 9 Oct 2024 10:59:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 839286B008A; Wed, 9 Oct 2024 06:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2366B00C3; Wed, 9 Oct 2024 06:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EEFB6B0095; Wed, 9 Oct 2024 06:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 37F1A6B00C3 for ; Wed, 9 Oct 2024 06:59:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9B79A12F8 for ; Wed, 9 Oct 2024 10:59:37 +0000 (UTC) X-FDA: 82653768162.17.95DCA15 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 6987D140014 for ; Wed, 9 Oct 2024 10:59:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cTVCgORD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BmtD7CUf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TgDOqcVl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9tL5XNXQ; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728471536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ir0ikiIvIpYk96t9xdNZSowjkHHlslTNx5TY3hy+dI=; b=fIVnMPiWq1UuIUXjd3ILAv+1OAC/1C/ZW9LoRxZGYf8zcQZaRNDjUTMyCfitR5eagiZGSA xQY6637yDIgEfGHwVbOrIvLQgZV+tke6D9r277inCoDdm1roJgee/OgSKKavlQ+8liiu73 DVVUoqAWTJ72KPwLCFdNgh1VWh06NU8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cTVCgORD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=BmtD7CUf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=TgDOqcVl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9tL5XNXQ; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728471536; a=rsa-sha256; cv=none; b=VZ3m0Q3DKZ+KB+uHQpx1ap/4f44vG51vrMzP+redUdpYwiHpK+dIRvH8BEkVJRqpFzCLP5 le5PP1WbOIpP2wqpyl8+ZGQqxMdexXaxRpSlqJE9eKDFPCYwAmckFFLcFRYTUdGFyoJpzg Y4RV/Md7v4GaXgNqqSPjBoUMW2I/4aw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6589D1FE89; Wed, 9 Oct 2024 10:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728471577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8ir0ikiIvIpYk96t9xdNZSowjkHHlslTNx5TY3hy+dI=; b=cTVCgORDgy3x26+DjfzqUAzwLmq2LA5gT3AglGpejnjlPVow8u2Pezv/pNZGbm5vKiehB4 X057OpLYOV+Y5v5dP2jSJiCGj5seiEYw9KrMzrbmxkzc4wi5IQd15HWBIEebMuqwbcASuf FPNLospG/1OSOCSFxaxStf3sO+QXQu0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728471577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8ir0ikiIvIpYk96t9xdNZSowjkHHlslTNx5TY3hy+dI=; b=BmtD7CUfTvFm+isDbnR37JJ9ZRtZL/dZt2vh53MWp0vrLvH46sF+HpMP6jt2yh9gB7Kuv1 oQzip5TNgzxuwYCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728471576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8ir0ikiIvIpYk96t9xdNZSowjkHHlslTNx5TY3hy+dI=; b=TgDOqcVlUdGkUHMdqRo4rr4Cl+shSSdAJHxPadCsUucdRareGZJ0+DxekdVaMSpBPq2bU+ QEjg5SovMDyg4j9ecdKFcn0iiQFoPRGBHxAveZeSy6Iyd0gxrbVo63AiYec4gB6pomMCde 6qRIFZaJBugjRftRBNwoGHge2YmRz/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728471576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8ir0ikiIvIpYk96t9xdNZSowjkHHlslTNx5TY3hy+dI=; b=9tL5XNXQLe+K4CHz49QgHEAS4nXk6doU1xxrxBjsmv2Z5gIMLHgYFpEDm+74At4GBsFibi F1Bbu2+bNqqjDBDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C7D1136BA; Wed, 9 Oct 2024 10:59:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MWZIEhhiBmcIfgAAD6G6ig (envelope-from ); Wed, 09 Oct 2024 10:59:36 +0000 Message-ID: <26f13bdf-72fa-4400-84eb-2f876ff1e218@suse.cz> Date: Wed, 9 Oct 2024 12:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/slab: remove duplicate check in create_cache() To: Zhen Lei , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241009035455.616-1-thunder.leizhen@huawei.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20241009035455.616-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: zz4xpb9x7yqjds5cqz6zgckiweixqgs7 X-Rspamd-Queue-Id: 6987D140014 X-Rspamd-Server: rspam11 X-HE-Tag: 1728471579-527727 X-HE-Meta: U2FsdGVkX1+/gjIt8mh1FMd0x9w9esGDwD7PD8bTyxG1syVEtmAHZyeZU+yjd2TagrkUU0gmUpIilxYtICwYg5NFmVj3B1Ea+lknqlpl+bOBg+QEl5Yon3Z0MNKEdop3lQ9BSiJrhyEVVNjbeWVcK0/t05Mng+/Q+jPtCMuFFrwi5Xd91ex00MmgzTKg56ziLaIASPm3DUS8elgHyihXy47aS3YlYqXXAeoASc0U2PRFpQGSGCMmXlZqSYzN97LRz4etzLcnsWSfXBGeABXjO2OEl/c8kbTknv+HhOvon0Ca73bdxzAytpyNhtjPLwDBEMNLYS76PWn7Lt+oXB0pAtWwgEZ3b+Lr+uVBtfVxoA7w9R3KjSj6NvhjUWjwq17ANyvhV+XxbvZ81MyRLVFAEc/9nyAUUUPpNE8N2/PjHxrTbpyPsf5eeBJAm+Mml7n4BYuFSlKzctodzi7yofguQhP3oZspVjUJmqyVjg0/IftBPC37Ilvifl+P6m08OKr+O1quwns/pEhsSDc01ESkUSahzWO0w7VkA7YDyY1cEeVm+Uo1g9MXUiQqqvPWQLUimZnFzyzeu3nmPtYFJmBE/xzBUdqdYsm409DBZeiIPPyAFOznop0ufLq7Ohf4k4D5bb0zZ+eosa7Iuvp1ZHx51SxpIP/MGuJBtInEAGZqHgAYs1gkNbo+7gklxVxmSfIzs5MzwzVMjZHpSzuw976n5sFgo/u8paOEBTnfqMjmT5hvNWHgv9ZecGXZXmClperjlwB52xd/KwRhSXoUcBHbuVVOgUk25HtGv532puK+0kdapjFukcclWv3AhpxL/twZ792ZWtXTRrVlTWcMPewaphJ2y9tedQBZBItijLsuRi1/OjTunZA2vKJyOCnEaqfSZMWthYNpfRMl90IfGXA7EXoW/UgjwAGSPs6AHLvAeheXuSbJanG39RKKBORv540rJmzyW1NuRD0KybtmB2M VNkYAkKv e18sjoY6eqVkhealIH/vNmixqfcM5p8nzH45mmk7+mkDcPBHxOvh2f1AXEaJNmKqUn0YecaC0VOpvDrG/qGJNk67V7E3BO/M//NqmNzhQ5EwUPXQKE3XblzVFhbu8b6hJLXCPP+kw8hU/WhW8aeG1IU81VFQt9kATT9heOJhvC3BrZ0pyLeoqekljlKbX9CMR9jF8q3rTwo459W4qceVHey4b42ldelZPQh1t0aXQeZbGcqFtE3ei0nqQEiTZXxUkLR06R7lg1RbzBWK4ziRV/2ztj01j5Efvij6ZGyyGA9V/ItBFnj0IijZy5Kvd2RBFRVDtLN9LKQVjLld7bBvzk1bUvTD3CgtrlutwEz3CWRjM82jxy9VGmUBHb5drNB4pp/Hdg1rMi4xWvskFDAIn0ARb16TqQ6HokHhu29x3OsuURpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/9/24 05:54, Zhen Lei wrote: > The WARN_ON() check in static function create_cache() is done by its only > parent __kmem_cache_create_args() before calling it. > if (... || > WARN_ON(... || > object_size - args->usersize < args->useroffset)) > args->usersize = args->useroffset = 0; > ... > s = create_cache(cache_name, object_size, args, flags); > > Therefore, the WARN_ON() check in create_cache() can be safely removed. > > Signed-off-by: Zhen Lei Added to slab/for-next, thanks. > --- > mm/slab_common.c | 3 --- > 1 file changed, 3 deletions(-) > > v1 --> v2: > Updates based on the latest v6.12-rc2. > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 3d26c257ed8b57c..88aa64fc8cd2742 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -222,9 +222,6 @@ static struct kmem_cache *create_cache(const char *name, > struct kmem_cache *s; > int err; > > - if (WARN_ON(args->useroffset + args->usersize > object_size)) > - args->useroffset = args->usersize = 0; > - > /* If a custom freelist pointer is requested make sure it's sane. */ > err = -EINVAL; > if (args->use_freeptr_offset &&