From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F14C31D97 for ; Wed, 3 Jul 2024 12:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13086B0098; Wed, 3 Jul 2024 08:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC2F46B009C; Wed, 3 Jul 2024 08:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D62EA6B00A0; Wed, 3 Jul 2024 08:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B7B3B6B0098 for ; Wed, 3 Jul 2024 08:02:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D1DB40B3C for ; Wed, 3 Jul 2024 12:02:50 +0000 (UTC) X-FDA: 82298304900.08.23F7D0B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id EEE8AC0026 for ; Wed, 3 Jul 2024 12:02:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FgRJAzNv; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720008135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k0O3LLiHWeyi64UF8oFRUSFib4DeqAEYS++7+s3iLII=; b=4qEth1tBJ72qGF6IEsLULFU/lP2IgVfVQL1niMFsM/l/osuM5bEGaCPmgaI6sWa4J1794V OCkglCje5lmJriIz71w6tzCACGfqu2BeJK3xO4ZfHhNuhw8n4QI33bEH0ukOE5ftk3O+/P 13C6FZ6MhwuggB3wViRyefLheic/TzY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FgRJAzNv; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720008135; a=rsa-sha256; cv=none; b=czXGKPGdLWqPl5Drryo4Xdzj4fg5HyqidQG3fm4y4I9TgrOm5A6wR9xrM/wmW4qOJqqVWs lHLAswFpfXrlvEwMHAcIcuWLPVr6rqL5D3nd4EAk1sVmWRLPdcOYGaF5ACt/Tw7WrFtlEk JpkhH1mJnxs7RPIzEvxTQCjOEWDYoJE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720008166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k0O3LLiHWeyi64UF8oFRUSFib4DeqAEYS++7+s3iLII=; b=FgRJAzNvJObOwVeIauXzYGArULi4WG1ppRR/qpY8zrZKmc43W1x+wJIa9Le3hKuqFJiJPV RKsziDVI9dn61V6iNPuFIqgsTvUWGMYhrEvc8cs8h2mEgAMIRPLZZyzmSA4xoLygxrspdC yyUq3QQQfEZcLau34Guwggs4McOEy40= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-v74ga6IjOAK3stzhf2AK6A-1; Wed, 03 Jul 2024 08:02:45 -0400 X-MC-Unique: v74ga6IjOAK3stzhf2AK6A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4256667ebf9so36996035e9.1 for ; Wed, 03 Jul 2024 05:02:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720008164; x=1720612964; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=k0O3LLiHWeyi64UF8oFRUSFib4DeqAEYS++7+s3iLII=; b=U0YJiGIA3o+h8+aaBdzGVspVU4pn7Y2I4mzwv55bGTvDWdnEYx/G/H/d6nkaI4zaaw m1saKLII2VvK9Khx/Tat7yyfwM9UpgzA2i2LE1g+2JTbYLLcXqTJUVPL5si+/7c/kF9a EfmK6HEJB7aibH3LgShUZH8OStBqbwRdy7c+6h44VlSEVaIxGLiuqMnkXJ11anYD3/mR s8W/x0wf2pB24JzGyw8t3t2wLKaMVx0j1aIVegJhZP+as09rYhoBmUsNXBdK3Hjw1Be1 GUJmpFeEGksVMTaXUHJutLh18jMuENmdqxbvouACVAJ+prZUEI3evu2YyBEahMRpGRl8 FddA== X-Gm-Message-State: AOJu0Ywmf9LAsA5jXLEv/vb2OqJzYmUUzfyZsRXcJdWHQrg3qXOK4Arg IGs8cBy9SJOxiHPFber5/NGsenNTKOwUnmd26t5RE5DeG6REx3zqH5tfVcKHdy/tk7n7ELjEfpM X4SrFDx4hjTy8vC7YBkPYkbaIYRXK9lsKq5GduTvQMaj8pfdM X-Received: by 2002:a05:600c:4f94:b0:425:7c46:d336 with SMTP id 5b1f17b1804b1-4257c46d499mr74109115e9.17.1720008163839; Wed, 03 Jul 2024 05:02:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEn/QVvbFcA+I7LoV3kE5ke4kUJVVeZKm9LOWGmHEyI5xG3Y2TmAVwIluyY9UJmrOHK0iuNWg== X-Received: by 2002:a05:600c:4f94:b0:425:7c46:d336 with SMTP id 5b1f17b1804b1-4257c46d499mr74108845e9.17.1720008163388; Wed, 03 Jul 2024 05:02:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:3400:5126:3051:d630:92ee? (p200300cbc709340051263051d63092ee.dip0.t-ipconnect.de. [2003:cb:c709:3400:5126:3051:d630:92ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0e0661sm15543793f8f.47.2024.07.03.05.02.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 05:02:42 -0700 (PDT) Message-ID: <26efe5f2-0cad-404c-82ca-a556469ba9c7@redhat.com> Date: Wed, 3 Jul 2024 14:02:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/gup: Clear the LRU flag of a page before adding to LRU batch To: yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1719038884-1903-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1719038884-1903-1-git-send-email-yangge1116@126.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EEE8AC0026 X-Stat-Signature: rmnw7wu4zw6ugbxchqk9qmi3gcsxqwwy X-Rspam-User: X-HE-Tag: 1720008166-794970 X-HE-Meta: U2FsdGVkX18FMRJ529WTbD0F6ibLVd2szDrF5DWjFMxf4fhT6X4Upe0fLYDevyXjBpxozU9dhOTlNXXx/INKjWLX+Xn1105CvDTuKyeBbjzBbeFGCUmm11Jsqwbv26w+VJMRcvzLBFbY5UYKtmr9L3rsYmsarrd81EdsavIjwLddgOKIMjFNPTjoFD1I4yaxwHUgnVKK+mnmCCM8pdKXmhnZNC5ZFXp0WRm39D2vMwfLC3Dmmu3mtEYDqxltG0KQUiZ8C+GMy9UxFF4WSBcSF5RjVZ/iSJUYil88XfE65j/lXT80jHccHAUyRiEWRjwfaSV6hd9Etb94VsrV30+QxglOaw+bgmpaoxZyE6EoA7UmfXrWoMZA1KgkiaTD+XJt25TFLb+MLvarvHY51HDIhmV7aFNMwhGG7ivSWJ9etsiihe1bNetMQDwf4aIHC+ygmVhZ9IhSeC6yerAcnAbKEivAovecC19gMXG9j6NUQuFaUrPLP+JiKU2P58xyuge9tssBpNNeMVDHmXZ+LJ3LGTUUWt58iEJxvNwiPIy/yjHY91qSWCe2VF2kz+aymh7wN7Dhk6/Chx0LlY9BQVwqnTrTvkCxrdPITwYkihh1dGfb1oySu60Z+ReOmIMiSBKu0gG7WBWWn8SkZ63HxWC2z99YwU9qFgqPQ4yekYrqx9jIvTo5c4nqMa9XNyAqU4o7JPadpJ03Xgy+7F6Nh3vvle/vJt4U5XYtfeaOgt5ZI3sEmK8oHu3I0lZSq9oHb0HmDuWfU95UKho5GRU5XBrYkXRD99Pu2xkZy8V+DnuOsyzALUxUw4Mf/Rdm0Pgw1ElbPTGn6N52IW5NbariQ/2/814nIh9Yhlk28zL70tIWcDnMURF2XYPVQuX4zw837+pW1zhywp34BfjuslvJ5x6VwfGad4ZAeIejspok3Vd68bzXjCrUCxxPDT2uYEFVqqyL8cBoIhSs2qcpBA9Hj6d zMTBBAbN 5X4/g6hU7tUP1M1YD9PHCHjDahP22WiwysOwCdXdtYgdnlIfryW4MNAeojUccY+vwG3sdrTpPtinQInLftqlp356UJ4AlZiq33YffyWTVf5XR9DkJjTO22l7FvwOy0Wt6gsny2nMLZa9Ehqu5DJtepyTvq1eWjHNccVGQ4XQB3fe+hUzEY8gWKy9YMUxotyl0JTWiB9XtKb/ccoR9KH9OnG0vA+Cgzsrdhi5Kjy7evLpeUbC1b9b+OI+TkiOwZnH/I0/BB6dFcAYr77cYOvDp56HImFqyyym2uiBQlRlvLPacCAqmoYVNmHS7Fq8V259rnut/FdibUKN959Y2T938UQJivHqh+pVqf/Zv7DAj/39JBEl7HebOAIm1eCDJywe65MRKfYZof5f1Ba8R1Is9yFVrUY9Rr6X8pUbcPZLzPntG8Fw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.06.24 08:48, yangge1116@126.com wrote: > From: yangge > > If a large number of CMA memory are configured in system (for example, the > CMA memory accounts for 50% of the system memory), starting a virtual > virtual machine, it will call pin_user_pages_remote(..., FOLL_LONGTERM, > ...) to pin memory. Normally if a page is present and in CMA area, > pin_user_pages_remote() will migrate the page from CMA area to non-CMA > area because of FOLL_LONGTERM flag. But the current code will cause the > migration failure due to unexpected page refcounts, and eventually cause > the virtual machine fail to start. > > If a page is added in LRU batch, its refcount increases one, remove the > page from LRU batch decreases one. Page migration requires the page is not > referenced by others except page mapping. Before migrating a page, we > should try to drain the page from LRU batch in case the page is in it, > however, folio_test_lru() is not sufficient to tell whether the page is > in LRU batch or not, if the page is in LRU batch, the migration will fail. > > To solve the problem above, we modify the logic of adding to LRU batch. > Before adding a page to LRU batch, we clear the LRU flag of the page so > that we can check whether the page is in LRU batch by folio_test_lru(page). > Seems making the LRU flag of the page invisible a long time is no problem, > because a new page is allocated from buddy and added to the lru batch, > its LRU flag is also not visible for a long time. > I think we need to describe the impact of this change in a better way. This example here is certainly interesting, but if pages are new they are also not candidate for immediate reclaim (tail of the LRU). The positive thing is that we can more reliably identify pages that are on an LRU batch. Further, a page can now only be on exactly one LRU batch. But, as long as a page is on a LRU batch, we cannot isolate it, and we cannot check if it's an LRU page. The latter can currently already happen for a shorter time when moving LRU pages, and temporarily clearing the flag. I shared some examples where we don't care, because we'd check for additional folio references either way (and the one from the LRU batch). But I think we have to identify if there are any LRU folio/page checks that could now be impacted "more". At least we should document it properly to better understand the possible impact (do we maybe have to flush more often?). -- Cheers, David / dhildenb