From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EECC28B28 for ; Wed, 12 Mar 2025 22:17:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E48A280003; Wed, 12 Mar 2025 18:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99278280001; Wed, 12 Mar 2025 18:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80DF1280003; Wed, 12 Mar 2025 18:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 669B3280001 for ; Wed, 12 Mar 2025 18:17:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D532BC0DAD for ; Wed, 12 Mar 2025 22:17:31 +0000 (UTC) X-FDA: 83214311502.01.2288152 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 565308000B for ; Wed, 12 Mar 2025 22:17:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aB+onykU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741817849; a=rsa-sha256; cv=none; b=pgSmUu274V+XTbApbHwQSbY1m61+mz7yDZtT1ksq4qE9rlRB9R05+DllzQkPaK9s+SxwWO aJuJbCcUBjgZBUwB6D1R61OwaQ5Rldgp1ITuu8lIKEHacU1sSrDWvAitkQdlDPEroXAQll vHOrf44doDvwCDvbW3gIEK8h1DIgO58= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aB+onykU; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741817849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GjIBl5yndOQdnleTRVmAst04zzkiJlZJAcEZZ6NnjC8=; b=7T28uYwajfbyBOa/rIyTiJXtEAOCyyfSZlrgQU8r9C1lBj7JHKWuP1y/GPFz6fZp6BJTA5 FdHScFoMFL0m1/wqcdQFTHS3yLT3qXNoKkCebjsKWaXFH5vdkIpah4Z9LDyhl8LtsHf7mx LDrTKkM4f6v5MTB2I93Dn+U5PTWEJ5g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741817848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GjIBl5yndOQdnleTRVmAst04zzkiJlZJAcEZZ6NnjC8=; b=aB+onykU416EHhh48QzWBn0Nm0H7C+cS5O4i2WyKNjlXarUNtDnEBrjG52XOAJRb8EQj4P nYornZtXI4WFvKRvHZWMfuXH7GujPfmRRc3nBEZ3eY+9SaA2EqEMB8+QVmaje+2wcplsnG /wNggY0jhTDtV18/fBg/VxBN2S56bAE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-cwfyM7jIPjam8GaQ-ACU-w-1; Wed, 12 Mar 2025 18:17:23 -0400 X-MC-Unique: cwfyM7jIPjam8GaQ-ACU-w-1 X-Mimecast-MFC-AGG-ID: cwfyM7jIPjam8GaQ-ACU-w_1741817841 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39143311936so170181f8f.0 for ; Wed, 12 Mar 2025 15:17:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741817841; x=1742422641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GjIBl5yndOQdnleTRVmAst04zzkiJlZJAcEZZ6NnjC8=; b=PHQ91F6IHnHShekvzSL/jJrwQPFe5kke7o+Eb/IZBf5RnXkaNnjnYXiV69ZKg98r0C UiobsauDGcbb5LcIar2NIH2o/RPsPNKk52JydgpDyT0zPZLklS1Dl6a/aLL58jmLuWe7 8wqAQ5MEItlrLthUshyjAom2r/wHLV6LsrwPCf/288Zkc5TsM0EC3x6iCCL2678mMy6M BrNRPMPdwPeJ8eKox6vuGnCgJrCdd5SzsFmSisxfv593z3+laHEgoSGRZvQeKClVt7Ws DgClN8ctHlRLhWYIMYJh+vhk57tQN/L6Hx7/LWKPK8gK9sOTquADlr7oxm50ctnDsO8R RqHQ== X-Forwarded-Encrypted: i=1; AJvYcCVF/S9nWyMlXRySuOf1qp3mkNXg1ffKuZk/a8adLoZX4zA7IcgZEFs/mPtZ1EMCEXbA1qICcibaog==@kvack.org X-Gm-Message-State: AOJu0YwHYCkEUKyBsddFpENFRVIvG4hN//+VFHGWhfUr2nLETmVCTdpg wLcDc7nz0/1KCY5K8loBwclnBsSbONI21z8Jr+ZbmD0mdRhK2/UXi8aejN3POKXy41Uh2xJv1Yl fYim06nm0j1P2Q710kM/N8qCfgyf+OwcoiVoUgMD6041qbJa9 X-Gm-Gg: ASbGnct0tc2ckRGqto+paq+1T46CRm4V7/nuaGxCfGtOY1kmcGUTUkW88STIC2rb17W JrwwSAzCJNbhH8x2zrHEWZC1wb8asp6SjfloMckOJqAZ4yPziNqcNTeWf0ATszAFY66UCGuZpIF 4bX/Si5dX3oI2I5uKeHz1i+EH9MpX7V2D25Q8nUQHSGaWcXjnleEkG64XsxOilDjBbFJ9vQhrro SPcKO9MbGw4/j1XTECdGjoMlvf6wSFzK16RX8mQ4A4/Dst9z4WmdoAfFgiT+q0s78G3d91heKOy w7Ey411zEznPiz2KtX0nvo8jiZUyNFLxj2enb8yc2Zp/MUqwdIlZp+2bQFK2yeKGWR7T7Da8vE/ B+Sn0Z7I0l3OJqd78Uz62F44iDGsGzTl1gktC7kh9WLY= X-Received: by 2002:a05:6000:156d:b0:391:2192:ccd6 with SMTP id ffacd0b85a97d-3926c1cd9e5mr10444702f8f.39.1741817841288; Wed, 12 Mar 2025 15:17:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7ajs+DbkvWkZrtvS3kgtwWoElT+oDfxGjlF1xcQLWnYsT+dOgzewtbm0o82DOv1DRYwzp5A== X-Received: by 2002:a05:6000:156d:b0:391:2192:ccd6 with SMTP id ffacd0b85a97d-3926c1cd9e5mr10444674f8f.39.1741817840917; Wed, 12 Mar 2025 15:17:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:7c00:4ac1:c2c4:4167:8a0f? (p200300d82f1a7c004ac1c2c441678a0f.dip0.t-ipconnect.de. [2003:d8:2f1a:7c00:4ac1:c2c4:4167:8a0f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c4f9d59dsm62270f8f.0.2025.03.12.15.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Mar 2025 15:17:20 -0700 (PDT) Message-ID: <26e942e3-4e06-4644-b19b-ae0301bf9b2a@redhat.com> Date: Wed, 12 Mar 2025 23:17:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 4/5] vmx_balloon: update the NR_BALLOON_PAGES state To: Nico Pache , "Michael S. Tsirkin" Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-5-npache@redhat.com> <20250312025607-mutt-send-email-mst@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TFWfrSoiL6g_AvFNeX9mNmgQF1GOI4324Q7xmIvbywk_1741817841 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: uthkr7dgqwtzto8auabo4wcxupkq6zco X-Rspamd-Queue-Id: 565308000B X-HE-Tag: 1741817849-800913 X-HE-Meta: U2FsdGVkX1/n3arJcawA/81F+tEpc7wM47Y8HYeuNj85h48JkfM8jxDymbPXTTEEHTwZEG7Wq7qHzWbLRrXyhCWBNuYZJc2eeE8B/LzpLy8ZtJ30Xn3cGpmLSIV3LCHAkoiIxcKzVRwzG72pJzOm6TzyTLtnPJvOe+n3AIm7A5pwvmsMEQQhdWS48liMIZWD9gGJXDc220gB3xqmyMZY+aZOLSr24Ot6VrK5oHIxbFfTVRnGiWXSESZrhvbaY4oSnf+VRHqPThaNMyXOzF3XjALoli1EIgNBARmAM17XHosT3vESJqzfRpsJvttTYc/4txWy6XwJC6ttVSMCJ88whSMnyiZZSJe3YPf8b/abxFt6hf6fgC3Odf7eVrKktiUZcx4WhT8Q8C0NPI7fEowLe2+39ggQDJyeLQ6no91deRViJkTZo3VQTVRlENc2ayydotjAeb7Ue3kN8+sTtMEh/vH2oj0ueNIpzGfDM0XEnb3hCIttVHUxBAXW6vDh5q8zv1Ad3pcT37L34Zy7E4liO8OZWr0obSRFY6OMc5JspwZ+zgUuLwNlLo8PKQGneQLilb6vPj/Byz3fnT0cl3o1B3KNWKRMDV92KZfabPQekdOo36a/QLmtJzxGPbo//wQ22X674PHvZr/duxFHyNZt9evpoO0SW+vQa+5sX6Bfh52QciuGGV2aoMm0eJVWje9bDzGZy/PwcOlw9ZNWMBpjAm/b42037QhjWU7lSTB/IrMFdNr91I/0g4ven45c/9h1Gh/6Ww70E9bjifVeD9TNelAddEFAnfmI9eYtkPpG7nCjkezCiFX/OEDkjDZeHiBnSPucLoQbjaJ4p/Wv20U9wNZrBjQ7BeZSFIsK56TaMiScWvAoABKMjPTeNL1BZMdTnRkJpH3fT1HPiwrvcxpys3skVkCZ0XU7pm8f6YOYAlT8kNT5VV9gTgZM9ee+U68Au9U7R5qwjRoxCJrnFat Nyq1hCrd wkVgcJuKbvWa+AJLyCkPGvC2mxmc6cMII6/0uScB+pA9LCM8sE26Ri81k+1Dh/8QZeA6z8fARIlPsQCAVgSSHxRYTFeW3lwEmH4MjzF8amzmc3ldDx35AR/QXo2LSlHmbQgpcyY9FOsebUlqpZkctj8fAs66IiwVDugHg73C/p+iikkX4H9xClFF3R+cXwhilmG2H6jemvt1UNKeHFplX6lVG4vDj1J8W1UUZNh25/76kR0KegmPhRk+QYiETReweXvRrkPnDkh+yAqn05QsjHeljgDxwh5jpqInSRCBoMXeYwUHm/GiBibOIvA63kSO5MTzXplhhYcSIraS+yoOi5fGPruJtFJX0o6w/4gVugvrEGoRJqY27kqi9T9PKluonKH6yIJNVAc2G5v3DDvXbixpe2TgfIrblroiPFJV+J/XGNnRvHG2RWnVlllLlPQSyV3LspSSSNq5CpVsQrGaYeRi3h8otbJUzYHi26i9CoMED1y3zxpWD2eevvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.03.25 21:11, Nico Pache wrote: > On Wed, Mar 12, 2025 at 12:57 AM Michael S. Tsirkin wrote: >> >> On Tue, Mar 11, 2025 at 06:06:59PM -0600, Nico Pache wrote: >>> Update the NR_BALLOON_PAGES counter when pages are added to or >>> removed from the VMware balloon. >>> >>> Signed-off-by: Nico Pache >>> --- >>> drivers/misc/vmw_balloon.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c >>> index c817d8c21641..2c70b08c6fb3 100644 >>> --- a/drivers/misc/vmw_balloon.c >>> +++ b/drivers/misc/vmw_balloon.c >>> @@ -673,6 +673,8 @@ static int vmballoon_alloc_page_list(struct vmballoon *b, >>> >>> vmballoon_stats_page_inc(b, VMW_BALLOON_PAGE_STAT_ALLOC, >>> ctl->page_size); >>> + mod_node_page_state(page_pgdat(page), NR_BALLOON_PAGES, >>> + vmballoon_page_in_frames(ctl->page_size)); >> >> >> same issue as virtio I think - this counts frames not pages. > I agree with the viritio issue since PAGE_SIZE can be larger than > VIRTIO_BALLOON_PFN_SHIFT, resulting in multiple virtio_balloon pages > for each page. I fixed that one, thanks! > > For the Vmware one, the code is littered with mentions of counting in > 4k or 2M but as far as I can tell from looking at the code it actually > operates in PAGE_SIZE or PMD size chunks and this count would be > correct. > Perhaps I am missing something though. vmballoon_page_in_frames() documents to "Return: the number of 4k frames.", because it supports either 4k or 2M chunks IIRC. I think the catch is that PAGE_SIZE will in these configs always be 4k. Otherwise things like vmballoon_mark_page_offline() wouldn't work as expected. So I think this is correct. -- Cheers, David / dhildenb