From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B73C47073 for ; Thu, 4 Jan 2024 22:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74CAD6B02F4; Thu, 4 Jan 2024 17:48:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FB826B02F8; Thu, 4 Jan 2024 17:48:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C3576B02F9; Thu, 4 Jan 2024 17:48:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 465C56B02F4 for ; Thu, 4 Jan 2024 17:48:51 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F3EDEA20CF for ; Thu, 4 Jan 2024 22:48:50 +0000 (UTC) X-FDA: 81643120062.12.EA123FC Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2075.outbound.protection.outlook.com [40.107.94.75]) by imf24.hostedemail.com (Postfix) with ESMTP id D618D180015 for ; Thu, 4 Jan 2024 22:48:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rT3ET61w; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704408527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AdRWcujJoKcjIoiOZON2/uhCt34GwLiYiNDuUZGYl34=; b=mp/iou8ByrfCJIp8/Uq0l72k9U5P0ynvbGLo55iLvCSugNJOuNRg6ENCO10y0Ik/DOq1Sq +J4UtqzhGezi9zPZm6Bqf4H+mFu51UcTAHAtt8t2mwUypXSDSQRe52pSImF4thheSW69gA KnGDDB/zwHYEhrDUon+L/dFzvp6QuuA= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=rT3ET61w; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1704408527; a=rsa-sha256; cv=pass; b=fzEPiKwqx5PaINTvP0z4C1/Bx5p4RRJnt2u9O/xbRnqlT0u64SDvM49BM2cfnkKZ8i9MVP Ijv8dPlrCTBIrpkINyrnYsd0gyBn5HgukIFplInI8nbJosouwJB39lDPyHSTgN6AfhWwOn NS0WCGA8yPbgsLXDpwHsoDBVr8p5zRE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gvlYWh5z1AtHH6OQ55sNqCLokADluy/UVPng/UTwabpEuq2FBwZDOauDDCXJWKFJ7e6oYvpnoo1Tispyn8GZLtvsmjSvqc5+AOWw6wjVx4DxDquhmee7SvIfb1bhhd7MKsEcmObXN80Fr4y/GyZ/h8M19FEXHFvyVM+wjr+I5TEO15yui6+7/wTihoxK450YQillhvRao7UpMlxMA7alCgNtc013p/MKExyQ6I4mtPtdyXzISz8mas49aiDCTd9xmKOU+TWAPUAWhMRhxnHUW+UYsjid+Y9/vWKqRiH/spfmQ854m/zti3gowOBs72XhONdtFtTbscKIC4vOJg2+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AdRWcujJoKcjIoiOZON2/uhCt34GwLiYiNDuUZGYl34=; b=BrbwcFRNbcj0kSTiAfSJL8BGkrPpDbs5Jpb6R1yPbuffmXOr+/4Qmmg27f8m/2KGVFHtG5p6l/NBhPapuqmAeZjOnvpnl9iiDx3VinM7a6Z9nCdPwaXhbEvCrMKJTG0l05gvSkH367eV20tBPuGMnto+Lhj7scDL7rLoZBLePsLqI2YGD60/yvhyW6d9O7h2zx2UJGn/NGObwAbjVdTY1IhBxMfAqlJm9UD57PMYQSJx+DXDNfVeazfS5by3uLfFynHzIZ7nM6RslaM95kqpBZvzRUQi8cgt/6YqLi3adjuhsCVniQD/ZgO8qyM3LbMrtbT3TxASVUr3Ll9u//ufyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AdRWcujJoKcjIoiOZON2/uhCt34GwLiYiNDuUZGYl34=; b=rT3ET61wM14FYfjhslejQnLmkQ5+E9zBn2IageOYtIJa/U+tY606hhih82EZhXDxrvL7zbPBn9WYJ9SDiblIHLp9dGGBJUS8ijEHUUavc/lIa/e/Bf4T6/WkWNjryWf3ZMjWieXzyUDYQyE6b939NrARjez7GNm/ROsqrbCDXWUlg/9gvgRqTusEpxHUhvJpQKlqbVSrjgat5KNpLd7HZgIZsRq2nnie1h3TFM6c2F2Jf9JdSqBJNhMjQdP9L18M+JJtI/qzXTuSU8cBtR3CQHEH9fdnHU+Io76h9DWqFl98vciWQzZnwucpcvTO9Lp27RgOSXD2H+qO82ji/0CGtA== Received: from BY5PR20CA0018.namprd20.prod.outlook.com (2603:10b6:a03:1f4::31) by BN9PR12MB5051.namprd12.prod.outlook.com (2603:10b6:408:134::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.15; Thu, 4 Jan 2024 22:48:42 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:a03:1f4:cafe::12) by BY5PR20CA0018.outlook.office365.com (2603:10b6:a03:1f4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25 via Frontend Transport; Thu, 4 Jan 2024 22:48:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.9 via Frontend Transport; Thu, 4 Jan 2024 22:48:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 4 Jan 2024 14:48:31 -0800 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 4 Jan 2024 14:48:30 -0800 Message-ID: <26dc2b09-b298-4fb7-81e1-4bfba6afaff4@nvidia.com> Date: Thu, 4 Jan 2024 14:48:29 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info Content-Language: en-US To: Ryan Roberts , William Kucharski CC: Barry Song <21cnbao@gmail.com>, Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , Zi Yan , Alistair Popple , "linux-mm@kvack.org" References: <20240102153828.1002295-1-ryan.roberts@arm.com> <29007216-8A9B-4CA2-8A87-EB33E338CBA7@oracle.com> <84b43094-9b16-40a5-94e8-6dd4e859a01f@arm.com> <0d06b0fd-01f3-4a93-811d-f39c0b326b23@arm.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|BN9PR12MB5051:EE_ X-MS-Office365-Filtering-Correlation-Id: cad2e936-7bda-4b7a-97df-08dc0d774cba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X19E60Xnmj/5vY87Cs5ZUu1mCozodpSx8fZCyRTZ5t2fG7rHWjCxh4oglwkPpWhM/wNC7ZYtIOuDfqXdH/4CUplRpPNKo0KEkMAIgsOfnVS68MY6daZPDj9THUPgR/rPnH+Lhdp1E64q3qsSFeJqvS6C9RA3H1FMatKK6UynZ6tjKF1pEwFdrhgJGwitLESn5YvtoWsamJo81JAM78QXm+Ki2uGuuqh2DrW8jz/JQhsk14KUjGoBKRjrv1PTPqKbJ4zxp2Ut9QtrUft1qx9aY6yHbzOTkV4Y4C1Q3gD7NScMI3/ER+J7w2ZwKNUGRMYDVNQiYU34RFlo1eLHWeEEjKth39tmNHIUzpEnE/KY9Bp/hPwv070aAAFcMbOSTUFHxjU812xxTA4l7CjMt9fINLRJGx8HHJZukGE9Fv1F4DFFhc7n/8ZvxydS5EU2OHc9f9/6UqjUddm6iO9BlSDh3O0xwZpxzBRaYY3aa9s11LLxB9zuyMDulL9UE3sncbWGiUt8YWiTIQF0pIWQ97LwU5ZCDik9XcaU3fJic7tUwE/OYRVPKqxVwAg02vFxB1XGNSCmAoX4W/P3BSULZRtrgbPA4bIVEdP/xEejyin77JKzQEoKmvQCni7gwArJs3Smdu1daRjHuTcvAkrUMKbZq9mT9AZwJphg8vE/XRkvVqVBzPpvrGlaTfvx7k7VsXKEWvCV5NVSSNr5zoLxWSOiv0na47I/XFLiW95GlW1xHUyG499RROH6vguRmLYCF2BeCe98YCYbshz/iMMUw1HWTA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(39860400002)(346002)(396003)(230922051799003)(82310400011)(1800799012)(64100799003)(186009)(451199024)(40470700004)(36840700001)(46966006)(40460700003)(40480700001)(31686004)(336012)(2616005)(426003)(53546011)(478600001)(26005)(86362001)(36860700001)(36756003)(7636003)(31696002)(356005)(82740400003)(2906002)(16526019)(41300700001)(83380400001)(47076005)(5660300002)(70586007)(316002)(16576012)(8676002)(54906003)(70206006)(4326008)(110136005)(8936002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 22:48:41.7927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cad2e936-7bda-4b7a-97df-08dc0d774cba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5051 X-Rspamd-Queue-Id: D618D180015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: s15i9hfqe1btyqyf66kgh3i9hd8tqb5r X-HE-Tag: 1704408526-902822 X-HE-Meta: U2FsdGVkX19XPyyUo1JIC1E5/ZKNhZmXcareSQ35Exud7gi+/0bqzVuZUbWgnCrJ5Y/RVg/IPv5KMmj+IaxKLecrciYcHLLJxsJ7FWguS1rpTQBi80j98vHdivjpqgSY+T2KZzNNVDnopkYjPcRO0V8FYsWLLweamKCoaDYjFvJ8wA7lCU/MCouWS9CWtqkjZeKwmKI3IWHkBZCnXDWfm6eQcv7M+RJPGv8hjOelKVUCFyW+ltiEYkREFqBGMf1BU7/DYekTa//5Oa+9tNFfYuIoZa1+tMgzAT05Dq6sWi225xlZ9N/U6yuT7k0knyynIOHqK5AhW+4sPjeR71BxL1SHC9bVfABiPNgfPer/OfcAJQWzXFx45CWUcaEuMJleUM+Ivl0ryS+rnw507tPltJ9w8T8fql7cE//No4MZlWXlCjdp/I0YuZfqBxMjT4MJ1bjL8rDr4G6jjSa/XldhRSprZHklmn4fGQ3gGc4STTupu7RVqYYf07Ocb9D0q8FkjDKlmGJ/6ZHzfE4/jFrxeYK3fS2/+TpBcZeLA0Qb+ZMpoHNSegkj4Ux40lbIfLH62TY3lpyFpBLL0/wq9wjocLYLxrkceabKACtdEG1LTAXgzGfGN9stjy9b126q3TJVRoEyagiDNdCfFDZO5A27CsU8WdSCv7QsoWvicIQ7wngT/Ac1s/xxA70K+Ktrt72vIl2Sie484kZ58N+slSLM1qh8AsrBPLVqYrg+ajGarkML7TR4ul/zPJuBVhbQyn/wqn0avdKcstHe9gesCwqahFRuWJjhwiRsQ1XlP760o8sZZ0nCUSaN8b9lhqxJNYFV+oFkiLNnGFiox9Tj5ZLSVEW03srf6coY4QEkxNWh6eLC8aBBeFm0hU55wTdz2Ev/f8YbRs3CwuSySdJqsA2J4l2fXVdH7u8RNZSJaWjuYtSB9PnAUlkMJ+NobIN5V/mpsCtGY8joFz/TI9Bhh7f ZbOzhvcN 9IwuvPmoSuSxjJjZF2gwP7GalGBR4fPXH+51hkTcwvlzN3OD74krEjKXQUiUksJygaN9SbW68xevT1SP3o4phsYXsv74vGhQpbT1YmQ+uKjG1jS2B5rFzFS6GoRVRpiFp3QkKTFCHDdIi5N/Q/tYkkS2x83lnm3BkWw6G87JUAb3Xpo4ISWhl2ueEv3lMg36cl+sjK8j1ZSc3xEEK5psCuMLytJonffh6y7oPd2NB42jDevMSWte3escCllVag7puUVZVhg2MOJmlsMOUeMntpEZAS3f1NHlBmGvHwA+vCtWXeHhdNBCCxSH2qLje71BgMMhyBiKzkoEHVTho0iBGq5l6A//iwaEfNUK5mENNR6h9y0nBW4BTL8+mJBH3R1n/o3s8A4EuXmnqxIV9r+rdAybB4mmwILAd9nMW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/3/24 02:20, Ryan Roberts wrote: > On 03/01/2024 10:09, William Kucharski wrote: ... >>> The reason is that it is also possible to invoke the tool with --cgroup instead >>> of --pid. In this case, the tool will iterate over all the pids in the cgroup so >>> (when --summary is not specified) having the pid associated with each vma is useful. >>> >>> I could change it to conditionally output the pid only when --cgroup is specified? >> >> You could, or perhaps emit a colon after the pid to delineate it, e.g.: >> >>> 000000ce: 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:0000426969 /root/a.out > > Yeah that sounds like the least worst option. Let's go with that. I'm trying this out and had the exact same issue with pid. I'd suggest: a) pid should always be printed in decimal, because that's what ps(1) uses and no one expects to see it in other formats such as hex. b) In fact, perhaps a header row would help. There could be a --no-header-row option for cases that want to feed this to other scripts, but the default would be to include a human-friendly header. c) pid should probably be suppressed if --pid is specified, but that's less important than the other points. In a day or two I'll get a chance to run this on something that allocates lots of mTHPs, and give a closer look. thanks, -- John Hubbard NVIDIA