From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2862C7EE30 for ; Tue, 1 Jul 2025 04:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345B46B00A2; Tue, 1 Jul 2025 00:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F79B6B00A3; Tue, 1 Jul 2025 00:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 233BA6B00A4; Tue, 1 Jul 2025 00:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D0446B00A2 for ; Tue, 1 Jul 2025 00:16:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 135D3160265 for ; Tue, 1 Jul 2025 04:16:29 +0000 (UTC) X-FDA: 83614384098.14.B6FA99C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 4662840004 for ; Tue, 1 Jul 2025 04:16:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751343387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hrrcO1oyG2RTwFsOagsMTTPvY/bjrzlOzvbii22RdSQ=; b=XcEMZiFejrT5li+KvWa7j11ACz3GpjoJ55nogJyvHmApdStBcw2FKi+Hcoch0haBythHru dOgoSW302S2MDxCt3KdU4QlCTu92TqZGKnUxHA+23t5BkKQiqfGUB2bMY35PuBnMS/fctY uGp5qL84kWbNQvl5fTGXmuyNP4Dg89g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751343387; a=rsa-sha256; cv=none; b=V4ryPNIZ/OpnA6DO4FObCkv2xqq8hUPMvPMWYaNuwyReI4VaEzNm4YmlAyXfhXPN3yKALg h2PZ81KRsKO45d47ba5G88PZtNlYX85dwLrlqCVOcau+8T0zhMqYyflWFaxGtCGIpUGOIc A+HgG5ntcPyor8TfgsRfZDq/SGlD+uE= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7598715A1; Mon, 30 Jun 2025 21:16:10 -0700 (PDT) Received: from [10.164.146.16] (J09HK2D2RT.blr.arm.com [10.164.146.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A63E83F58B; Mon, 30 Jun 2025 21:16:23 -0700 (PDT) Message-ID: <26d65dc4-7594-4a5e-8c3d-9e19540ae25e@arm.com> Date: Tue, 1 Jul 2025 09:46:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/debug_vm_pgtable: Use a swp_entry_t input value for swap tests To: Gerald Schaefer , Andrew Morton Cc: Matthew Wilcox , David Hildenbrand , LKML , linux-mm , linux-s390 References: <20250630164726.930405-1-gerald.schaefer@linux.ibm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250630164726.930405-1-gerald.schaefer@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ban9s3z954d7z63ozdqoxnhrwrjbbpay X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4662840004 X-Rspam-User: X-HE-Tag: 1751343387-691234 X-HE-Meta: U2FsdGVkX19tnvT4CKfMvR8ahtTtgS/HQNrZDJIRCUlNrSPWA6VGczbXxtMBkqch8pFizWOjt2J6zxzZjdhA+jnlhYfdNnPEKgeMsRCn8zW2brxu8lU/WSv1XBOOjVX2QRB7TvwMKENcDoivjFoRv0+Oxl2wGxKHHms8MtvdTGY1FhhOUVHUP5GLOyQv5+hxqE8YjJqzKFQOdyqizLFi9ydHZBr3yulLuqERNhBt4wocvDpkZHS+haIXCoVVm6kIfiDHhJuouE6MMbRmFoLAkTZhhLv5G8IQggFEKdDYj53pW+zgQOKWs2u2Fe0JJ0dz/jPCBt4h5vfLkvPHbo1b6grphIb3T6Is31RItAhyUnEfcJjIW8yGNwZA6VxyjTktOHoCRwEJu7YIadGEc/pGOI/sCNphGi83wVAk10n26RAU3+lpkd+jhD8sBuZbQtTXQOMNNBv/Uhi7uGRQJATEdkRFBv6Fv7PnoyTjjuz2N7YxvtBwmTE9jmev2h6e45tuF9vLXkPft2eJfyfAW+r07RiiA1ZdUD9a3mKF9uj+7m1ke6845RopgiLwDklWWYKVqtnyTTykV2K7RdYtB+5Th7U03KNvVIBEtITv868ig/1n6YgdtsSiF99AW6FtgIQlhy1DuSUfgdBjRkUtGG5V5aSCtqGP+MJX5P0OXHG9b8UN6CmigH9LJM0oV2onF2ZSN+Bl3Bru+ihU5mFddE+v1Pn4kol9quaM+uUtA9E4uv2rqwEYDHGyr1AGDnshSy9KBfO4GKgfiotQMQNyO/G05A+eqq0JhybIRf3F2w0IWIdB/uvLN/VFD1PTablnNQzoTs4YgSnlMP+kt61EabiCATi5HmLKvrzlwwSCt26EtWRK8qGVlNPJdyDk2wGrQAUcQ46+59PmAxcvU7ifkVbI8inZqELGTmjewTDMXPPzVoI6QlE/23wSc6GXdw4IujyBK9F3vD+BSeFNJc8i7SU +80Hr9v2 p1veqBFhR8f+uABn0qEf0RZ4r3BOY78cVktbtBG6JsmZ5sJPyT6WBXcSZwe7EAGODOtEKcRb9zlLYcH9FlHQfaH72HCV9cHl1Y2oKPzIDADUQ/BASLSNeyx/INfbNxgTzXf1MBEJ1WZq1uSB/Z1J78eUBLB3Wv/RCOT5zfyUy+QAIteIzwE9sLHQr03yczJXNmhqVfmh/2i1mR9i+vZ4h8yiH3G6t8Weot2QxTL6f0nYm/IoNKfycOStXRhzRIUcPBxUxFVykF7/M8VZtt51iwnGcI0BkkHmDSLVS6ipsMN7f89o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/06/25 10:17 PM, Gerald Schaefer wrote: > The various __pte/pmd_to_swp_entry and __swp_entry_to_pte/pmd helper > functions are expected to operate on swap PTE/PMD entries, not on > present and mapped entries. > > Reflect this in the swap tests by using a swp_entry_t as input value, > and convert it to a swap PTE/PMD for testing, similar to how it is already > done in pte_swap_exclusive_tests(). Move the swap entry creation from > there to init_args() and store it in args, so it can also be used in other > functions. > > The pte/pmd_swap_tests() are also changed to compare entries instead of > pfn values, again similar to pte_swap_exclusive_tests(). pte/pmd_pfn() > helpers are also not expected to operate on swap PTE/PMD entries at all. > > Also update documentation, to reflect that the helpers operate on swap > PTE/PMD entries and not present and mapped entries, and use correct names, > i.e. __swp_to_pte/pmd_entry -> __swp_entry_to_pte/pmd. > > For consistency, also change pte/pmd_swap_soft_dirty_tests() to use > args->swp_entry instead of a present and mapped PTE/PMD. > > Link: https://lore.kernel.org/all/20250623184321.927418-1-gerald.schaefer@linux.ibm.com > Signed-off-by: Gerald Schaefer LGTM Reviewed-by: Anshuman Khandual