From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2ACC27C4F for ; Sat, 15 Jun 2024 11:53:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 415846B011E; Sat, 15 Jun 2024 07:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4866B0147; Sat, 15 Jun 2024 07:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A3A26B013A; Sat, 15 Jun 2024 07:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 438048D0005 for ; Sat, 15 Jun 2024 07:44:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B5B1540BEC for ; Sat, 15 Jun 2024 11:44:56 +0000 (UTC) X-FDA: 82232941392.06.4D5866E Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.8]) by imf13.hostedemail.com (Postfix) with ESMTP id A244520008 for ; Sat, 15 Jun 2024 11:44:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=VcdB1RB+; dmarc=pass (policy=none) header.from=126.com; spf=pass (imf13.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.8 as permitted sender) smtp.mailfrom=yangge1116@126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718451890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=380/jyhTr/zvSS92chsebtdpaNxw5xeITqxnfl6SZXw=; b=vN7gMWlvmhKPRekToDgprQphLC+uoTyUHn2GFb9WXMz1fdvwEQ2PUoWh9uMt1QPBvb6IHz VajZdX4kM4i9JnpDdnHdThVDR6IABOkZq+/7AVuuAx3a/tWl4635tfqx8TlIU/UO1dKxX9 Y51cdNsg+pgKkcRm1aJ22KiQ63eqKYA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718451890; a=rsa-sha256; cv=none; b=l79EpgvwvvEzihwbXQ0ACPBXcP2kdl+PMVS4QHDVCKVVpwSKyxDWLu6gGpXvc2wLoLuLQp ffLeioSiBZqHqz1peR2r7xGNLkPwTmNVmfL+lOgv1MZuMi9gLqZzf3i9ehA/m4cRiwQ/RX RmUsAes1hx58Jz2y5Ew8LQJ+yHgxlK8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=VcdB1RB+; dmarc=pass (policy=none) header.from=126.com; spf=pass (imf13.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.8 as permitted sender) smtp.mailfrom=yangge1116@126.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version: Content-Type; bh=380/jyhTr/zvSS92chsebtdpaNxw5xeITqxnfl6SZXw=; b=VcdB1RB+xRofJg3xdBwHi2LkOVU9zi+5WYuXKV05YIAiWYrjjcT8Mc7qSyIm0j DtXtK1Fi9Olqsghjeclg/xc6Dvn4VRH4qpn4HpfvNIzX5oC+guL0zXkvuKVhzPcZ d4v8slPwqOV7xDOzdRWiMxt/4Vf0aPU/kf4S4hcX5XId0= Received: from [172.21.21.216] (unknown [118.242.3.34]) by gzga-smtp-mta-g0-3 (Coremail) with SMTP id _____wD3_8ubfm1msv1qBw--.38847S2; Sat, 15 Jun 2024 19:44:29 +0800 (CST) Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: David Hildenbrand , Matthew Wilcox Cc: Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> <617f9e36-9334-4630-a6b9-473f2dd570d4@redhat.com> <8351052a-5c21-c383-544b-3166e883587c@126.com> From: yangge1116 Message-ID: <26c86ffe-581b-1012-9974-b3d73e56a03d@126.com> Date: Sat, 15 Jun 2024 19:44:27 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3_8ubfm1msv1qBw--.38847S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cw17tFW8KF4xXFy3uryDKFg_yoW8Xw17pF 1fGF98JFsFkryYyFnrtrn7Arsay3yrJFy5XFy3JFy2kFyqqFy3KrW8ta15ua43Xr4Sgr10 ka10q3Z3WF1jvaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07b8PEfUUUUU= X-Originating-IP: [118.242.3.34] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbiOh3+G2VEwzIv6AAAsV X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A244520008 X-Stat-Signature: m9ugfeu5gfqwsowxe7b8fn86kqmy3itz X-Rspam-User: X-HE-Tag: 1718451893-646208 X-HE-Meta: U2FsdGVkX19mgwpfAvhMF62CVnq514jPiolgx+QkonVHaWqb6+ibUxWrPQo3Kuuso6zvwu0+Z2012nZ1H0IUg4SwbKuY25lWRDhv9zvOZDPwq4Ws085sOcEIeBi/U+MgBMlQ4SeEWI4CBwUFSMGv6rspnoJiSCgUKvdAQH6vQi3sFqcJDsKVk1yIRtV2Fj/aEoY6T4kITSpE8Vh7JS7g+3sgepYgttEWgLOozBxumKcpBTT8h1fp3wGt/MJ1jlaumgM8cSCO6uqfOEm9eG9Yz5CSnuuPqI6Jo2weKwSNTTJgkwRrdMLQOnztJoJRh9zPzi0yli0kbJgAn2WPhGCDvCwgbwja3dC6WNE0+9WwPlNbFCWZNb42fD+tDyohzstqFh5Hy+1LaJVNiNb2bJxxDZC3+EQjdMY48UwrQSf8JIU8VnfR+nR34iPr3S+QU+9+7BaPRPARNSVrsq2gO8fdvQ84J7F4s80uUu42tkteBR9tgzNRd2m4WRnFYNl+jB/dCWva7/QOpHSr+xA76UKlpg2LRzBPXpmQ1SB6jrf98sXSPOv0PRJl61Ncia+1ecyAmIWwbL81pGD7DWG3n3Pn6XSvK05A4g1PFCiKHinOKcBQVsMfKpVhEXneS/5/JqEin5xTZb5zboE1C11kRCuTCL92OLHbZQky2iJvlfvfnSo7TC1OrVFjPu4g+SDAr7Wet1gDhWjQqy00U1iiEGyGVL3ecKcyxg7mZ4PDG+9kNH7anycI+27uA74t2hbJNICF185Ih37jRdwwDy5QUVnCvASVZF7oZBp2X/7/f6ldp+KvAZq602OxWNYsuRp4+RybSXjvNdYgwMUz92ovFprZFz+xlHehItDIvb6hhCgNKzVyW4QUSo1fKXARW23JUxXTp+z9ckX+G0TSyuzUbgEYBZAgf3P481Kj0VBt32096tKRrX1Ox7GKImwXFacsF4HrsHZN7SbhlBoHRKyop55 DS9/iPmy UGg03qML25wi4wKiYFiuoXOLwR3EX7KP5wO6x5dIhWLNPm88nHSA55TlxKYIHUbhh9HJ6FYaWgLPNRnloHd/8GjfQS8h1tEE2UIxtalnIrRKitDvTeyT9XsxhLXncbmZQ1Nl+k2fNQobpNaSZMp35LPXOqj6fXVBZsrNpEi+BiIq31QuZvC6auhdqxyz9T8PPbvr3R1bLT+wp0NjTi16OXG3D7DzdROf7d4P74v797AtFADVKYnDCosZqZAeyVypnBrnUU7nAevv4mMN8rqFMJxLRxx6pVa2z/Vugnm2ip+1YTKXEWOefdDFtluYEIgfn9n5wzpkHMJwCzmlMNX2B+INMwUwv+EipR3j1m6o5DckI546zCMwMhR7KRLR1qDAf2xP0bftiYdjEBM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/6/12 下午3:32, David Hildenbrand 写道: > On 11.06.24 13:20, yangge1116 wrote: >> >> >> 在 2024/6/9 上午12:03, David Hildenbrand 写道: >>> On 08.06.24 17:15, Matthew Wilcox wrote: >>>> On Sat, Jun 08, 2024 at 12:38:49PM +0800, yangge1116 wrote: >>>>> Can we add a PG_lru_batch flag to determine whether a page is in lru >>>>> batch? >>>>> If we can, seems this problem will be easier. >>>> >>>> Page flags are in short supply.  You'd need a really good >>>> justification. >>>> >>> >>> A flag would not be able to handle the "part of multiple LRU batches" >>> that should currently possible (when to clear the flag?). Well, if we >>> have to keep supporting that. If we only to be part in a single LRU >>> batch, a new flag could work and we could still allow isolating a folio >>> from LRU while in some LRU batch. >> >> Yes, before adding a folio to LRU batch, check whether the folio has >> been added. Add the folio to LRU batch only if the folio has not been >> added. >> >>> >>> If we could handle it using the existing flags, that would of course be >>> better (wondering if we could store more information in the existing >>> flags by using a different encoding for the different states). >> >> If a folio contains more than one page, the folio will not be added to >> LRU batch. Can we use folio_test_large(folio) to filter? >> >> if (!folio_test_large(folio) && drain_allow) { >>     lru_add_drain_all(); >>     drain_allow = false; >> } > > I think we should do better than this, and not do arbitrary > lru_add_drain_all() calls. > Thanks, I will prepare the V2.