From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D9FD6ED38 for ; Thu, 21 Nov 2024 13:44:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77DA36B007B; Thu, 21 Nov 2024 08:44:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72CC36B0088; Thu, 21 Nov 2024 08:44:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CD436B0089; Thu, 21 Nov 2024 08:44:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39AC26B007B for ; Thu, 21 Nov 2024 08:44:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2CD4A0DC6 for ; Thu, 21 Nov 2024 13:44:46 +0000 (UTC) X-FDA: 82810220892.21.263CA73 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id BD83714001C for ; Thu, 21 Nov 2024 13:44:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IUScXwMP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732196498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QiKq40kADGw/i2kCfp5/KzfMuaQ4J7QQN9sLUOYlBLk=; b=vcj2gEEP4RPMz6t92o2PYs5GZI/Div03JFXEvHKSuPDWvUlXtKWDNOUDPS3VcMYt9sFJMh UO7IHQXVfyjQzZ1vDOq+j+RHMWVkndaXIeY/GjeIp6rkoXb8juy283bo1kPX8mbLICZm0Z B7xl3ERam9bXzuyjrWL3pBruCibb4jM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IUScXwMP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732196498; a=rsa-sha256; cv=none; b=xBRcZtA73ygiA8/+PPe3cb8H3zr5GHfR4mWamthEHcQ8Zm/pzSwW6pzatvzJkGKkokVtBU RPunUHGh41NJXbTa11Gm3lQXEebCWEqNAsYnw1bUct9/0zqo2EIp9v9SicjvcKdDDAXJ0N 2dZb92ZOCzsfGWOdN+8sR6eT6o9gkUw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732196683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QiKq40kADGw/i2kCfp5/KzfMuaQ4J7QQN9sLUOYlBLk=; b=IUScXwMPrAjKY7FsT66pWnRtgIW2psbEIhWZmve0P+3GeQVkbpIONYm9OGOKW6FKkCJ50m anzTQ2tdncEzD2kTHKNB5FfKH39grTW9P/QyFBP0Yv4I5UugVyRnRDasPcPbfTuoIeCWLh G29Mwl6umWWAVjMTTAe84UqouUO5Td0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-BrSvbQbFN3mYd2tiy-bCtQ-1; Thu, 21 Nov 2024 08:44:42 -0500 X-MC-Unique: BrSvbQbFN3mYd2tiy-bCtQ-1 X-Mimecast-MFC-AGG-ID: BrSvbQbFN3mYd2tiy-bCtQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-382428c2564so540801f8f.2 for ; Thu, 21 Nov 2024 05:44:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732196681; x=1732801481; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QiKq40kADGw/i2kCfp5/KzfMuaQ4J7QQN9sLUOYlBLk=; b=LmuPtf12IxsN7Hv27OxKn52UTzHHdUDMT5YF3PXmHcdhcCPLoDVpkcwz5jB2RUdrcp ZIOkD8p3AQPPjJ+T9hxx8GD+pcMd7roFx0uhNytA/eKe5QRbr42QFO7MYWWA96NbNW/S knO3HX0zrPWCeCvxS6bkU4mfYpRh5bP53pcUt/5pt1Zfcnbl4E8Tz/Bd+zTEGdph/MUi iJFSBoCtgUbY/yiMJlD3nzcmIieOpxKrXcN/AxPMpbu9k/JbEHoKR0TmD30gcfHGUsHG FyZYnRGVAwXdnFFMiqE6AzUGKoXtv2t2aUMMgU/Fa54d6pg5xuEMiiY/BpVGZxkYwuEN X/6g== X-Forwarded-Encrypted: i=1; AJvYcCWm8I7irf/iSKE5v950xWGlQxNbR1KKSE2Pd+rLx/Gokln7HXGK1+N0jTpfSacSMBJcIr/I/avYrQ==@kvack.org X-Gm-Message-State: AOJu0YyJVEkyitJfFKVYIbgVjv8tyRKtP75EbsZhHkmvYqkFnNkt8mjH rYo9OALkrKcjI9T38tl4EI8+iNS0HKvDB6PEQBC/Yb8S5mhS6oAnGLcUZ3s3ulpZrCBEnh+wW9b GCisvrDLpiRQ5fuhGFo2tFT1pqaJvTTMEZnDKIq5LUiaISRgN X-Gm-Gg: ASbGncs2eOGqfItCr/vRERs0sm1AE+u3X31/sUINNBaeaMn+TlVhaDTqUqSaz8oKPfw A6R5rWis+J3v2NqtMUhJh7eDzlF40ipeUjE344T290wAovkhp52ezg27IPGl+vJeOAoI88k6Veq sfVdA2n6EwvK9KHGua0WYVyv6ICUmQQHZkF4CT/X+hp3qwdiTMMaypc8bNOcKApzUPeMurt8q2h DO32VgatmQkp0Ye8ds5U5UAG3N3RW53BypKeNTPTTVeiXSG5AW8kLPfgbU8V2Y8Rx8Rf6JKw84F ixMxHklzrczJnvwjInpu6Mqg30Zef7U8UJfQTH+m7laPbGc6MS+1dZpdri0uNh8DgW2Fl5KTP+Y = X-Received: by 2002:a5d:648a:0:b0:382:4eef:26e with SMTP id ffacd0b85a97d-38254b1c86amr5009772f8f.51.1732196681228; Thu, 21 Nov 2024 05:44:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVnrdC30GKAhFUaf2lQE/XQCHVL4NBJxOu3+ucxhq2+Dmct/wiZ2WWhO6tSTTyyviZC/sK8w== X-Received: by 2002:a5d:648a:0:b0:382:4eef:26e with SMTP id ffacd0b85a97d-38254b1c86amr5009762f8f.51.1732196680885; Thu, 21 Nov 2024 05:44:40 -0800 (PST) Received: from ?IPV6:2003:cb:c70c:de00:1200:8636:b63b:f43? (p200300cbc70cde0012008636b63b0f43.dip0.t-ipconnect.de. [2003:cb:c70c:de00:1200:8636:b63b:f43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38254933d39sm5184954f8f.83.2024.11.21.05.44.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 05:44:39 -0800 (PST) Message-ID: <26b82074-891f-4e26-b0a7-328ee2fa08d3@redhat.com> Date: Thu, 21 Nov 2024 14:44:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: Fix to make vma_adjust_trans_huge() use find_vma() correctly To: Jeongjun Park , akpm@linux-foundation.org Cc: dave@stgolabs.net, willy@infradead.org, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241121124113.66166-1-aha310510@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241121124113.66166-1-aha310510@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: L0JHpIbfR5y-cTMOECAqhHCPGadaddWtrISU-6TcvhI_1732196681 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BD83714001C X-Stat-Signature: eie7c4rnw1mid9gjxjei8abfwz66y3n8 X-Rspam-User: X-HE-Tag: 1732196647-220562 X-HE-Meta: U2FsdGVkX18+RwAXcC2PeoQX1hMRKzP8kmk7rOo+Vkl5P3wg6F6S6bvFtufdINKMpb6Yug8F+O5CdG3ezDAQHjSxN2SAFlqdGUMiRRdZJx3DBPQ3GDiG1JSO/6p/ijSCphdseZw0/TquXWF/aeamH1/wsumyCbcnXpNz1Pefuh6691JmWSD/QYBebUxFxpjFt1YPhF4JX0NLtPemZpIzdKXVeMfeD0nQsUACTbuiQwKFGfyN79FlwH+V7EqgIvlLaiOuKDTuqFIISHHrqifAD1EM86ac9fFuTXzrR9QwJ89vnIFjd7Oqck3X24P43HYTtSntR/H5AXjCBvRufi41ijRzpUsezrWABpkmisMhENkEEt3FKgy9wN/cm+5Klky+1IVfYCYH1n/CZLPRuvf9+s+kKbqT09o4g50OazzdCkJh7zrsvNWQSsbtyNuXooteqKMS6DpGw7PA8ReefxhGIaf6Tu72XTmNZ5LfGH1xpqu31uGeRCFCWSUkhp96EYgByWXJR7OyLgN77eXZWqo41R3m9SGRmNBOAQx0gKXWA0duIWwxforXvJwvuWPd0/KD6KhfUE4zUILCUaakaLrD1M82pGuPs1lgUIP5PNWxd6nfxGSdTaYV5z28fiZHFmO6VTGtsQfRucF8le/DgRCXdtjTFeHE/rtMdGXkw5Dqi6hqEwD8UgngQGMKG/nJTt/mDzevMS2PDyoLHckw/AZTjVMGjJg4mZPg44dBCZJK9gZCRc9SZs7FwLxtrwuLeRBe8UpD9aI+8JohXcHTj2WReY4lJx0OsP87nb8nIZVm5YF0uqUMOvAAzSrUEJeO2+IQKGbl7I/ksofUcFrIXyoFIBmUtFoKKT0geK4xy3sMhta/YPtHFSc38tThA1j6tlhy54rKXooC1B2NBlYWRg4FzsF0lRz9kGrmbmk6ZJSE2bCIqqT8yrBeCV+IYaG6h/hkkFf1Oy9YHFfu1CKcUXO TuhNE3yD l13qvmSGingHostEBhkRzhqTs5WuQwHHFHcKZGDt2sCmFHVRiPdSxVzFG9LkK8dw3bY3pmbXNr4cpF5vB6ZNC1IsrzCdALmgqKnAGLzi6ZbQHcP75bSJpcskfk54mW1k/cRRxPv95KRC3BOX36AMvn2mKwiEypchY6dzOe2MeKioxnoCCZPJC9/l99VWN6thRwOwBnoYTLITJZReU1em8kiUAkF4qTpK9lbhyCZHnx21oZkaEIOFcPwn0PEkAhrRvY3OYJ47DtpgWruT6WSf9kJA2+/b67FZwCkhtR8efHI6u1UgTXAu3jDcARkc++wOhWNFsrjn8jtUnkXEqiZTz/XcKAjLFPUEXd9nI0ud+hMlS/Ixp2G5zgdu3/U9DQAm4zMXYqK+TPdG9IXM2YE8+FaV7dXUGxg+nhcys3N8gjCKo/cNYFVJnsSUE/MYgxzioK2L4dcyuK3m4l3fuhIrkTBjWkWGBrV91LrAeie+t0M5Q7ig= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000118, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.11.24 13:41, Jeongjun Park wrote: > vma_adjust_trans_huge() uses find_vma() to get the VMA, but find_vma() uses > the returned pointer without any verification, even though it may return NULL. > In this case, NULL pointer dereference may occur, so to prevent this, > vma_adjust_trans_huge() should be fix to verify the return value of find_vma(). > > Cc: > Fixes: 685405020b9f ("mm/khugepaged: stop using vma linked list") If that's an issue, wouldn't it have predated that commit? struct vm_area_struct *next = vma->vm_next; unsigned long nstart = next->vm_start; Would have also assumed that there is a next VMA that can be dereferenced, no? -- Cheers, David / dhildenb