From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68427C00144 for ; Wed, 27 Jul 2022 01:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E09DD8E0001; Tue, 26 Jul 2022 21:03:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D91766B0072; Tue, 26 Jul 2022 21:03:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C65098E0001; Tue, 26 Jul 2022 21:03:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B01866B0071 for ; Tue, 26 Jul 2022 21:03:48 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 845A71C640F for ; Wed, 27 Jul 2022 01:03:48 +0000 (UTC) X-FDA: 79731082536.24.5DDC702 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id C4C51C0007 for ; Wed, 27 Jul 2022 01:03:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=GwxOLjxLRrQqASCK4Od2SYV8dQa0nMmOi0A7PX9TkRU=; b=wPAKpK71JFaXfa75QNiT09CanL 72fq6O+TF0NKwCvGuugBLdZVke0BZh6YU8Ojib+ejRozHujPvA0e9vfE1e6FIzgfWrK9Y6WyaNbpU eRR+lcXLdx1gtxLgySTAdVxmfrQNNVx8nsQQdYBbYhC49wivy4+UFSNcqyEilbN6ChYy6fMutSnJj CghSmIqxCE3hEWGNHIqBRRd3tnjFLzNb/2UXAuXPyZbxuoVeiOsXR5EJ8nUj4e32LOdb8r+EjYTP6 L2ObdavR6EVoUVSuCgXWWNxENNYN9AviLg7O0qw743zKn4X+8CVw5wxm/y/dCMDP8HUPE+PE1J+FM TxtKoHxw==; Received: from [2601:1c0:6280:3f0::a6b3] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGVSZ-006z3V-T8; Wed, 27 Jul 2022 01:03:35 +0000 Message-ID: <26b099a0-2ace-8023-7b09-f6b015f26be9@infradead.org> Date: Tue, 26 Jul 2022 18:03:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] memblock tests: compiling error Content-Language: en-US To: Souptick Joarder , Liu Xinpeng Cc: Mike Rapoport , Linux-MM , David Hildenbrand , linux-kernel@vger.kernel.org References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wPAKpK71; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658883828; a=rsa-sha256; cv=none; b=zy+abuQhL3l3TnCA5Pz6lKi4LLBFxGQHcaEUGwaC5CiHfC3UQlBT+2rkqqaCMQTbr2mpX9 T8c3wjxs9g2KSwZjyxnYzIJ5rdkvXco17LudSJeV7MYihWdeCKPgH2mqbSQCmG/8Xc9tgF lezV4p/7ZytjmEbN2N+CdXHP3SbWQxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658883828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwxOLjxLRrQqASCK4Od2SYV8dQa0nMmOi0A7PX9TkRU=; b=cVoswiqnV76cu9D56Ypl/hUocgyK3AhCDT4RjV/3z4MfbDpliLa0Ke+GJgX3ChZTIlYL9P mKP29a2OB/6QxhHG7bVfcQ+X+b43wDyxJ0hrjDfjcXwg8FSnKJXZIIgz15m59+Bw0ZV+M3 AjR7KorfLgy/M40u0sqQ3EKX0pIg0uo= X-Stat-Signature: ykwtiokpgh17z1wpz1fsbr814efggaa3 X-Rspamd-Queue-Id: C4C51C0007 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=wPAKpK71; spf=none (imf22.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspamd-Server: rspam12 X-HE-Tag: 1658883825-248380 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/26/22 18:01, Souptick Joarder wrote: > On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng wrote: >> >> memblock.o: In function `memblock_find_in_range.constprop.9': >> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >> memblock.o: In function `memblock_mark_mirror': >> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >> > > what is the steps to hit this compile error ? or what kernel .config file? > >> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >> specified") >> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") >> >> Signed-off-by: Liu Xinpeng >> --- >> tools/testing/memblock/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h >> index c2a492c..cf67e6e 100644 >> --- a/tools/testing/memblock/internal.h >> +++ b/tools/testing/memblock/internal.h >> @@ -9,6 +9,9 @@ >> static int memblock_debug = 1; >> #endif >> >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); >> + >> +bool mirrored_kernelcore = false; >> struct page {}; >> >> void memblock_free_pages(struct page *page, unsigned long pfn, >> -- >> 1.8.3.1 >> >> -- ~Randy