* [PATCH] mm: fix config option typo in header file
@ 2025-12-01 12:29 Lukas Bulwahn
2025-12-01 12:48 ` David Hildenbrand (Red Hat)
2025-12-01 12:52 ` Lorenzo Stoakes
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2025-12-01 12:29 UTC (permalink / raw)
To: Andrew Morton, David Hildenbrand, Lorenzo Stoakes,
Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Alice Ryhl, Pedro Falcato,
linux-mm
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly
refactors the header file include/linux/mm.h. In that step, it introduces
a typo in an ifdef, referring to a non-existing config option
STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.
Fix this typo in the mm header file.
Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
---
include/linux/mm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 96acf31268ac..394126bf637a 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -443,7 +443,7 @@ enum {
#define VM_NOHUGEPAGE INIT_VM_FLAG(NOHUGEPAGE)
#define VM_MERGEABLE INIT_VM_FLAG(MERGEABLE)
#define VM_STACK INIT_VM_FLAG(STACK)
-#ifdef CONFIG_STACK_GROWS_UP
+#ifdef CONFIG_STACK_GROWSUP
#define VM_STACK_EARLY INIT_VM_FLAG(STACK_EARLY)
#else
#define VM_STACK_EARLY VM_NONE
--
2.51.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fix config option typo in header file
2025-12-01 12:29 [PATCH] mm: fix config option typo in header file Lukas Bulwahn
@ 2025-12-01 12:48 ` David Hildenbrand (Red Hat)
2025-12-01 12:52 ` Lorenzo Stoakes
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand (Red Hat) @ 2025-12-01 12:48 UTC (permalink / raw)
To: Lukas Bulwahn, Andrew Morton, Lorenzo Stoakes, Liam R . Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Alice Ryhl, Pedro Falcato, linux-mm
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
On 12/1/25 13:29, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
Subject: "mm: fix CONFIG_STACK_GROWSUP typo in mm.h"
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly
> refactors the header file include/linux/mm.h. In that step, it introduces
> a typo in an ifdef, referring to a non-existing config option
> STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.
>
> Fix this typo in the mm header file.
>
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Right, the commit is already in mm-stable
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
> ---
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 96acf31268ac..394126bf637a 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -443,7 +443,7 @@ enum {
> #define VM_NOHUGEPAGE INIT_VM_FLAG(NOHUGEPAGE)
> #define VM_MERGEABLE INIT_VM_FLAG(MERGEABLE)
> #define VM_STACK INIT_VM_FLAG(STACK)
> -#ifdef CONFIG_STACK_GROWS_UP
> +#ifdef CONFIG_STACK_GROWSUP
> #define VM_STACK_EARLY INIT_VM_FLAG(STACK_EARLY)
> #else
> #define VM_STACK_EARLY VM_NONE
--
Cheers
David
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fix config option typo in header file
2025-12-01 12:29 [PATCH] mm: fix config option typo in header file Lukas Bulwahn
2025-12-01 12:48 ` David Hildenbrand (Red Hat)
@ 2025-12-01 12:52 ` Lorenzo Stoakes
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Stoakes @ 2025-12-01 12:52 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Andrew Morton, David Hildenbrand, Liam R . Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Alice Ryhl, Pedro Falcato, linux-mm, kernel-janitors,
linux-kernel, Lukas Bulwahn
On Mon, Dec 01, 2025 at 01:29:22PM +0100, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly
> refactors the header file include/linux/mm.h. In that step, it introduces
> a typo in an ifdef, referring to a non-existing config option
> STACK_GROWS_UP, whereas the actual config option is called STACK_GROWSUP.
>
> Fix this typo in the mm header file.
>
> Fixes: 2b6a3f061f11 ("mm: declare VMA flags by bit")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Yikes, my mistake! Sorry to parisc people :)
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 96acf31268ac..394126bf637a 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -443,7 +443,7 @@ enum {
> #define VM_NOHUGEPAGE INIT_VM_FLAG(NOHUGEPAGE)
> #define VM_MERGEABLE INIT_VM_FLAG(MERGEABLE)
> #define VM_STACK INIT_VM_FLAG(STACK)
> -#ifdef CONFIG_STACK_GROWS_UP
> +#ifdef CONFIG_STACK_GROWSUP
> #define VM_STACK_EARLY INIT_VM_FLAG(STACK_EARLY)
> #else
> #define VM_STACK_EARLY VM_NONE
> --
> 2.51.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-01 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01 12:29 [PATCH] mm: fix config option typo in header file Lukas Bulwahn
2025-12-01 12:48 ` David Hildenbrand (Red Hat)
2025-12-01 12:52 ` Lorenzo Stoakes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox