linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Hugh Dickins <hughd@google.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Nico Pache <npache@redhat.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
	Matthew Wilcox <willy@infradead.org>,
	Bas van Dijk <bas@dfinity.org>,
	Eero Kelly <eero.kelly@dfinity.org>,
	Andrew Battat <andrew.battat@dfinity.org>,
	Adam Bratschi-Kaye <adam.bratschikaye@dfinity.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3] selftests/mm: add folio_split() and filemap_get_entry() race test
Date: Fri, 20 Mar 2026 14:10:46 -0400	[thread overview]
Message-ID: <26961CE8-79A4-4163-9D27-996E01BE00E2@nvidia.com> (raw)
In-Reply-To: <def912db-ea7e-4cac-afa2-8e0b9c279549@lucifer.local>

On 20 Mar 2026, at 14:04, Lorenzo Stoakes (Oracle) wrote:

> On Fri, Mar 20, 2026 at 01:58:18PM -0400, Zi Yan wrote:
>> On 20 Mar 2026, at 13:53, Lorenzo Stoakes (Oracle) wrote:
>>
>>> (-cc old email)
>>>
>>> On Thu, Mar 19, 2026 at 03:04:08PM -0400, Zi Yan wrote:
>>>> The added folio_split_race_test is a modified C port of the race condition
>>>> test from [1]. The test creates shmem huge pages, where the main thread
>>>> punches holes in the shmem to cause folio_split() in the kernel and
>>>> a set of 16 threads reads the shmem to cause filemap_get_entry() in the
>>>> kernel. filemap_get_entry() reads the folio and xarray split by
>>>> folio_split() locklessly. The original test[2] is written in rust and uses
>>>> memfd (shmem backed). This C port uses shmem directly and use a single
>>>> process.
>>>>
>>>> Note: the initial rust to C conversion is done by Cursor.
>>>>
>>>> Link: https://lore.kernel.org/all/CAKNNEtw5_kZomhkugedKMPOG-sxs5Q5OLumWJdiWXv+C9Yct0w@mail.gmail.com/ [1]
>>>> Link: https://github.com/dfinity/thp-madv-remove-test [2]
>>>> Signed-off-by: Bas van Dijk <bas@dfinity.org>
>>>> Signed-off-by: Adam Bratschi-Kaye <adam.bratschikaye@dfinity.org>
>>>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>>>
>>> No .gitignore entry? :)
>>>
>>> (Just saw it flag up locally in git status)
>>>
>>> Linus says don't remove, but he doesn't say don't add :P
>>
>> I did not know about that. The fixup is below. Thank you for pointing it out.
>
> To be clear I'm referencing this re: the .gitignore _removals_ ;)
>
> https://lore.kernel.org/linux-mm/CAHk-=wiHK5_oBUdUiNAaevmN9f-ORe+QBqbRefAZaw-RbgEn3w@mail.gmail.com/
>
> Thanks! :)

I did not know .gitignore file exists in that directory. Also good to know
about the do-not-remove rule.

>
>>
>> From bd164a7090c0e8b6e3013502c64c161214e38714 Mon Sep 17 00:00:00 2001
>> From: Zi Yan <ziy@nvidia.com>
>> Date: Fri, 20 Mar 2026 13:56:04 -0400
>> Subject: [PATCH] git: add generated binary into gitignore
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> ---
>>  tools/testing/selftests/mm/.gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
>> index 83ad9454dd9d1..b0c30c5ee9e30 100644
>> --- a/tools/testing/selftests/mm/.gitignore
>> +++ b/tools/testing/selftests/mm/.gitignore
>> @@ -61,3 +61,4 @@ guard-regions
>>  merge
>>  prctl_thp_disable
>>  rmap
>> +folio_split_race_test
>> --
>> 2.51.0
>>
>>
>>
>> Best Regards,
>> Yan, Zi
>
> Cheers, Lorenzo


Best Regards,
Yan, Zi


      reply	other threads:[~2026-03-20 18:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 19:04 Zi Yan
2026-03-20  2:41 ` Andrew Morton
2026-03-20 14:10   ` Zi Yan
2026-03-20 17:53 ` Lorenzo Stoakes (Oracle)
2026-03-20 17:58   ` Zi Yan
2026-03-20 18:04     ` Lorenzo Stoakes (Oracle)
2026-03-20 18:10       ` Zi Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26961CE8-79A4-4163-9D27-996E01BE00E2@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=adam.bratschikaye@dfinity.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.battat@dfinity.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bas@dfinity.org \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=eero.kelly@dfinity.org \
    --cc=hughd@google.com \
    --cc=lance.yang@linux.dev \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=npache@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox