From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AFFEB64D9 for ; Fri, 7 Jul 2023 10:27:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25BF68D0002; Fri, 7 Jul 2023 06:27:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20B798D0001; Fri, 7 Jul 2023 06:27:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FACC8D0002; Fri, 7 Jul 2023 06:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F22E38D0001 for ; Fri, 7 Jul 2023 06:27:51 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 93D66405AB for ; Fri, 7 Jul 2023 10:27:51 +0000 (UTC) X-FDA: 80984439942.26.8F3E614 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id C7DFD20005 for ; Fri, 7 Jul 2023 10:27:48 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688725669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1V1N8Iz2M7/YKdRgx32jFVGQV8sReZwlUv7PqnSI12A=; b=ZNEZv0HeaBNGSNJzkJM9d4nX4dupZtW0sj3S642tJWPfNkwYgnGVW6J7DtSp9rNqb4lzID PCctKHi9+ghLKayF7V+c6BZrDnOwL3IxPxDNIxD2NspBnI+euk+CQvnrQdyWHMxVSDZ3mZ KfLB2ZJzZHftCNuFPlGUo8ew1PmI9/U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688725669; a=rsa-sha256; cv=none; b=1xgE1eUS7TIRPYvcP/ROhYJYAp3b0l2ToLI3OMm5cnVyRy674y/XiNa3KVo50bwGpmzOVs fz4A3Jq+K+3YLBUxt2FMTjoIvF+dzD1HxFS9td5CziRRZTG3/R6ybEGbHckT/YPLWu1yXi dJ/1wmYVqQ9f3T+njsB4grjzkiMXrII= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1D89D75; Fri, 7 Jul 2023 03:28:29 -0700 (PDT) Received: from [10.163.48.50] (unknown [10.163.48.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 17F733F740; Fri, 7 Jul 2023 03:27:45 -0700 (PDT) Message-ID: <26816f0a-7f55-f5ce-b71d-769011f9230f@arm.com> Date: Fri, 7 Jul 2023 15:57:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] mm: cma: print cma name as well in cma_alloc debug To: Pintu Kumar , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org Cc: pintu.ping@gmail.com References: <1688668070-8408-1-git-send-email-quic_pintu@quicinc.com> <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <1688668414-12350-1-git-send-email-quic_pintu@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C7DFD20005 X-Rspam-User: X-Stat-Signature: s1i1hnsxu3h6zzg1ku4qza3qpkcwqpxn X-Rspamd-Server: rspam03 X-HE-Tag: 1688725668-502707 X-HE-Meta: U2FsdGVkX19gqAuspOtB/7WZAjA1SFa+eFuoQPLv1+T3ZNMCKoyG5L5GJ060j7rvW3YoAKINUcwvjSOUr0hvHGSNKDQ1OLYyEAWnTUy9H+LImQy7i6hzR50kECtLXo40/6/dvK9wkDOnuR2d0Gqx67VUQ6bYZczCY2eH7HfCCsEPwbk9bExYl1HtV3g6cBzZQCqEzn2hAyZJQaf22ky6gnNI3DNktiFqU8EQVscyxRzx072ZIjzIcCRybyrEKmqqU9C8Xkbw+SRB3CmZtwVQzXMC3JHYznEYG3E27eqYI/P9cDIbRcRWCY+TuVMhsnHcGER2jAco5d6D1qO+RX/MbZheRIw4WxW/7TN4Us5ZDtQULFZTuqjo1oTXd3Ag4SY5+29n/T005VRoDVOlmhRuWpbVNLkdVmgluhxEgVfz5tR9frX8vGbIyUItXQ8utDxr/Q2JuU4jhjKqARedCXMIc1GPCi3sx9hJ1wWXXX0KcvKjHsV7ehP//LdVXmokqXeVKsqsRRs1IklA1d9gE2TXfFginhizMe7MNEuUoR6PsJ46QXtlf5we+KhLbr8EKoDAZTEemZHPxJ0Ax82Lzt1xgF5+SRnG8bDgBrRxFC9Q5oE3CUsFCK5RwbOlxavZpNi1geCOZf1ZjwjJWzVaBcPugDLBZswcWQPCRL8GFj7TAFsEkStmvJGG9pBKGyT+L6gyLFcFW1ZTVO9bFvtsxsCYH0DnmP4pSeG009ctwLeVpQhyfUg1bmG9yotz+HM9Q+W/EhEDIq4SIEoA2a1z7L8xh6raSnWR8pW3P8SHvmNdlpoJ80KQsH3BDvp8riRnnaR4wwd31LCzKcrONQ1g+Lwz4E+NlOyIecIxtpLmjZ4jYqPzyzom0k7HRiI98in/ni1mSBOGr0z+zzx9fRu2pQ9WdmLxjctP5x32uGqj9Xtd0NqotnTPjGCDG4tyYM4M+FLpEQ0vyZrZ3tNg6lRJfWj hI+46yQa 0hoT9ObqT5nYanMSjbwI1diEKNuPcfkYwk1F7hJ7eHjd8EaZcSe8eXg6luELuBVnITOyn1vJ2pyU6gqEZZawQ6pMh6q8pSigvL7QRh/nkAkDcbqxeos79SD5o8oTOiHOK+xq/3RjKz4B9euSSWIwStQQhEgdw4+UV14cvG/fIitJdGU+h1M+IBku+Ld5mcWPAB2I4ZZSk5IkWucChmdGfbpauSmd/9Au+EQZabEqVFEZo9hYVIlIxzbAXXtGbuu4jrNWWSKTMJnBU6s5CdzZTrWB0L/n5bPP5GA0tOS2lPTU3DmB+5t6T8V/EPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/7/23 00:03, Pintu Kumar wrote: > CMA allocation can happen either from global cma or from > dedicated cma region. > > Thus it is helpful to print cma name as well during initial > debugging to confirm cma regions were getting initialized or not. > > Signed-off-by: Pintu Kumar > Signed-off-by: Pintu Agarwal > --- > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index a4cfe99..4880f72 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -436,8 +436,8 @@ struct page *cma_alloc(struct cma *cma, unsigned long count, > if (!cma || !cma->count || !cma->bitmap) > goto out; > > - pr_debug("%s(cma %p, count %lu, align %d)\n", __func__, (void *)cma, > - count, align); > + pr_debug("%s(cma %p, name: %s, count %lu, align %d)\n", __func__, > + (void *)cma, cma->name, count, align); > > if (!count) > goto out; LGTM, cma->name is an identifying attribute for the region for which the allocation request was made. But how about using cma_get_name() helper instead ? Very few call sites have been using the helper.