From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35ED3C04FFE for ; Tue, 14 May 2024 16:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADBDF8D002B; Tue, 14 May 2024 12:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8C9F8D000D; Tue, 14 May 2024 12:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953F18D002B; Tue, 14 May 2024 12:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 772868D000D for ; Tue, 14 May 2024 12:05:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1DED41202CC for ; Tue, 14 May 2024 16:05:10 +0000 (UTC) X-FDA: 82117475580.19.E85FC17 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 8E7D1C0038 for ; Tue, 14 May 2024 16:05:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J0XYtrIs; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715702706; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dmMmRWEieJM/VyycAHEtr/8G1hbbQFys09rSH0ZH8zw=; b=fSVPcHytiR9vKqEFJ1M71m2zvTP28KmVpucTiv7w+RVCDNLCYqqmKxm0dBE8Nn5TZ5q3Ph JyngXDuK2OeHv919qMprPZWts4+pXkBR7bmojcrlyAb1nhdCojjuyZ+f0Y4rYAJjtbv+/4 xnCxVy6t7WfEIGtZxZsrALMvatP2pHs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=J0XYtrIs; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715702706; a=rsa-sha256; cv=none; b=kh37LD4v9SWyyDPJVU6H9J+JTLDUpMrWWmrVScH0zLF6LA9yXMbFc9HYwHBiAYLQrYIY8E KflZ3nslGXLCINOj3PiNukJDTqUcptwvgAoKi88t/FubQarTOAGnvR9F5kh6/DEBIaDwIT tHzRJFM3yN+zxk+h0TieenOeFEDFT64= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715702705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dmMmRWEieJM/VyycAHEtr/8G1hbbQFys09rSH0ZH8zw=; b=J0XYtrIs8lmdW2CwtypSuepGRfJsyE2TKrRfds/ILlYLJC9x6HDPxSkhUguQ3erCLe1F16 IIFzbZGTvPwwIe+TlUaBOWt92lxlMLzLOw5rZCctOzHqBSrcNPWr6kak1C7Fx+y2L9cm+y HW6LeSP48VO2xRD6frhn00m9lzsskXc= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-R_HhfiOIN6edPl1Wkfk_FQ-1; Tue, 14 May 2024 12:04:54 -0400 X-MC-Unique: R_HhfiOIN6edPl1Wkfk_FQ-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1e604136b6dso42829715ad.1 for ; Tue, 14 May 2024 09:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715702693; x=1716307493; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dmMmRWEieJM/VyycAHEtr/8G1hbbQFys09rSH0ZH8zw=; b=ln9h2WLy0M81IE1OafjXSpgFI0gJHdd4XjEH7sVxku+BcGkLJc9cgG7bWB66JFcc+c azGkTxAkdnJo3cdw5DFnIJUM276mhcYUmSKmNYsIOPkeNLJolegV/gAgJFOqnE1lUPza aGbhetDcFYiV2FbWq5wYHNJHr7D6XuCVnl1FCSXtGV+OjptZftdytXrIeQtXEC8QCfKE aT1N/mBswj1MYsh8evqto082K0APcruaJSUqpbTqJYjFSFXFgbgl1WdAvNJ4WmhFdlHx C+nBhS0eqoLCDgdQcpODVI66rhhOuX9bIzYkOE3cyYIzxKOplT8UGOP1yyWHhev5ksAl jh1Q== X-Forwarded-Encrypted: i=1; AJvYcCWp/Z+W1wNapchMAGX0+cocafi4L8ktk3xaYSKc1vEKv40Oqp+8PZXHmEmQPR+2t48qSR2q6bZQkTJ/nMyuAxsZwKU= X-Gm-Message-State: AOJu0Yz9CcYMPUGfHTlWYPjC1SaPNSgVK9yUrgjo/FAVgO6EEDA5gzaZ zwy9TkQ4pCG/uxsbPWnj2Rs5V+JDKhRvuL10rFtnbHas6P0hY+Bq02BGdriLwTXxXKdFubVFwPv s0LYLxtCwC+oIAPUA36Pnl36slvL7x+SuYJ6DMddBAd4bzgD9 X-Received: by 2002:a17:902:dacf:b0:1ec:c9e0:c749 with SMTP id d9443c01a7336-1ef440505a0mr157388205ad.48.1715702692869; Tue, 14 May 2024 09:04:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyf1swdEc22d91QGE9oGlryQiUSYdvmusRTHKjFTFoYZZ/QMi0pxUaBLy+FRW8uQxZQ9IVjw== X-Received: by 2002:a17:902:dacf:b0:1ec:c9e0:c749 with SMTP id d9443c01a7336-1ef440505a0mr157387705ad.48.1715702692355; Tue, 14 May 2024 09:04:52 -0700 (PDT) Received: from [172.21.1.2] ([50.204.89.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c2566c1sm99172045ad.293.2024.05.14.09.04.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 May 2024 09:04:51 -0700 (PDT) Message-ID: <267be75e-ed4a-45d0-883f-51c7324c30f1@redhat.com> Date: Tue, 14 May 2024 18:04:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] riscv: mm: Add memory hotplugging support To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexandre Ghiti , Albert Ou , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Oscar Salvador , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-5-bjorn@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240514140446.538622-5-bjorn@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: fuc8u41sg9bf3yhipgpj7ujtkbxyomja X-Rspamd-Queue-Id: 8E7D1C0038 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1715702706-791014 X-HE-Meta: U2FsdGVkX1+Lx/mL/8wX2eSZSxHstNn18B85WzoWFt9sMMlEzt3YBIBKdfarn9eh+Q7pB5EmMiJbkopogMU/iiPsiO2R6U+ff8CK1fp11I8e8cogF+Q6u9+uybDIvU13P+4l10dGBudhbujp+lB4Dst9veEek7TL6D1G3VeFw64bmqECh6m6PEwNV6vFG9NQ1CFzYNVfn31d8VMWcB032b4X7RKaDG0NLc9BLnDrqc457pK4Yy+JlUpbxQVIZCCCAIwQ1T0JSseDJ7YmA4kCj3m4KNTGImS2cbup6IsiKYQIx9zhKpEbVHkJ5/Z/om0MUU9kHd2z9vNWfvl7FzSBdY2ir/lLm/qKYUvQZ3VU9lMwRoC+MmPwxvFZG36MU97jClwSrt6NZZnDfo7brjzhVfrUJBNVx4ovZ9j8Ktu+7V8SluLUPKTPKlF6WenAUZohKTCl63wGpE5hHEQnnl9cpHdSERpCwRQont6uKqnmHGzmL9Q5wYSzHVZ5k+LNE1j4cclOjjd5GKbnCeZYUF5HIf+9HF99TjfnfOewjrm7Ry0LHN28hEM2VY1bgm/GTplTq1qbkhFCh/WqgKCkPXqK0FWRPswiailZ82nMSBYnrEb2viNyEYNW+zV3NiB2oY13tmJ8wVMpPjnJfwhj5LGf8LiowuYFqzBPEkxg6xFY5DTFvO7HE+Cql4DEkhvwoNkrVXGjpyUKzQAowtVCynNOCOTF4jdJpwGFI7b1fnxF3dut5ZodmlDslc5vGN7E86MxPbE/TsRZDq4gb8ZTwOZ/EJvyIjO13Ejyi+hDMf1eJn1yphyf2feQZ/CUyftxgHWRf1+ENu4ZDVEvIChwgGcNX8MtTjwF3e2ZNjArewtU9LGBjOnZOvalNoP/aHGEntkWB12u+CauBPTBKaD+padaHMFkzLn0MtclNg7SBDBqVXF1UWrgFXUp7l+FuMB5nm129EIQqBVgnxq8N4l6VuN WGQlIYvS 3m04jIe+BIs1oX8rsRKpXhTeXC/J3lCSLRWj5ngByuZKe5OK5kLYaTcpa8JGCv6T1oCuWCqb8ZeyTpiAhJc4WJpKpdq+ZnW3vPvxyGNZgSTfjjbSyf6KiUZv8drzeA8cxZ0bMyV4BjVV30nLGSyNA5P1p/lfYuIuXDAzskdW/tCMO3wCGLtW9YOvNq6AGqZm0sUiI8WDS0Ig3XsAymsG/9w+jJRRC2V2MiXcJ1WSu7FDHZasrjont0Q7Qr+HU7njlf7njJH+VVd2kB9lil2R4otPU4mhotMuCE5wun5DI6Dp3o11BZHnjC/24zcG/PtWYXEKV+7bnwbRwHjWkgGRwXsihK6Pj8FkFOrBbJR3SiUZtltJZr7ps3ty2WAmOiRHzuJ6lWzwJo5QPvR2uYsIbu4pXOHlxbXafE8A4LE6zpKHqpBNiAl+YeKQo7lNq2KwSVL9Tswnbnkt1CGLA2r2XThAk1tMpEARzzY0ERZLJV/MwbMVKLyA8EM5vSj9wbC1ZfqYwInsShGyqz+IdGWWMBKTgtXpYy1RrkdwaSOER7b3KjYaSLoYZTzxso1kW5VTZ+xwAWTyrfwA9TrRakCvMxSJzROMtYVYwtu3o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.05.24 16:04, Björn Töpel wrote: > From: Björn Töpel > > For an architecture to support memory hotplugging, a couple of > callbacks needs to be implemented: > > arch_add_memory() > This callback is responsible for adding the physical memory into the > direct map, and call into the memory hotplugging generic code via > __add_pages() that adds the corresponding struct page entries, and > updates the vmemmap mapping. > > arch_remove_memory() > This is the inverse of the callback above. > > vmemmap_free() > This function tears down the vmemmap mappings (if > CONFIG_SPARSEMEM_VMEMMAP is enabled), and also deallocates the > backing vmemmap pages. Note that for persistent memory, an > alternative allocator for the backing pages can be used; The > vmem_altmap. This means that when the backing pages are cleared, > extra care is needed so that the correct deallocation method is > used. > > arch_get_mappable_range() > This functions returns the PA range that the direct map can map. > Used by the MHP internals for sanity checks. > > The page table unmap/teardown functions are heavily based on code from > the x86 tree. The same remove_pgd_mapping() function is used in both > vmemmap_free() and arch_remove_memory(), but in the latter function > the backing pages are not removed. > > Signed-off-by: Björn Töpel > --- > arch/riscv/mm/init.c | 242 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 242 insertions(+) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 6f72b0b2b854..7f0b921a3d3a 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -1493,3 +1493,245 @@ void __init pgtable_cache_init(void) > } > } > #endif > + > +#ifdef CONFIG_MEMORY_HOTPLUG > +static void __meminit free_pte_table(pte_t *pte_start, pmd_t *pmd) > +{ > + pte_t *pte; > + int i; > + > + for (i = 0; i < PTRS_PER_PTE; i++) { > + pte = pte_start + i; > + if (!pte_none(*pte)) > + return; > + } > + > + free_pages((unsigned long)page_address(pmd_page(*pmd)), 0); > + pmd_clear(pmd); > +} > + > +static void __meminit free_pmd_table(pmd_t *pmd_start, pud_t *pud) > +{ > + pmd_t *pmd; > + int i; > + > + for (i = 0; i < PTRS_PER_PMD; i++) { > + pmd = pmd_start + i; > + if (!pmd_none(*pmd)) > + return; > + } > + > + free_pages((unsigned long)page_address(pud_page(*pud)), 0); > + pud_clear(pud); > +} > + > +static void __meminit free_pud_table(pud_t *pud_start, p4d_t *p4d) > +{ > + pud_t *pud; > + int i; > + > + for (i = 0; i < PTRS_PER_PUD; i++) { > + pud = pud_start + i; > + if (!pud_none(*pud)) > + return; > + } > + > + free_pages((unsigned long)page_address(p4d_page(*p4d)), 0); > + p4d_clear(p4d); > +} > + > +static void __meminit free_vmemmap_storage(struct page *page, size_t size, > + struct vmem_altmap *altmap) > +{ > + if (altmap) > + vmem_altmap_free(altmap, size >> PAGE_SHIFT); > + else > + free_pages((unsigned long)page_address(page), get_order(size)); If you unplug a DIMM that was added during boot (can happen on x86-64, can it happen on riscv?), free_pages() would not be sufficient. You'd be freeing a PG_reserved page that has to be freed differently. -- Cheers, David / dhildenb