From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23E6C05027 for ; Tue, 14 Feb 2023 15:49:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 352616B0078; Tue, 14 Feb 2023 10:49:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3027D6B007B; Tue, 14 Feb 2023 10:49:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 137E56B007D; Tue, 14 Feb 2023 10:49:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 006396B0078 for ; Tue, 14 Feb 2023 10:49:40 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C6C79C062C for ; Tue, 14 Feb 2023 15:49:40 +0000 (UTC) X-FDA: 80466332520.02.410C5FA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 64B30C0026 for ; Tue, 14 Feb 2023 15:49:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=imKFnwWL; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676389777; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9N7LtIUCs1c3MxbwmYpiSal++u4MCEt1aDdzCRdbS6c=; b=NusJoQNNMvWdCRB5UYu5/QxCsOnMb+ISBAyMFANHRD7U5Wtdtuo5eu+8adGEk08mowJZ6T q2VypoBHF3/lam344mzgF/g5bWJd0nzb5/jk7dWzCIw80Iy4JEMDQXPZ320AQOhsgW8QdV 7q7dLBzogNvnuKscNqFZMGl2KSsxQvQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=imKFnwWL; spf=pass (imf10.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676389777; a=rsa-sha256; cv=none; b=arJw1sGf/1sBGPo/m9eVGEi+ZyVU9VCW69WAZQXYQfFkL6sSMkF43SyBEaWJ+LhVYCZI00 aNv0+3QXh+jcihB+gkVQqT/LWpg5nRN2O6U74SjP/38Rm6r7aseg3iRo8RHtQ8HAZhsOvO zNb1wy3BpmWLknpYd1wWpFBX5JOm34g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676389776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9N7LtIUCs1c3MxbwmYpiSal++u4MCEt1aDdzCRdbS6c=; b=imKFnwWLugFkedn6ORr36dmq7mofiDKlwK9/7QY1pcajk+BQzq7U8qqM7iMUpmud2Zq84e 6yH4zklOquUzeNuH9P1ux5boPaoKa2iPtNJ3f2aOBLJWLrltO9/4WOpHYxwRthCYevw4x2 xqZdcQJBv/+rMm4syp45I/JtkbQzm8A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-Qze0Dd2KNe6BqSZdcFdeGg-1; Tue, 14 Feb 2023 10:49:33 -0500 X-MC-Unique: Qze0Dd2KNe6BqSZdcFdeGg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E85C3C0E204; Tue, 14 Feb 2023 15:49:32 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E76B140EBF6; Tue, 14 Feb 2023 15:49:30 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <9dd98aed-0d9a-eb3e-790c-0dd744be8ccb@kernel.dk> References: <9dd98aed-0d9a-eb3e-790c-0dd744be8ccb@kernel.dk> <20230214083710.2547248-1-dhowells@redhat.com> <75d74adc-7f18-d0df-e092-10bca4f05f2a@redhat.com> To: Jens Axboe Cc: dhowells@redhat.com, David Hildenbrand , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/5] iov_iter: Adjust styling/location of new splice functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2677037.1676389769.1@warthog.procyon.org.uk> Date: Tue, 14 Feb 2023 15:49:29 +0000 Message-ID: <2677038.1676389769@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Rspamd-Queue-Id: 64B30C0026 X-Stat-Signature: psx8d1ukxi8buyuzreamu6317bfqitz5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676389777-608437 X-HE-Meta: U2FsdGVkX19ABQzla8mOuXg67xuXXzZ3Snir/goHoyRU0k5QvXcn8zCBvwGc1cw6CRQXTfy6btRLFHQntT4HK3KywD2QqcdzueaMemw9ByBFHi+D4Yfyc7ochiDf1jm8iSZJM7iVxXEURnMuFeCH1bYKtF39IIeHkEjFtG3743W3djUodi40J3Khe5qZfT2yqWhiAD82FD48M0tK2Xz6ssW5eVXAXk4YM8XzaIJUKhvxyic0k/nRrY/eulsiUSzSB+ynDXvyn2EmA8AdWqgakh3iepKAoKeuYeEzb1OdhtEAVuY1olaVsBOT62MQ2Mk9WXCNF0fHrqcG4VMXm4+jxsAm88HsJ81dTpNlwr9DcmUG3c2RT6DWWuEIJqka2emDXvKguKnD4Dd+yMqD1gUSwtQJAsj6yYANdQwNaljwH3J/I2Ug8HGq1oM+tMnEr8DxNdGL7Dg6HFHMAqOKnLMChwHmpiSKH3Q0JqIZIvj0d5W8qHommthw9PWU2jSaGZ9AfW337+XWnQANujGFCooieYPmv1R2hyZrkJuYpH7YGschYR3dh1W6mIKeOn+n5l2BUCa/0PSmp5/ODkIyambuDG/SC9rhOxIpvNzACDBOSi1QSXuz2BfXvFprts1QbMBRmaDYFVxr8shL/nW+oM0GPfOZLQdXq9JwMizZE/4UqGKvxb2DsPuIo9djgAMWPyyXXNAV5c054HZhS5I+ES5j4xDlhVBcj6JZd0q8KHlBgvq/rLb45M9i14Zz1HGvDJYSauLLjRmiItFBeMXzm5FeCQdkVgZOOseGCsyvuinkvijzbDg69jxobuw7CzyMK3L5LwDZrJ9i37nALvpDV30vsWCEnBRy14FvvUTJ5fhZl+cso82PgwWefqSrE933Ti3qH/l6CFo4Bey+HwITcpyohTYJr+GkaQ9cO+xU3wmKeAgTLOLqxA89fcAM2jEjiiUadNg7pp5E7LKlxpc/fjc l75Kd0cP hjWjadRkFc+zQlvsGNjHN7b/HSeOoV4do1YER7ODpbYr6F3/t00ZYXDyqjWuZXY9M25e6Tm5GCgcdtcJwIPY0qWC586AS8rqAohP4T3t6gsjcrUX8/u6HIsOsxa3pF3tOc8zFci1w2xw+07a1+2CH4w2qDuhmr9mF3n5QeFzkhid0MdoiW2EY1URlcTH9cU1yzqqdpFwELV5l1fIP1taSJLniEuKvzheYN1lL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jens Axboe wrote: > That is indeed the question, and unanswered so far... Let's turn it into > one clean series, and get it stuffed into for-next and most likely > target 6.4 for inclusion at this point. I was waiting to see if the patch worked for Daniel (which it does) and Guenter (no answer yet) before answering. It appears to fix shmem - I've tested it with: dd if=/dev/zero of=/tmp/sparse count=1 seek=401 bs=4096 just-splice /tmp/sparse 11234000 | sha1sum where just-splice.c is attached (note that piping the output into another program is important to make the splice work). Meanwhile, I'm working on working the changes into my patchset at appropriate points. David --- #define _GNU_SOURCE #include #include #include #include #include #include #include static char *prog; int main(int argc, char *argv[]) { unsigned int iflags = 0; ssize_t spliced, remain; int in, out; prog = argv[0]; if (argc > 1 && strcmp(argv[1], "-d") == 0) { iflags |= O_DIRECT; argv++; argc--; } if (argc != 3 || !argv[1][0] || !argv[2][0]) { fprintf(stderr, "Usage: %s \n", prog); exit(2); } in = open(argv[1], O_RDONLY | O_NOFOLLOW | iflags); if (in < 0) { perror("open"); exit(1); } remain = strtoul(argv[2], NULL, 0); while (remain > 0) { spliced = splice(in, NULL, 1, NULL, remain, 0); if (spliced < 0) { perror("splice"); exit(1); } if (spliced == 0) break; remain -= spliced; } exit(0); }