From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3633CEBF82 for ; Fri, 27 Sep 2024 21:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6732F6B0146; Fri, 27 Sep 2024 17:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC376B0147; Fri, 27 Sep 2024 17:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49C866B0148; Fri, 27 Sep 2024 17:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 276706B0146 for ; Fri, 27 Sep 2024 17:11:59 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E72B1C7348 for ; Fri, 27 Sep 2024 21:11:58 +0000 (UTC) X-FDA: 82611765516.05.784482C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 62F4E140012 for ; Fri, 27 Sep 2024 21:11:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FsJTpKKn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727471380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uMxOBU2H6Hw+qD+HRMDEGiSShQKw6OKRseN26Hxg0M=; b=nWGZgNXxJ8WGeN7Gey2FZC+n7btbhIBsGoP8nNOmEwLDOYkiEgYGX50OhVv1Y3hoCV+zOm /Po2+cHnQRDj7S2E09kq7kWnLaY2QxH9hfG3AM7TYkYhL86uoQ7oSI6o5RoIs/seipzsyP m5gSI018fpYQkqpEtnWVNzhueTSUs2k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727471380; a=rsa-sha256; cv=none; b=WT6OVMt/NbRR/z4VSChxMowrqq4sN9j7uohQ6cAb/F/rRWazhztZ6r2otFuaDZQ1xpX2VK TuStGdrniA3Xa6v3hvDjVclQy0KKA4Z/hRw7VtM8bEdirNoCjILPc7Kwh8lC7cH9pBHiZ2 ut5PoM1o0EJxEv51IwXDZU+t/QtFLHw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FsJTpKKn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727471515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8uMxOBU2H6Hw+qD+HRMDEGiSShQKw6OKRseN26Hxg0M=; b=FsJTpKKnXbio8SND1s1thRm9O+Ioa7LV/ohIU03LvcLBVubCeLSwPhE1dyTSBb+jfNKVZ8 GHwWXy1+trr933LG+RJ+dfxgJ0lRhulKrVE+XI8QT/vWODhKbkXZugqJuHOGNKH4WxTm6k Vb4OZ/lpvZXFEEmyBeDVsN41G9vDUWQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-nkGTJbKIOsK6M6_0H6aoDw-1; Fri, 27 Sep 2024 17:11:52 -0400 X-MC-Unique: nkGTJbKIOsK6M6_0H6aoDw-1 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8F2381936B95; Fri, 27 Sep 2024 21:11:49 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.145]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BC3D43003DF2; Fri, 27 Sep 2024 21:11:43 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <55cef4bef5a14a70b97e104c4ddd8ef64430f168.camel@gmail.com> References: <55cef4bef5a14a70b97e104c4ddd8ef64430f168.camel@gmail.com> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <2663729.1727470216@warthog.procyon.org.uk> To: Eduard Zingerman Cc: dhowells@redhat.com, Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2668611.1727471502.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Fri, 27 Sep 2024 22:11:42 +0100 Message-ID: <2668612.1727471502@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 62F4E140012 X-Stat-Signature: hrzqrz94as7omqyg4fmfzr4xp6gkd5p8 X-Rspam-User: X-HE-Tag: 1727471516-215949 X-HE-Meta: U2FsdGVkX18iGs+NWNrttapkLJ84HgjNuxgJ3EZLj0yGLxKotXrojP+vzm0/60Dl+FrgPl62crH/KgOsC71hKt9O2l49/Vi1E/39NskDAQZPm/ysOSLgRuetNXcjnDK1VDZz3ORTRwsY2Vj2ssQZPvtH2HtD7BMymspFQoGHNToI/VwZtI0P7pjE6Ax5MWJqcmm/67v+HSDgcz8mxOmu6jAVNti9mVjCXUNQqDIjDqbjkNuIWbwGS7kedPedZ18gUqtBROgnq5Jwl3WIpt5U0LZnxQAmOmyoHGnQiSU7Cl4IktzKRUh/M/ABNq1RPaMSDGvEZ6dWfN/o1iFzAMml8t5In6Wmr7Vfn36uucdO0+BHlz1TwBIxODRjJb9mhvNW5vsAR1NcLbREO7INDf1ppt6rRZy3m4Od7TvosJJVW+IVa+5Ed/qjOAU2z8j4hixXbXQphN76NsxLif5GL3iG+o1ec5Ci6R4VyKmEu6L+Kt1iK8+DGiWID9Rez7YUsQf8Jro6eg2+1BE9QEo4wDkr91uilmyNGQiL8rkivIeWwwnE54dSz4qdJFyNMxWKmGtxFiYS3gIjDOIJLYAe+0BnDrgc1vrfFADd9iuosbnFH/aKeABOB6wSg1brHn6MdLf/8JHl0buzbY5juFmXersCYpu9sN7h5mwlcgmZ0mc0XJj1l9cYOWHfIDfeOEt5KFrGUjHnq82+rQehg3a17+Z9yimG1Nt4kktZuNWYVXCmA2Gs0YvZShLhKo5chwjzicxVq1VeFdvof4dvUtWWJbE+4j+N1tYWX4T4z22+roR87QCja8hehXisVtA77XYdHUnRYJzB6WtTJvLgmxj7eCBCDIJqvBgPNfbOUd3Z/xijBYtLNibricwZHfU6K2lb4m/+Ppln1BASX6kQgBtiGYQODl+slDKJlSGKaeowI8k9CvnwqW2axAK3srGCw8mEubdenRsfEXx6LSOGlNdi4Jl 7Am+G82d vIw0VXvrN12cjxBeHHbbdluWA/VBGsPhbeEJPu3/vEUEX9Z6IOQGHWqyamIDEUKrJy8HayF3sIgkk7EpWC+vLTFdNce6HoGvk8WgS5oonXz06sBw/2hTK7LoR2nsZOihBaKxPR2hsxwqMZNt/CVksSrgQw/hzK8a2P17FfZRa2+p6PrpPoB8qSDiDf5bDsBXiygKFnytAB8sEzAP07BfuN1TRTsg0659c0f4i4aCbZiED5QKFK/RUsoalHmw176GCqItig2Xb52t2rQeG4Qon6Ogzfjr0C+BvNWkOdORdCJojh89p6pWkmhpMFGP5LAyAc4UFzlklv1Uwm4qIJCQYz0GNq4Wfba3vG8YF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Eduard Zingerman wrote: > On Fri, 2024-09-27 at 21:50 +0100, David Howells wrote: > > Is it possible for you to turn on some tracepoints and access the trac= es? > > Granted, you probably need to do the enablement during boot. > = > Yes, sure, tell me what you need. If you look here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log= /?h=3Dnetfs-fixes you can see some patches I've added. If you can try this branch or cherry pick: netfs: Fix write oops in generic/346 (9p) and generic/074 (cifs) netfs: Advance iterator correctly rather than jumping it netfs: Use a folio_queue allocation and free functions netfs: Add a tracepoint to log the lifespan of folio_queue structs And then turn on the following "netfs" tracepoints: read,sreq,rreq,failure,write,write_iter,folio,folioq,progress,donate which can be done by: echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_read/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_rreq/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_sreq/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_failure/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_write/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_write_iter/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_folio/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_folioq/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_progress/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_donate/enable or through trace-cmd. > Alternatively I can pack this thing in a dockerfile, so that you would > be able to reproduce locally (but that would have to wait till my evenin= g). I don't have Docker set up, so I'm not sure how easy that would be for me = to use. Thanks, David