From: David Hildenbrand <david@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Kemi Wang <kemi.wang@intel.com>,
David Rientjes <rientjes@google.com>,
Jia He <jia.he@hxt-semitech.com>,
Oscar Salvador <osalvador@suse.de>,
Petr Tesarik <ptesarik@suse.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Dan Williams <dan.j.williams@intel.com>,
Mathieu Malaterre <malat@debian.org>, Baoquan He <bhe@redhat.com>,
Wei Yang <richard.weiyang@gmail.com>,
Ross Zwisler <zwisler@kernel.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages
Date: Thu, 16 Aug 2018 14:08:46 +0200 [thread overview]
Message-ID: <265ca413-110b-cc93-ae63-e9780a96358e@redhat.com> (raw)
In-Reply-To: <20180816214459.64a7cec3@canb.auug.org.au>
On 16.08.2018 13:44, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 16 Aug 2018 12:06:24 +0200 David Hildenbrand <david@redhat.com> wrote:
>>
>> -static int __ref __offline_pages(unsigned long start_pfn,
>> - unsigned long end_pfn)
>> +/* Must be protected by mem_hotplug_begin() or a device_lock */
>> +int offline_pages(unsigned long start_pfn, unsigned long nr_pages)
>
> You lose the __ref marking. Does this introduce warnings since
> offline_pages() calls (at least) zone_pcp_update() which is marked
> __meminit.
>
Good point, I'll recompile and in case there is a warning, keep the
__ref. Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-08-16 12:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 10:06 [PATCH v1 0/5] mm/memory_hotplug: online/offline_pages refactorings David Hildenbrand
2018-08-16 10:06 ` [PATCH v1 1/5] mm/memory_hotplug: drop intermediate __offline_pages David Hildenbrand
2018-08-16 11:44 ` Stephen Rothwell
2018-08-16 12:08 ` David Hildenbrand [this message]
2018-08-16 18:50 ` kbuild test robot
2018-08-30 20:17 ` Pasha Tatashin
2018-08-30 20:20 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 2/5] mm/memory_hotplug: enforce section alignment when onlining/offlining David Hildenbrand
2018-08-16 12:34 ` Oscar Salvador
2018-08-30 22:14 ` Pasha Tatashin
2018-08-31 7:51 ` David Hildenbrand
2018-08-16 10:06 ` [PATCH v1 3/5] mm/memory_hotplug: check if sections are already online/offline David Hildenbrand
2018-08-16 10:47 ` Oscar Salvador
2018-08-16 11:00 ` David Hildenbrand
2018-08-30 22:17 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers David Hildenbrand
2018-08-30 22:30 ` Pasha Tatashin
2018-08-16 10:06 ` [PATCH v1 5/5] mm/memory_hotplug: print only with DEBUG_VM in online/offline_pages() David Hildenbrand
2018-08-17 8:18 ` Oscar Salvador
2018-08-19 12:34 ` Wei Yang
2018-08-20 9:57 ` David Hildenbrand
2018-08-20 13:12 ` Wei Yang
2018-08-20 9:45 ` David Hildenbrand
2018-08-20 9:49 ` David Hildenbrand
2018-08-20 10:46 ` David Hildenbrand
2018-08-30 22:36 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265ca413-110b-cc93-ae63-e9780a96358e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=jia.he@hxt-semitech.com \
--cc=kemi.wang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=ptesarik@suse.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox