From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B9B1EE49A3 for ; Sun, 20 Aug 2023 00:52:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 955FF8E0005; Sat, 19 Aug 2023 20:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 906AA8E0001; Sat, 19 Aug 2023 20:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CE938E0005; Sat, 19 Aug 2023 20:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6EED58E0001 for ; Sat, 19 Aug 2023 20:52:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 310D21A0437 for ; Sun, 20 Aug 2023 00:52:03 +0000 (UTC) X-FDA: 81142656126.23.6DB9A05 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf16.hostedemail.com (Postfix) with ESMTP id 7472C180005 for ; Sun, 20 Aug 2023 00:52:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IrDzPDlx; spf=none (imf16.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692492720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gr55w12BJ8HanXJKtEGmjMkhrZT3R55wNuvQW7dICuQ=; b=pvmvxaJANbRqZIr3fGZ1yQI7j/oY2n0byyoMdb5eXV9mneQ8/8vJg1MsmYObAv1uwV4f52 yciUJMqYdzQ71BozHyRzG3Qk6JtPq4eNLq+z18yRdh69YrX43Faym3Tli+dRBvHR70ZWLL dnFlRSudKgi6Tg7TDmtMUF0ff5YmLAY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692492720; a=rsa-sha256; cv=none; b=cnqcXFJLr9LgbwXmFpN6mOkUpomoDtgvEh4nSZm0xgLqvwz9nVFMlhVlCxAzxcNSUL+BDT Kwo4CfUZPL2JSaeUFdx5yJxHaLrKwt0m9LIYPaFoC5ILDOcSCKGb4qHpEodvH061EAl8dJ kheaObSG4f2QoHkpQA8UxjK+A4uZ1n8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IrDzPDlx; spf=none (imf16.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=gr55w12BJ8HanXJKtEGmjMkhrZT3R55wNuvQW7dICuQ=; b=IrDzPDlxB0+dYccoVG43B3F+hs 1OlUNYHcISxSlyVVSc8T51Mwcg65C6q7VnWkafRYHxD3dFvEEYGtOD9KEAxSoCDJ7Da2puA3fGkV9 eJ9DywZDzWlFeQpO6QKeCnC4Nhawgm/ffygvpMOLaYAMyt4FSo8DZwi7el7OMOEMWRmJmFIPkyl4/ VsrXJBWypxSwzvTdjaAoEnPmgcgfnsQ0jxjx4encoHDS/EKYzfUkCGWXxCaKII0nRHQbhAu4t+uFj 3zFVvICX17teJDcJ0YRGuXgvRB/943ATEPGfLkYE3q0wxfxCv3R3hZvABPRqbfAUqPptEsuPX43Q/ q1FIV9rQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qXWfc-00BHof-35; Sun, 20 Aug 2023 00:51:58 +0000 Message-ID: <26481804-ae24-beb9-9374-8050b4ac070a@infradead.org> Date: Sat, 19 Aug 2023 17:51:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 From: Randy Dunlap Subject: Re: [PATCH 3/4] mm: Fix clean_record_shared_mapping_range kernel-doc To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Mike Rapoport , linux-doc@vger.kernel.org, cgroups@vger.kernel.org References: <20230818200630.2719595-1-willy@infradead.org> <20230818200630.2719595-4-willy@infradead.org> Content-Language: en-US In-Reply-To: <20230818200630.2719595-4-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7472C180005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kkmekmtqd79sbfnygygykg66oehbs5h9 X-HE-Tag: 1692492720-745022 X-HE-Meta: U2FsdGVkX1+xkypWh821d+lyHMK4JZV5p+XTYj7f5F4Mf26Vbr9tmKxBHt4l2FG/q8B5jkGGFCBir03c4hiYDMVBJUndm+spXk6IBk/zP6WQEIL1gUlR8RcrTIS40/WHCMWZ1kYJJEXa/kWsCio8JydVKXnyux1vcSlN5ueUtcW8+ItODdmIuzJlas5nuj997qS+NadFIHqj7nz8VU5QkoyXAfGTkoJtSsEdr57M/7mtuPrGTeZcVO3oP+EhTe7PTHhoiQhZvYWnyqmPdJDL9liHyROqZd7xXgo2YkT5KA8KgEm38LxOVEHgPeWQNtSemFQpKCcP31bStY259j56ihT5LiHn5TWMb93Uph95npYxZRvUpXcxDMUDaMSBtieyMBWZ6ET2psSksZ3s7zBGx3U+dksdqCQctdDAdixtgxvUGdH4neWl+sow49JW9hF6o8pQ4ALubouB2RHngwjHvB1+6R5fkJUKlpHKDU0iasRSaUNmeTb1Sq8z59U6536oYptWEaKI/fS1rN12Pv9vU8waiwkZIGRCGoned8fJKWZK6PP1Ja3cemuN9va8ggcmLMLmQsRLD8EFN/rRbiRl3+FDCnDSE+MUFiH3/0ia/LHt9mImnMFxO4gHrvEBpAMUJpzBJXkzihQr35dJaqS4zeKxc038X0YpZMDCzyvPYcvh94ssRJ/CC2yVlVDGtt7LPUHEJMo6ogT/YAXXSWb9cXvLVi9FAIuw7VUrTI2bdeayE8g2qdicmLiFfVl3dhtquaXE9GbgfAgbhokZt+rJM8peKOFue/Y8WY93K8SqLcyVXaoKOTsPnE5k0HvTt0xwXbwy+jiUaLdPhhVrcgTYSHopWKceMBCOSUkGEMTEL6c0zoQ4WzCRGuM+rqDAvK3u3nyJIxr92U+CGaeqak4DKGZaTeZDoUKNV+N4qS5ER1OCbpfoI9fM/v1RCDi9gdh3HuDgBVawF1ZHyN+4kQP PBaCLPgz 51sEHVranDVFhLgZi073/Zlr55WPIK2F2T3AsFDb20kUpBHwczI8K86md6Dj3Ugwyf812IKq77xgM1095xc3bSuX6yz4JoowxxNc+hUg4DQnd0Ag0v2H3ogX6xXKr9eWtoBqQLfawpgzxvIGcPewyDaK+K0WFtd3ggVPjt1OULUoAUZdOM757wmWpfSHkc6VpNuMfHAHvv6hqQfKxpE4jWwyujoUW02KLlCaRNV2ce1+na7EHCv94hRF3U3xVs9ev1vtxPf5NwoRwf7PrdNA0sy3D6l10lP7xDKNIlCgpfdw7tIE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/18/23 13:06, Matthew Wilcox (Oracle) wrote: > Turn the a), b) into an unordered ReST list and remove the unnecessary > 'Note:' prefix. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Randy Dunlap Thanks. > --- > mm/mapping_dirty_helpers.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/mm/mapping_dirty_helpers.c b/mm/mapping_dirty_helpers.c > index a26dd8bcfcdb..2f8829b3541a 100644 > --- a/mm/mapping_dirty_helpers.c > +++ b/mm/mapping_dirty_helpers.c > @@ -288,13 +288,14 @@ EXPORT_SYMBOL_GPL(wp_shared_mapping_range); > * @end: Pointer to the number of the last set bit in @bitmap. > * none set. The value is modified as new bits are set by the function. > * > - * Note: When this function returns there is no guarantee that a CPU has > + * When this function returns there is no guarantee that a CPU has > * not already dirtied new ptes. However it will not clean any ptes not > * reported in the bitmap. The guarantees are as follows: > - * a) All ptes dirty when the function starts executing will end up recorded > - * in the bitmap. > - * b) All ptes dirtied after that will either remain dirty, be recorded in the > - * bitmap or both. > + * > + * * All ptes dirty when the function starts executing will end up recorded > + * in the bitmap. > + * * All ptes dirtied after that will either remain dirty, be recorded in the > + * bitmap or both. > * > * If a caller needs to make sure all dirty ptes are picked up and none > * additional are added, it first needs to write-protect the address-space -- ~Randy