From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7699C0015E for ; Tue, 15 Aug 2023 07:49:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E392900028; Tue, 15 Aug 2023 03:49:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 793EA90000B; Tue, 15 Aug 2023 03:49:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 682E8900028; Tue, 15 Aug 2023 03:49:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5AA8890000B for ; Tue, 15 Aug 2023 03:49:15 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3444D40CFD for ; Tue, 15 Aug 2023 07:49:15 +0000 (UTC) X-FDA: 81125563470.04.A413008 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf06.hostedemail.com (Postfix) with ESMTP id 3B2A8180007 for ; Tue, 15 Aug 2023 07:49:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf06.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692085753; a=rsa-sha256; cv=none; b=ZXz0XHhcC4kzdz/vRmTMB7cKaz3ZxDYMc215tqy6++SKOp3bwW6mOiCvhcDBSBzMfxP/O7 U00irfP6UiTW5UH77UshWDWk0ZKUp4BK48FvOgNDcv1Ygcj7RZCjFWLOxLGyPNlLvbhTDG dXzi8coMIPQE2XqXHndBhjuuZXX0mG8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf06.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692085753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EAuAJrH7sD3q5OJxL7cJkqG+fJBQKd04idB4lp742sw=; b=ymau7I0zWMQvTnNJNRCZq8Q4WW+ZlTEjNEptGgynRJ41CWYYS8hC/S/ftOLYA6qMJ0HbCG ZfK6QtrcGX1qdsRhIwkU3Lz5TxoLmYxUHh7C5PPU6ZOYeH8PjXieBkuSgOvER8L2P2DdHC 4Y8owo+xhNqUcJaOMu7NaFe0UcpkjYw= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vpr0xAs_1692085747; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vpr0xAs_1692085747) by smtp.aliyun-inc.com; Tue, 15 Aug 2023 15:49:08 +0800 Message-ID: <26477981-5348-2da0-8bc8-c736d080a2f2@linux.alibaba.com> Date: Tue, 15 Aug 2023 15:49:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 2/9] mm/compaction: call list_is_{first}/{last} more intuitively in move_freelist_{head}/{tail} To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-3-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230805110711.2975149-3-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3B2A8180007 X-Stat-Signature: btrhpkcom88xdp84iro4gxdufg7e4de1 X-Rspam-User: X-HE-Tag: 1692085751-769310 X-HE-Meta: U2FsdGVkX19twxWXmuJ9x2KVgXPtj7LcaQRZRO9EqFlXtLdYp63Wsg3X4vxA3jiwvPxBw/cBcnsaZDvpDhmmP+PNRh/AXi79V//cvB67XjN+XZQzpb52E+fr/7jKL15PORdLRF3uEh+5xGRkLm67UOgeODmxMOz8rPzlPEU2kt+Nky76Fwy5P+6Xf2b/0KOgmf9jfnvPEEoOWgO/Ul+C/PXd1GFghBjjhbOEFgT4qzOZIVWbWOW9iEniZbsCyGlG03DXcWS4Ie1QkBbrY0WbRusqN0qPLiF2dQ03MlkufUT8Qvql5MraR9m1NttpnHwZgCcR0mVCbBy26eXdY+CSyLkgR46U7qKQyJfi7f5CqIE08IDDWJR1jbeHg/gmc6o4hVzzxOO/PpCm7p0+L1wDWKLs1B8qe6Or4/HgqipmSKBAZt+TSBnVeu9ma9LqPdquo9I84sIJLO3NHU0CiYvYoqcXI7gg1IK1DUcupyqR9jcCSz/MkMMIhIEQorkMMxEsG1ge6LCBENXdIzsmoodp5DQ0C6Lr8QULo2nGbODqa1m1gXtNl8aDp9sWNMochD+BGiB8Flri2rLPk1Zw/6nL7BCvXSmeZQOmkKOkUWCb1dyYpSbc612IOAIUtg4NSPAonR/0ClYnmw7TfzCOWyc8O09X09I4qMe6Iw4EkK9R6hJIVVS/sDxE0VCvvQUy4qhzUTygHWjhEkQBs0ztq5oh89nAnHdFobwUw/+EVp2juqoaVWMji5eTdrHks4FR6pc1X8IJ26RRccwlzu/cmOnTB4Ngik5qpLNi3EHJAzV3yC5JLa7S7G/8+9v1HPYalZ6HnQLePNPQnqQnm4mClgmqZsUK8wvYOmGPRaLG+zbf5KyCzbDKZDYeY/IsRxd2EvIQciU8b5yxO4YIWezjttO5uF3aKaJxBYTq7F5nYkNyPcHxBcDe+k29r4kSBDsVnSiYPzT5QIiC9gsi7g8A1GZ G2P4UC2l 9HrLYTzyYLg/rbpSCqqTePPVoHw6fSoWjOHvOYMcsenk1lWAO0IdIirvpReSfr8CD6IKy2ALAn8pTvLF+SkSYl3G38IaYH/0fniUm7dm13CrLAdEmbFCyQ7wLbv1rd5uLXQYdFJV4nQIgWNH43hZZ4PxlDBM0Qhz0sg/ho3+Liqtxg3kstJdqffsyKTGmKcJJgF1uZTBpb2J0L9w6rMGiaZemXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/5/2023 7:07 PM, Kemeng Shi wrote: > We use move_freelist_head after list_for_each_entry_reverse to skip > recent pages. And there is no need to do actual move if all freepages > are searched in list_for_each_entry_reverse, e.g. freepage point to > first page in freelist. It's more intuitively to call list_is_first > with list entry as the first argument and list head as the second > argument to check if list entry is the first list entry instead of > call list_is_last with list entry and list head passed in reverse. > > Similarly, call list_is_last in move_freelist_tail is more intuitively. > > Signed-off-by: Kemeng Shi Make sense to me. Reviewed-by: Baolin Wang > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 513b1caeb4fa..fa1b100b0d10 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1395,7 +1395,7 @@ move_freelist_head(struct list_head *freelist, struct page *freepage) > { > LIST_HEAD(sublist); > > - if (!list_is_last(freelist, &freepage->buddy_list)) { > + if (!list_is_first(&freepage->buddy_list, freelist)) { > list_cut_before(&sublist, freelist, &freepage->buddy_list); > list_splice_tail(&sublist, freelist); > } > @@ -1412,7 +1412,7 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage) > { > LIST_HEAD(sublist); > > - if (!list_is_first(freelist, &freepage->buddy_list)) { > + if (!list_is_last(&freepage->buddy_list, freelist)) { > list_cut_position(&sublist, freelist, &freepage->buddy_list); > list_splice_tail(&sublist, freelist); > }