From: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH v10 2/8] iov_iter: Add a function to extract a page list from an iterator
Date: Thu, 26 Jan 2023 11:36:55 +0000 [thread overview]
Message-ID: <2642250.1674733015@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230125210657.2335748-3-dhowells@redhat.com>
iov_iter_extract_kvec_pages() isn't quite right. The problem is that there's
not currently any path by which it can be tested, as currently
iov_iter_get_pages*() balk at it, but I managed to do that by piggybacking
some testing code on my cifs patches.
The attached change fixes the problem.
David
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -2080,9 +2080,9 @@ static ssize_t iov_iter_extract_kvec_pages(struct iov_iter *i,
skip = 0;
}
- offset = skip % PAGE_SIZE;
+ kaddr = i->kvec->iov_base + skip;
+ offset = (unsigned long)kaddr & ~PAGE_MASK;
*offset0 = offset;
- kaddr = i->kvec->iov_base;
maxpages = want_pages_array(pages, maxsize, offset, maxpages);
if (!maxpages)
prev parent reply other threads:[~2023-01-26 11:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:06 [PATCH v10 0/8] iov_iter: Improve page extraction (pin or just list) David Howells
2023-01-25 21:06 ` [PATCH v10 1/8] iov_iter: Define flags to qualify page extraction David Howells
2023-01-26 9:25 ` David Hildenbrand
2023-01-26 9:49 ` David Howells
2023-01-26 9:52 ` David Hildenbrand
2023-01-26 10:33 ` [PATCH] iov_iter: Use __bitwise with the extraction_flags David Howells
2023-01-26 10:41 ` David Hildenbrand
2023-01-26 22:27 ` Al Viro
2023-01-25 21:06 ` [PATCH v10 2/8] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-25 21:06 ` [PATCH v10 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-01-25 21:06 ` [PATCH v10 4/8] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-01-25 21:06 ` [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-01-26 9:28 ` David Hildenbrand
2023-01-26 9:32 ` David Hildenbrand
2023-01-26 11:34 ` David Howells
2023-01-26 15:14 ` Christoph Hellwig
2023-01-25 21:06 ` [PATCH v10 6/8] block: Add BIO_PAGE_PINNED and associated infrastructure David Howells
2023-01-26 9:29 ` David Hildenbrand
2023-01-25 21:06 ` [PATCH v10 7/8] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-01-25 21:06 ` [PATCH v10 8/8] block: convert bio_map_user_iov " David Howells
2023-01-26 11:36 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2642250.1674733015@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox