From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2B1C05027 for ; Thu, 26 Jan 2023 11:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40ED06B0073; Thu, 26 Jan 2023 06:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BE986B0075; Thu, 26 Jan 2023 06:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 286358E0001; Thu, 26 Jan 2023 06:34:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 193AC6B0073 for ; Thu, 26 Jan 2023 06:34:20 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D47FB8067E for ; Thu, 26 Jan 2023 11:34:19 +0000 (UTC) X-FDA: 80396741838.13.6368D01 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 035E24000C for ; Thu, 26 Jan 2023 11:34:16 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QpCLiMHX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674732857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vQe5NpZwYsKo7kAgmlBPvHS4P0xn6hUuxnEkAKO3Voc=; b=JrcuW6PNNolP+ISk2FKGmFTZoeSQymOooGsJX1O830x5xqsvnVSz6oSjIXzTmYnUGmj1oV dtatXxfK6uKqyQWWvWqee7r+H6Upiobjw5yEvRisAb5uxZidD4zqF6sTbu4jgRYrI1qEA4 /SiHAHclcefe0ZMriE4PQyjvVMjwdrw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QpCLiMHX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674732857; a=rsa-sha256; cv=none; b=2dRuvEdWmeoxeXLj43VLnE9ZWJIwwDwxha/vcnoUN01sW6+q1FxOykqAMjCaaI7p9rhiXY PoKZM52V2udqhaKODHvw9zgbscgq78epDV1F1EgjKewiwGJuIoALui3M+VWlB0lnhy6lTc ifHuY8Skexalw2dyMS1/KKFORAjPZTo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674732856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQe5NpZwYsKo7kAgmlBPvHS4P0xn6hUuxnEkAKO3Voc=; b=QpCLiMHXwXCwKa5CdjXk84vbdTpDhyoMUEMRFVnlkyD1tL9QRDolQZnWM3lJqqNRuhGggQ QwUzaE0k3REZylkAn87yCsUqbpjWNw9M9RorRUukAiXaHdMwHQSuq6VSxSu5jALOOy0diI Rj7mteCy/X7Bz9IVkw9n14bjGCTr3a4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-YQTcYeUeMWCzoABBoC_j_Q-1; Thu, 26 Jan 2023 06:34:14 -0500 X-MC-Unique: YQTcYeUeMWCzoABBoC_j_Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A3F2E185A78B; Thu, 26 Jan 2023 11:34:13 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EF24492C14; Thu, 26 Jan 2023 11:34:11 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , David Hildenbrand , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2642147.1674732850.1@warthog.procyon.org.uk> Date: Thu, 26 Jan 2023 11:34:10 +0000 Message-ID: <2642148.1674732850@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Rspamd-Queue-Id: 035E24000C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: co1am4anggh1qh5xfccaogm614rwr9y5 X-HE-Tag: 1674732856-777775 X-HE-Meta: U2FsdGVkX1/jgFwS2sHbZexf8a9p3KEWlckH9eW7dfpeoIPV0/JJDJLYjlcjTpmrkJV7LvPbKKTWE6qGFTYkoYaaWa8VNK7Cfp52pouV6Iz0w81jJby1FnfNf6HghTAbr0koVKa5tK9+6BZMY7TA/Mku2j6+5+hM5LxGde3jJUfLLtPrCocohhVoVlveGrEZjvMP/NJxrzCQXKg3VBRk5/x2jt/++NBHumpMpFfRnt0o/VPyOWwgPTMKx9MYrV1FZN3KlkAFcZesyTi5Yy/HtFQCsiYRbyDQh3FTswMjTlL+gWaNGrD3acFeZBIzS8LsjlUfTS7jfJH8TN49Rb87tRr2nNJ1HqhZM5qQtK5WT0LjbVyMxTI6spqKnyx+PWSLzdlzYgcV7jT6797kdPmr2WD74QgTTQeoPTDao0oW+P6THqFF/krzsikwSLZFUNbNGj3R4sZagVk3JZUP7nVYhcFBCt9nx9PYmji9FfdLZVtq9512SrcARGN+fAnYY2sm4PD6WzF+0yxU4cVnFIMkmzAykEUDQQ6BoV1ME3gp5Eq7VFnP7tZ9tPgkzQO/UCE7mR7CrHQoLhYk2kmDOLNgoP1T/WtKyHUpgQXlsqDCMgkjV/qZXehPUO3ylxwO2tn35mCUSjfEEzrov2ZXuqJ/PIoSrOOSj/luy5mg8vusCeE0YPvnKNR9V5fmh4g46SDfxDE6QG/py7R7cSjfpfg7WeFtuXxQiAdkKla9dxppTNt2E6eAzxL9rVngwqckUrXJeceZ+6CuISuM3c4GgG5noZ0V1yJzS+Juk+YNT37HpANjx1T9eowtJIwncF1qoRFd8I4VlqwUf+yx3W+Rf016NDXpD6owhCtzM4eDqjmlsoZaaqJZCnJEUszP3MeJANjM69EVRJvVvTqnKSbscV8paFzTa4gxxIQN9JzZjp/va9Uu3KlTzIBYIhCGNamTovETQzaFYnq1QhgO38W7HkO q2g19Goa Nno4xVtWT6kzP5cdi27UFhASXQlYDzJTY6d0Q56a0WxmM1IQstyjL4edeAQmOCRUH4wrKe5xV/eyR1EneNjOhqInj5CwPG7E4qsyvxXQFnTOaECokKrnTRt3H+sDf56ypsOtE0uxL5LPmISG219RxVB/3QnxSbzomaPU67umeJQiO10mNbyp6KNXHinMWBApViWJbKROXTbEvkN9A/s0oAEWCQ7xcPEs9YY61aetmgQ7P+zlUvmgi8h2dixjypOy5i8o1+id841mqXvW6xD569GsE/H3SwT2BOSWRZzlZZZTP9JbjOxttLgHP+WKln2DrcCAz/LVCFMgh205CoQ3aXkIwbHNaHDd8BYl0keEeRB1iijXqPpWy6tv0/O1xtz04KwUFBr0j3ucsK2mOl4TC/jhJ6FLB6bwynKG8blsg0c+Dc5g1t9wqe/tNGsL/Zb8GupWm/Bap04K/9+QqbWSzuJXPaFOntImQ88vW4C+pN4DBFw+UyJxi4Tn8YZH+lEFK6PH+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand wrote: > > Signed-off-by: David Howells > > Reviewed-by: Christoph Hellwig > > Reviewed-by: John Hubbard > > cc: Al Viro > > cc: Jens Axboe > > cc: Jan Kara > > cc: Matthew Wilcox > > cc: Logan Gunthorpe > > cc: linux-block@vger.kernel.org > > --- > > Oh, and I agree with a previous comment that this patch should also hold a > Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as > the author via "From:". I think that was actually in reference to patch 3, but yes - and possibly a Co-developed-by tag. Christoph? David