From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3252FC47258 for ; Tue, 23 Jan 2024 10:47:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA3926B0075; Tue, 23 Jan 2024 05:47:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B52C56B0078; Tue, 23 Jan 2024 05:47:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1AF06B007B; Tue, 23 Jan 2024 05:47:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 905F86B0075 for ; Tue, 23 Jan 2024 05:47:45 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5C7FF80554 for ; Tue, 23 Jan 2024 10:47:45 +0000 (UTC) X-FDA: 81710250090.25.C959FCE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 9F18040005 for ; Tue, 23 Jan 2024 10:47:43 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706006863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SDbKa442BrMUXaKKpRBpBqNXVyGD9j9J4C/PfQIyatg=; b=3E4xJbe8t/lNPVZMZz51mMIKsnolEcGRcvn6mYmcxml8bTDZW5vVYEqa40YSyac5trb9hv 4VmIZnBsi0BT9K+dYNyNER/e+wYupXmf7ffTTCdeLRuGLQ2hhicc7i2sqoCOaqutqVzaT1 X0FLgQDQc5O1zs9bjSYkqwUMLoUkmKg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706006863; a=rsa-sha256; cv=none; b=n45TSfbeMd5GNrcVvNBoQhQ/EgV0VeDliv6yra6/4LB/cY3kyrD/oRqm7n2zXHoc9F6R0M BE6JMbXF1Eezsb5hShgIsIRJ7ybamdnMdhJSMnMPXOfQvbNjLwvpkkY6GlJMU4NY1KMN/+ xc6p+BKbOEUrpSAeAebmi8GYNkCrabI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A3EA1FB; Tue, 23 Jan 2024 02:48:28 -0800 (PST) Received: from [10.57.77.165] (unknown [10.57.77.165]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F16A33F5A1; Tue, 23 Jan 2024 02:47:37 -0800 (PST) Message-ID: <26286ea5-2781-4e70-b52b-f8a44a1b1407@arm.com> Date: Tue, 23 Jan 2024 10:47:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/11] mm/memory: pass PTE to copy_present_pte() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org References: <20240122194200.381241-1-david@redhat.com> <20240122194200.381241-9-david@redhat.com> From: Ryan Roberts In-Reply-To: <20240122194200.381241-9-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: gn1fa5u3myb4matwaz45kerusdbdshi1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9F18040005 X-Rspam-User: X-HE-Tag: 1706006863-286928 X-HE-Meta: U2FsdGVkX1/P8mm5sfHopYyBrgjbzxcgqOUV0h7fSexpk+iDEBMQGMlWI6orN61aB6VDMMn3ysN5wckNr1VtODPdq7JeyR8CbhF6cOlv3J4ax9Pm4jg8qs0cAihVT99keGgvEvDkHb6HK6OkveoMJ221BD/VMUqql+y6vmBrAUerQahc6ZWeNmdT5DIpWLCtDZIfA8g8fqNS51AbyGsQNCOQNnXCmDBCmHZQL8vvo6CSpgDUqV5MZoKOm9JMQUTORFzXA3ojnpffoLrj+MIiuiZnbBYhPtmaKsX4eJRpES1eyxyzisgMKIAHVQJJao1ekxagcn7aQ4S4vGMinscTKV3IwtqWzXZXl5l/FkAsoItnwEnTyMeOzj0gUK05nV/aRzO0N6CN0LgEcC7Wb8NpYUJPKlyLIBRsLfk4UEn/9H3XjpQISMWyPiuFVgvuDyEkDscInB5VXzFJccJccwbzeUm5X3k4jl409jmG2kvm7jT8VSYbXevdDBCNJIXXBbevNwTpq4/sLjOvMWbyPijsTzQzKTBiqVgcj7cLh1H9Ep81jnAy7SHWXuhkPPLj4cb2+DYjw6wluHdlX1WHY8DRyG6jiGo1dUtad419h1QvCwfDLez+1OSVZjFKRMC2behYbgngbvWet/mn63DED029QKnWoxW+1FZg836PqeZW553/KRTFeZoNosszlxDZxCiHQlOlWVhxELbrj7G9QBYLGYKbAKicDa1i3k0HSQxKDWUSBo/OyF/9W8yQSx8EpSSMO23ET6JjBck7y08th/ma8n+Bq8BeEX3s06/w/+FQyvfRa0BhdfPmU+j+4LLxir59PZx5T+SwhqiZigj/xlam1UxFqU5cTxciz7kPsASzK3lVdXq9KF0dSCYs5rhteMUdgvHiV1RkAqkYXO63GReg2hcGP6k0cMjpBlUyKHhvphtaUPc8x9FYm8TqXf19iCB49E2YVYDtvC4dLut9H/g LO40m7p1 ygoIMlh2vWm1/wadEg4XMZ2acpciYjtHZoJSQ1AV83QBiQyq99g9cJXFiUESUfcdg6LAz8sNJtSViMA1yczdIPtLRvdqKL3cfto1Ec6/3aKHv6ytqGwEUGl5AWqr0w/hC4XCa400F04kwGehmjhkAyQmKqBT8vgy9V24YLy2gxgKvhkzZ/pn84KCLb7iWO5s6unZW1I+N5C4ZHMs95yWVyZhPAtNL/a0LcectPsTntoqtyjCxHkDUiqpK3rvgllZJDL2kFikED9xgz4298YT9D82rKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/01/2024 19:41, David Hildenbrand wrote: > We already read it, let's just forward it. > > This patch is based on work by Ryan Roberts. > > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/memory.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 2aa2051ee51d3..185b4aff13d62 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -959,10 +959,9 @@ static inline void __copy_present_pte(struct vm_area_struct *dst_vma, > */ > static inline int > copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > - pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, > - struct folio **prealloc) > + pte_t *dst_pte, pte_t *src_pte, pte_t pte, unsigned long addr, > + int *rss, struct folio **prealloc) > { > - pte_t pte = ptep_get(src_pte); > struct page *page; > struct folio *folio; > > @@ -1104,7 +1103,7 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > } > /* copy_present_pte() will clear `*prealloc' if consumed */ > ret = copy_present_pte(dst_vma, src_vma, dst_pte, src_pte, > - addr, rss, &prealloc); > + ptent, addr, rss, &prealloc); > /* > * If we need a pre-allocated page for this pte, drop the > * locks, allocate, and try again.