From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40BCC54EE9 for ; Thu, 22 Sep 2022 12:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F0A66B0071; Thu, 22 Sep 2022 08:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A1AC940009; Thu, 22 Sep 2022 08:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269B6940007; Thu, 22 Sep 2022 08:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1605E6B0071 for ; Thu, 22 Sep 2022 08:54:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E72091C6DAA for ; Thu, 22 Sep 2022 12:54:18 +0000 (UTC) X-FDA: 79939714596.17.979672B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id 7360EA000D for ; Thu, 22 Sep 2022 12:54:16 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MYFXB3CS3zpVQv; Thu, 22 Sep 2022 20:51:22 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 20:54:10 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 20:54:11 +0800 Subject: Re: [PATCH v2 7/9] memory: remove unused register_hotmemory_notifier() To: David Hildenbrand , Andrew Morton , Zefan Li , Waiman Long , Christoph Lameter References: <20220920025123.2868953-1-liushixin2@huawei.com> <20220920025123.2868953-8-liushixin2@huawei.com> CC: , Kefeng Wang From: Liu Shixin Message-ID: <2613e70a-4aad-fbcc-e014-eb5b84c2f8ff@huawei.com> Date: Thu, 22 Sep 2022 20:54:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663851258; a=rsa-sha256; cv=none; b=VrGeCTaKBffYCFx/Q4qbGOYsGsJyC3SBql06RmpuegYdUct0n/1vXDiZq3WfoTH8xeZwIk QuIwxSLyjfRFO/oI5k9VqeAz5EgETmHpJAGACGh2k8gd7ac3QZii0DI5ztlAWQXatcUIZT YBli/RRK+SIzR6VBqr6Kxf8+qO+laLw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663851258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QLXuXnIPuDtmOdW+4L3V9dsRs6T/+Lg4pdJ6xbsKy9A=; b=ArbKQPXy9yvM2DvCMmkbRpVmGzkKxoQd4A35wuo93DIB7PX2xHXHWgJd8EVtyvHyJQGCSF SI6VerBPXBXZ4jyT8r9dL6G49XaZirOncxnL635HDEGrNW870j/X1j4rPwQoqnKOct/Ww+ 89RQVebnLNDD3+daXrZ4czDQi2InOx0= X-Stat-Signature: 5romz956gqyw3neq7njk437sxbwqw3y9 X-Rspamd-Queue-Id: 7360EA000D Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1663851256-106444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/20 20:06, David Hildenbrand wrote: > On 20.09.22 04:51, Liu Shixin wrote: >> Remove unused register_hotmemory_notifier(). >> >> Signed-off-by: Liu Shixin >> --- >> include/linux/memory.h | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/include/linux/memory.h b/include/linux/memory.h >> index aa619464a1df..98d2a2ebcc10 100644 >> --- a/include/linux/memory.h >> +++ b/include/linux/memory.h >> @@ -19,7 +19,6 @@ >> #include >> #include >> #include >> -#include > > ^ why remove that? > > register_memory_notifier/unregister_memory_notifier still uses that. Yes, you're right. I don't notice this point since there is no compile warning. I will add it back in v2. Thanks,