From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA211C05027 for ; Thu, 26 Jan 2023 09:49:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 635328E0002; Thu, 26 Jan 2023 04:49:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E3606B0078; Thu, 26 Jan 2023 04:49:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AAC88E0002; Thu, 26 Jan 2023 04:49:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 39DED6B0075 for ; Thu, 26 Jan 2023 04:49:38 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02022A0923 for ; Thu, 26 Jan 2023 09:49:37 +0000 (UTC) X-FDA: 80396478036.01.9689676 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id E64FC80017 for ; Thu, 26 Jan 2023 09:49:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ISc83OAO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674726576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EG/449qSmt5dxUptSk+N35YPkCWa7qDSTbYqeA0hffw=; b=U/zU/4oo3igs8XWu5oRqA/FaWYmrA+NHg0Y1Gp5ipZZ2Ko7zaNakPA6qYkj73STmTpuHK1 6luy5MUARUsUoitsyj5eGCV7ELvw79R0q0S1j6m9Ezw3/15A7LncVinENAIZUxJvyrNhk9 yCEnLWFc/wMMKzhLVF3KGvYAlAjaMQY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ISc83OAO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674726576; a=rsa-sha256; cv=none; b=vwjhPbr1oJqWCaVU4QZ5e1GyTVpIgRiBvcQ/7M8damTW2D7L0sDsaUAMnayU3V7DWVvpuZ Pmy8wT6fx0nmSOK6LSrXKp03K+96AQrPrcYBhKzGfMiEDtS9izgY80SiBmuQ5eM6UbiVMk VD+fKimGqm7RD/MO1luZ4KcprIZi7j4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674726575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EG/449qSmt5dxUptSk+N35YPkCWa7qDSTbYqeA0hffw=; b=ISc83OAOksEl5+q5EJ7+f4KRFjkAAjZ5u/wYAxyMiy0c3v/Mtb8tlerJvtTcr12GzX1LJh n927XpXaqeRmuvT9s29M9N2cCTRaAOf4+cjWhhiCjJGDM/gvnkvL3dqbI/LNHCBSpQVUwL jZQZz2NxsubJyWLGD4OzhYPKryKsc2o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-571-_19ox34JNBWf8p6rKRDejQ-1; Thu, 26 Jan 2023 04:49:30 -0500 X-MC-Unique: _19ox34JNBWf8p6rKRDejQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87602830F51; Thu, 26 Jan 2023 09:49:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6ED69492B01; Thu, 26 Jan 2023 09:49:27 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-2-dhowells@redhat.com> To: David Hildenbrand Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v10 1/8] iov_iter: Define flags to qualify page extraction. MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2613248.1674726566.1@warthog.procyon.org.uk> Date: Thu, 26 Jan 2023 09:49:26 +0000 Message-ID: <2613249.1674726566@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E64FC80017 X-Stat-Signature: 88bs9thec5jg5do641dwd4kc3b95k5ih X-HE-Tag: 1674726575-313305 X-HE-Meta: U2FsdGVkX19Zw/OkMV+x50VqintmcYrsoh5imGRDTqNRsXuuUumPcL1UY0DcKtHtIXW1j6FgHxQ9VwXqdb8UbE40e4cm0058cHpsExC1T10hPd/e13jSVJigJg53qeHfsRSuSslfKe9wlNIT0m5j2cVupXZZ3SkNjZHYIR7FpzHRYdVxaccTvSoWI9nzb+ardIK+ypAXonbr4Bks/qKR7oqxAUGVwgc5ru4wlj0e0/LMNYYGb3hsqH26lJqDYaN06PykYe69bNGk7MuDy2ktlwTB5UJaLNNtmocy+7uIh4n2Ryeqo8eXXxf+fi245K+Y90E+TRkbm/KoGnwU7ZNgql6zFXTHoACbkYtKMzmuH6MfLNa9qyB/UyBXz1sMqPthkNDSLUYS2ocsBJASJAYpUVrVbIrccB7XP3DptizLHOflpLiCc94YW8DGLSYQOpIkUy94BH59/f4visFtVSJMxXXicO8/4+0Xfs8P75OsDanBay2gwYIszvnvUNUB0bJhtpyIhpuwFaiOKnCwffgyJxV88R+KbMruuq/7X4WLYhkNGFnyv7IGSXLJsIstfLuxbPNu9bwsGEmUV3f9DymGoKTwppXLxjeiB0ZOQC8GSLT6UKEvYvcrMym1oIraz1Kyg/pi3djRO4dUbMDd1U7VS+AsuxPcBmoEk6ly24EBAKqCvRABNS92XomE3LyWUXm1na78LsA8bF9lPuzZIsiplUCLtcvbXiLrKbxMuxz5mUiki5GM0gM5+mlrHtuQeekE0b9Dayc9xTyOagKef9SxnfQwGBYDfZlSgXjqxpgK+lgZFY9fyMTR/VvS1WGzRVuxagjmON5H9TD/4OuZINiibzXfxBQzYO2DGZyIz1TerpyJfIlc+Za3qfDZz/yBUNwXLisBrY0Y499PjOMyv8Qbt6jgF6qo9T26GDlr4V+1Cr9rSdsCsxSxbzSBP9DIOFAQB2tdh89X5KTtRpRrH3h MjxTLafN T1meMEF4Ew2osVHWY8r9hwwSBnjvR6oHBGy+d3lM1OW6vHTVCfW3mLJhec6NPCwGzAQp954DI42lpyAbrB0dPLSUER8RtlG7hKUSCNtf2T+8dWqJZUtI4CpKDn5HmCksWZCHkXOYU93mBaPtEb6AsMnn2pWI5P7BiEyMBLIu9qUOu9jYHWt2cvTUBuciDdlNEh7sdFmm/aoC+Grh4o+TNMyBAoiApqchgejsBTw0zpr9pyVWJMUDC6G/34bLykNFy9ISsY80i/UCnAFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand wrote: > Just a note that the usage of new __bitwise types instead of "unsigned" is > encouraged for flags. > > See rmap_t in include/linux/rmap.h as an example. Hmmm... rmap_t really ought to be unsigned int. David