From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8032CD5BBB for ; Tue, 19 Sep 2023 13:23:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12DD56B0512; Tue, 19 Sep 2023 09:23:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DE246B0514; Tue, 19 Sep 2023 09:23:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE7AD6B0515; Tue, 19 Sep 2023 09:23:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DF3BA6B0512 for ; Tue, 19 Sep 2023 09:23:47 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9CA0FC0D8F for ; Tue, 19 Sep 2023 13:23:47 +0000 (UTC) X-FDA: 81253414494.11.B0457BD Received: from vulcan.natalenko.name (vulcan.natalenko.name [104.207.131.136]) by imf14.hostedemail.com (Postfix) with ESMTP id 8EBAB100002 for ; Tue, 19 Sep 2023 13:23:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=EFQn3dLI; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf14.hostedemail.com: domain of oleksandr@natalenko.name designates 104.207.131.136 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695129826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tq3JgcNh99UaG2q9/1V/2rlmDp+hgSkFOwAuTwify40=; b=fytaXEFoWXkwp4QISw1hCVKuVREam4XJzwPjXfgKSjR1NYIzOfG7h677CWilGPdf1356bm ps6CYr7z3zjdT3lM6j7j3ECzLCWXlMGnggMTb9gmtd+LkG0JI7FVMEG8k+JP4pGcyENviD COjcCL4LR3EM30MefbJJoS2oytLTkeo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=EFQn3dLI; dmarc=pass (policy=reject) header.from=natalenko.name; spf=pass (imf14.hostedemail.com: domain of oleksandr@natalenko.name designates 104.207.131.136 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695129826; a=rsa-sha256; cv=none; b=NJrml1FT9qKTLQDRVXN+U4M7Xe+H30gRuFvdoHtb3OTvc7m1998QmczadIM/tL/4GVI7lP wehWaPKrR6uSvnANk+bxc0T0ezqar7L94yMXbTop5mQbBV8mCWY5qv9CdqYP7liFQjCNVY 3CYv9PyHePGXCyL89+0F4UflHE3guQ4= Received: from spock.localnet (unknown [94.142.239.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id 7E91D1505BC0; Tue, 19 Sep 2023 15:23:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1695129822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tq3JgcNh99UaG2q9/1V/2rlmDp+hgSkFOwAuTwify40=; b=EFQn3dLIjGw2NfMY0Mw+zSYng4/2xEivklVs1aPyZtufAL0Lq4Nqiyi6HpVhdS7itx/CEb yGDsRTNNyQYfqfPlXZMoj8OyQJa/NAyjd66+SF4pLuPq6x1A6I4tBCO2EoTGAuKCesF2dv O+DFMhteDnsG9m5MrIY6EwOyoYqC7nA= From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Andi Shyti , Andrzej Hajda , Matthew Auld , Matt Roper , Aravind Iddamsetty , Fei Yang , Thomas =?ISO-8859-1?Q?Hellstr=F6m?= , Nathan Chancellor , Chris Wilson , Daniele Ceraolo Spurio , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, Bagas Sanjaya , Linux Regressions Subject: Re: [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5 Date: Tue, 19 Sep 2023 15:23:28 +0200 Message-ID: <2612319.ElGaqSPkdT@natalenko.name> In-Reply-To: <6287208.lOV4Wx5bFT@natalenko.name> References: <4857570.31r3eYUQgx@natalenko.name> <6287208.lOV4Wx5bFT@natalenko.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5147933.GXAFRqVoOG"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 8EBAB100002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ic599qj45ricaoscyywncyww3oxghow1 X-HE-Tag: 1695129825-533940 X-HE-Meta: U2FsdGVkX1/0sQmcw8IWPAxsgIubBLSWm9eYx4O8PQqnJS1s1gH+3OlpDiuoqbc+780PYFxVeXbiI+MzbGLTipxBTgYk450NBFAuKytTQw0yGEPuKgMuMDzpWl+BQI9Sf79BDbDec8thILmEv6gu4IcUzRDXMlPHAB1ActlyxgTrgewXXgt4ONAqT2zm713yfkc9KYPcTzPKvHXo8H52nqUQplLHseiS2AcL8JGIn94vc/7kTHKm3sjSDmiH3JHc/fMOkUoQAF6fy+QCAXPir5HhTjDw7qcVyxFNcqSaI4auzE2fu9noU3hI6lL5GBkHe9fPR5Opr+6KnZBnCRzvK7wHdqOtUTsOep89JhbimF5WrfP3pWnC8/a/HrzHn9UZSafEcCPTNlkA3z3Dv0A2a+toLO+bw24DeRForkpf6Ummu7PXh22wHimcCWiQkhzpzHKkpEnhkM6zIhkr3nktJnUL6pQadsJZMG04tGUBAIfclguqoFwxEIHSF7AlYgXpch9XjrEMH9rz/oFcgkppMRbsFlfhDorq+gLne6wY1FTcfb/t3fnwDY2B9jwaz9fSH/JVegL7ZpmRJahZLGhW8Z+8hFLEnLG+FfnOPYjhO3aItj7893ko4Asa4YsKIw7hPVeqL+35enSG8bneDo7Jor229SA0+HfVBNOP6kb0WnYYz0FtFvH1kXHkQ4IzlEJkhqXkkc+rOkGh9oSmtym0imwUVJEN6Rl6U4uNIY9Me9GIZm+Ilo7ER4XxzjPzr41K+ug79fGesuzhg/p0uhwroCVgPqAKF19yxlyZx10H/3gW+EAWg7kbHwJrfFRsGGS6LgdjH2UZJ3FdD5GRqDFSy5AtR7JNVBM0SnxpjNj/DFB7geFk4FYpPvmsxVtqh7xQLoF3yv+WJ4nYr+RK/3b241K4Ta0sZtKojgHlcagn7Gm0mwynd1PMZ1Rq2a/zAHZDHlDsmHib3MtOlKAMub+ 4Rsi4FSG DKSHUB/JVr0TNOzOabiSyS3PsAevKqgK/7egwXLhuD1oOPWJkZ2xYRcE/dRO31y+pUzhneCerSnhZ/vGXLNCIQgST87fIe2vkOLV7DKTt14IoZXKdw8xLT8kYZl/qmmduPiFDqnTCniQgHyp9HjmmVrbhBBfcWWy3t+MB517GS4XTYXhlwGSe2/ibn9HOdP8t7BQmIIqhaRHd7yOkv0nCErqj0PKNaFVYKB63TLCvnEIrJrVQk8f1r81XyGqYupwH1xljUh8WWrlnlaYlPL99WR9wpjE4osn+F/FF3j/AKwpWaz+e1j6xAOln2+41QuERMUzdcDquadB4oDjB+nUYe3YGCtNxbsIKzHO+xN6tgqjfeURsId9y+RNADlY0DoqXFNOhE1AVPZ5rvFZZ6eRG71SHBWF2IND3liNv0Hf5LFGTSvUquJaOJxAPok12/8Ma9EEApqcxXuh7jOf4pCR4yc3csQio3DE5qVdcWUQv7RFIXoyzW0r8sKiZ0JCc0tCWB3eigkiNMl/IH5QRp/8XPHrBS+u1R7Ikow+MC3/gQ8UX4v2Porq7l3mVmKWaTP6HXpBH96PZI6mbgEQYtSUrS1uOSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --nextPart5147933.GXAFRqVoOG Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Oleksandr Natalenko To: linux-kernel@vger.kernel.org Date: Tue, 19 Sep 2023 15:23:28 +0200 Message-ID: <2612319.ElGaqSPkdT@natalenko.name> In-Reply-To: <6287208.lOV4Wx5bFT@natalenko.name> MIME-Version: 1.0 /cc Bagas as well (see below). On =C3=BAter=C3=BD 19. z=C3=A1=C5=99=C3=AD 2023 10:26:42 CEST Oleksandr Nat= alenko wrote: > /cc Matthew Wilcox and Andrew Morton because of folios (please see below). >=20 > On sobota 2. z=C3=A1=C5=99=C3=AD 2023 18:14:12 CEST Oleksandr Natalenko w= rote: > > Hello. > >=20 > > Since v6.5 kernel the following HW: > >=20 > > * Lenovo T460s laptop with Skylake GT2 [HD Graphics 520] (rev 07) > > * Lenovo T490s laptop with WhiskeyLake-U GT2 [UHD Graphics 620] (rev 02) > >=20 > > is affected by the following crash once KDE on either X11 or Wayland is= started: > >=20 > > i915 0000:00:02.0: enabling device (0006 -> 0007) > > i915 0000:00:02.0: vgaarb: deactivate vga console > > i915 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=3Dio+mem,dec= odes=3Dio+mem:owns=3Dmem > > i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/skl_dmc_ver= 1_27.bin (v1.27) > > [drm] Initialized i915 1.6.0 20201103 for 0000:00:02.0 on minor 1 > > fbcon: i915drmfb (fb0) is primary device > > i915 0000:00:02.0: [drm] fb0: i915drmfb frame buffer device > > =E2=80=A6 > > memfd_create() without MFD_EXEC nor MFD_NOEXEC_SEAL, pid=3D674 'kwin_wa= yland' > > BUG: unable to handle page fault for address: ffffb422c2800000 > > #PF: supervisor write access in kernel mode > > #PF: error_code(0x0002) - not-present page > > PGD 100000067 P4D 100000067 PUD 1001df067 PMD 10d1cf067 PTE 0 > > Oops: 0002 [#1] PREEMPT SMP PTI > > CPU: 1 PID: 674 Comm: kwin_wayland Not tainted 6.5.0-pf1 #1 a6c58ff41a7= b8bb16a19f5af9e0e9bce20f9f38d > > Hardware name: LENOVO 20FAS2BM0F/20FAS2BM0F, BIOS N1CET90W (1.58 ) 11/1= 5/2022 > > RIP: 0010:gen8_ggtt_insert_entries+0xc2/0x140 [i915] > > =E2=80=A6 > > Call Trace: > > > > intel_ggtt_bind_vma+0x3e/0x60 [i915 a83fdc6539431252dba13053979a8b680a= f86836] > > i915_vma_bind+0x216/0x4b0 [i915 a83fdc6539431252dba13053979a8b680af868= 36] > > i915_vma_pin_ww+0x405/0xa80 [i915 a83fdc6539431252dba13053979a8b680af8= 6836] > > __i915_ggtt_pin+0x5a/0x130 [i915 a83fdc6539431252dba13053979a8b680af86= 836] > > i915_ggtt_pin+0x78/0x1f0 [i915 a83fdc6539431252dba13053979a8b680af8683= 6] > > __intel_context_do_pin_ww+0x312/0x700 [i915 a83fdc6539431252dba1305397= 9a8b680af86836] > > i915_gem_do_execbuffer+0xfc6/0x2720 [i915 a83fdc6539431252dba13053979a= 8b680af86836] > > i915_gem_execbuffer2_ioctl+0x111/0x260 [i915 a83fdc6539431252dba130539= 79a8b680af86836] > > drm_ioctl_kernel+0xca/0x170 > > drm_ioctl+0x30f/0x580 > > __x64_sys_ioctl+0x94/0xd0 > > do_syscall_64+0x5d/0x90 > > entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > > =E2=80=A6 > > note: kwin_wayland[674] exited with irqs disabled > >=20 > > RIP seems to translate into this: > >=20 > > $ scripts/faddr2line drivers/gpu/drm/i915/gt/intel_ggtt.o gen8_ggtt_ins= ert_entries+0xc2 > > gen8_ggtt_insert_entries+0xc2/0x150: > > writeq at /home/pf/work/devel/own/pf-kernel/linux/./arch/x86/include/as= m/io.h:99 > > (inlined by) gen8_set_pte at /home/pf/work/devel/own/pf-kernel/linux/dr= ivers/gpu/drm/i915/gt/intel_ggtt.c:257 > > (inlined by) gen8_ggtt_insert_entries at /home/pf/work/devel/own/pf-ker= nel/linux/drivers/gpu/drm/i915/gt/intel_ggtt.c:300 > >=20 > > Probably, recent PTE-related changes are relevant: > >=20 > > $ git log --oneline --no-merges v6.4..v6.5 -- drivers/gpu/drm/i915/gt/i= ntel_ggtt.c > > 3532e75dfadcf drm/i915/uc: perma-pin firmwares > > 4722e2ebe6f21 drm/i915/gt: Fix second parameter type of pre-gen8 pte_en= code callbacks > > 9275277d53248 drm/i915: use pat_index instead of cache_level > > 5e352e32aec23 drm/i915: preparation for using PAT index > > 341ad0e8e2542 drm/i915/mtl: Add PTE encode function > >=20 > > Also note Lenovo T14s laptop with TigerLake-LP GT2 [Iris Xe Graphics] (= rev 01) is not affected by this issue. > >=20 > > Full dmesg with DRM debug enabled is available in the bugreport I've re= ported earlier [1]. I'm sending this email to make the issue more visible. > >=20 > > Please help. > >=20 > > Thanks. > >=20 > > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/9256 >=20 > Matthew, >=20 > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc and = 1e0877d58b1e, and reverting those fixed the i915 crash for me. The e0b72c14= d8dc and 1e0877d58b1e commits look like just prerequisites, so I assume 0b6= 2af28f249 ("i915: convert shmem_sg_free_table() to use a folio_batch") is t= he culprit here. >=20 > Could you please check this? >=20 > Our conversation with Andrzej is available at drm-intel GitLab [1]. >=20 > Thanks. >=20 > [1] https://gitlab.freedesktop.org/drm/intel/-/issues/9256 Bagas, would you mind adding this to the regression tracker please? Thanks. =2D-=20 Oleksandr Natalenko (post-factum) --nextPart5147933.GXAFRqVoOG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEZUOOw5ESFLHZZtOKil/iNcg8M0sFAmUJoNAACgkQil/iNcg8 M0vh4xAAt1VYPW8Fr0UHrGvXeZmvGqtxzOHB2BsshvL666iQn9vyVPPz0DyOPLa+ MlrXGBuvObmjsTyYF/bPlfFACWcP0Sx3AVFD8BSJ9spDNL7DdUPEpYLcY2Q0UZTr JFJ/BcASjOr7LIUIG5hsOJY7cWIj1l796QtsSjRXr5QqEOzoqm0c24B4VTPbNyDI TEsqg3sy52OvDqvcn6EcSwltn3hrxxIUCF6bxgxselWwwmUs6NosvoC4g+rQRCaX wGB5d8DTDTt8TBK3Ye/p4l1WgnCjoWexETPOF9j46ZdsxVDYZHP7ZzFlMuZ4SeEu M3mew5MFlvCxJkVCeIzn7M35PiAr2fkHCpHpEdH0xdhNSufGk01NtCBBBeNlqYi4 xBM9cYtNGT1lUw+74XAYnkiHwlYQVYVgAV9uW2Op80zX2NYmEpt9afQfL3nmqxk/ 1S/1+x7eszn7PDW8jxzSsvZSCVYEglUHbfOT5/fp81VKh0Q9eLWrU6wOM8CHcDSe ff3hXUH8MsTHTIgYX7nzhmsiVLu5K4j3S/xIJMFWyg2G8Gs8irdfkEPQw2P0f8+5 1zAG7WMsb3CDhTOAdfmWQ5GtmxKjExbt850Ujoei5mXtG55kxLztzHEylsw5UH5p rBmQK2ApIWTLUZF7yV2Md0pT7iKZ9Y2dBseeuW0EH19nkcmEy3E= =GhwR -----END PGP SIGNATURE----- --nextPart5147933.GXAFRqVoOG--