From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F1C9EB64D7 for ; Fri, 23 Jun 2023 19:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0DA8D0002; Fri, 23 Jun 2023 15:46:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89FAF8D0001; Fri, 23 Jun 2023 15:46:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 740B98D0002; Fri, 23 Jun 2023 15:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 615E08D0001 for ; Fri, 23 Jun 2023 15:46:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3594A160B91 for ; Fri, 23 Jun 2023 19:46:08 +0000 (UTC) X-FDA: 80935043616.22.433AF77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 56AAF1A0005 for ; Fri, 23 Jun 2023 19:46:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/2GjBIh"; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687549566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7cXFIATv0cqvFDOdx2Vy9pFsZWT3roW5tnB/9pxEhg=; b=PiCWTzEQZGVIhSG4U6UnRXl7BdgWS55/3qphaPbuESkR0sDpEsOIzgrPczju3fnw4dDNOZ 2eYNKcNI9ghb0R65p+u9jt4kgQw3Kmxq6L2GTEQnfbqZZjXKFUb9f6NYhDMXE/+bBCxdEc DX7XFcHYyUTyYerEbOPuigJ2RwkvdHg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687549566; a=rsa-sha256; cv=none; b=1WZhDJ1xU/OJ/oMcoGkUad7/ckoj+nwrxcFAokAXeoncDRk2J2T4WRfG803rFmYVWqtycm mu6JOQqJjfOxBUvTFKkgMQ1m4v0wwwcZLsV02pcsl5h2uzwl+NiE0CdkP+pY5OWD3KuzKy aqyXJJKC5m2szYi2OrGcvfjhvsxy30c= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/2GjBIh"; spf=pass (imf19.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687549565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7cXFIATv0cqvFDOdx2Vy9pFsZWT3roW5tnB/9pxEhg=; b=e/2GjBIh/Y8mY838iq7EeVKizL+yu6RKp+VMg8zcDKD7jBiT8b+BowTb0JF499iX3kP/of o5MkgbB3o9ap3RBFD1CtC9cEIjLaXBMkAmHoMghMmE0Txz8OWI7PmlixYpNYrvqYqEXuiP u3YTRNkllyc/vqoyePG7AivNgtl0TQA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-tWsHGO7zMPmi0H68AQg1cg-1; Fri, 23 Jun 2023 15:46:01 -0400 X-MC-Unique: tWsHGO7zMPmi0H68AQg1cg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17FBE29AB435; Fri, 23 Jun 2023 19:45:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91DA92166B25; Fri, 23 Jun 2023 19:45:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <27fd3750-7b9c-9638-26d8-0df3f0e33b81@oracle.com> References: <27fd3750-7b9c-9638-26d8-0df3f0e33b81@oracle.com> <20230623114425.2150536-1-dhowells@redhat.com> <20230623114425.2150536-12-dhowells@redhat.com> To: Mike Christie Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lee Duncan , Chris Leech , Maurizio Lombardi , "James E.J. Bottomley" , "Martin K. Petersen" , Al Viro , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Dimitri KRAVTCHUK Subject: Re: [PATCH net-next v4 11/15] iscsi: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2611149.1687549556.1@warthog.procyon.org.uk> Date: Fri, 23 Jun 2023 20:45:56 +0100 Message-ID: <2611150.1687549556@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: 56AAF1A0005 X-Rspam-User: X-Stat-Signature: kf37u3dwqmnii3sy9f991atx83j73tgj X-Rspamd-Server: rspam03 X-HE-Tag: 1687549566-720688 X-HE-Meta: U2FsdGVkX1+3he+Q6egJBfp6Va7V5EPdhMkOYz/aENO0hY6gFZYs33ebwDA71GvWKqCr3tWX2JfMgrBP0PKYBsfkwIwTFjAhjOQnES23AiHKlB4oUfO5gcTaMqw9Ks/EqO5nHz0YRgwU08ThTsIGxtYgSiLzbGfvRXTn28ZbjleJw1tuqL1yEYMpx62XdEjW9x6lr4zVQIQjwk2OCWc5AwkVItS3B5/JNcmeAUjDFaaxvGacGWBRRbG5cuuaovZcP6qj2Yy7mfJaZsg97UaZiuMBeLia+0dxiohgPZmLYeqPAqL58wCEm9CcCR8qywcnKkeFgRiE+B6aYavkaUXE3O/zrYzuNZYmnoz+d7JjwZuL6qITTG2F+amrrcDq9tjDk/TnRS+r/Crj+AW/DhpFXDPoa3vkG1Ca0FxnnjQnn2eJg1/vZPphMfL7vwU1o2NXiPa/ttxWChan5yqA3RKxzqeiW7cxi35TF7OxRdnR9ReW697HwXI0u9UHWi5J3ToKcJAI+XTGpATOOPv/e731WgWLDI95d4OREO3tH6ZCfvqQc1SCwspTMX7PfHJb6agRFjawNaTmOnR2J2Ohuf0+iFrQIVaZr6oG/jH4Vt2ct5wFH2+efm9cDJ0I8u6EU5xIzfxiT/4YUE1+ELForx0wzBHet8sfN7jzupcRp6nElGlwEbz3MxL7o5DVRpEjr1VAVtCnD7sY7Ng5+6WIMQxyH3JQfWWMMb58DwFm3cJPoou5u/BFvdsQAS77MOmge48pvDvlX0e5hbynO/bdsrZON4XTaX00yCH/UNjN6mX2/xgZxN3m/g8ccGo+UCpXKHWo2P9Pi0tUkKRgf2Kt9xKLzJEzhuu3MvD0mciR1NKstF6hw6uhVEehSf+w603heQ3O4JBZRjTwkbSfuh3n6x+UTkthrXBi66KthGyz7GGm1lz2URXOjPp8iU9OXZ/9ooC5JolzipO+sxuPmTdvnvw RfGePu9g Ry9c0bbBX5+a80X/kXWFVHJsQJS3l+1Ic7YttSnR9+ubNUc4rvMuI+ghpULUsjb8gPB8ulojdZAXrpjFUu9Jf6gQn0h8SEyPZdqy/g7mlLwO32J/3UetHEbV/Notk0QRyTvleED0Q445u+REMmksb+cARQzB9TUyGX3X/j+QZ9ILAEeRbHPadurfGdSW7NmFWE3n0xrwRCZTPXVDSN6ljGbA6C9quPJzAD8VCKhUjOFvN8OtoMykls6MhdHpYclMqrrEiSQ1BzwXeH4H1qyVqq4phQ+ps8wtvSKonN6P6oifJVqBV9ydOQRXnXDyh3u3MRmQQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mike Christie wrote: > > One question on the target part I had is about the TODO above. Is that > something you were going to do, or is it something you are asking the target > people to do? I've got an in-progress patch for that, but it's not the simplest code to modify. I'm holding off on completing it till the simpler cleanup is in. I might end up having to push the incomplete patch your way to ask for advice on how to complete it. David