From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A23EB64D7 for ; Fri, 23 Jun 2023 19:43:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC2A58D0002; Fri, 23 Jun 2023 15:43:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C71498D0001; Fri, 23 Jun 2023 15:43:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38B58D0002; Fri, 23 Jun 2023 15:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A8D3E8D0001 for ; Fri, 23 Jun 2023 15:43:58 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 873DC1C8F78 for ; Fri, 23 Jun 2023 19:43:58 +0000 (UTC) X-FDA: 80935038156.12.355D4C1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 57CFD40009 for ; Fri, 23 Jun 2023 19:43:56 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ChUS6xJT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687549436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BybjfG9PIBiqP0H/EMXr01t+EtZxTWT+jQSFanPQg3I=; b=dCordd+qVD5LG8UFvD6cSkMgeOcBVjC5RPbsVn6anYo06N11dsEY+vzwToZI9gol8wl+j/ 6Au5zNWBVoaMvP1r1Hs4f25J1NyKZCLsASMQMp58qkhxiAS3scJSEvl6ET2E04lPWRGu5M wp311zTai6V5H4BkEa6h6+CVqg7PqFM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ChUS6xJT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687549436; a=rsa-sha256; cv=none; b=EYrczJHBiSczzYQsh7nungqtUA7Ak2KLB4btQYqYdQdI46A4KPQCd6U3Odm7VOsalYPZ+3 RK09yqyKTGfm0mPbkvWOieVaDySCnh7PHnnfirlRWoCJbP8MrMR+QQ1JUQKCt3BNRjWdwN DRnP8VImf7rW2U155Vo12+TcdgwemYQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687549435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BybjfG9PIBiqP0H/EMXr01t+EtZxTWT+jQSFanPQg3I=; b=ChUS6xJTvl2DdiGyK+goNWMGQaoO1isQZinj5C2p7XP1Ehh2nbA16AZk0lp0Srr6PLjGIl Oqa3pWzOkKsun9HOoduisZC7TqSHgHbjSaXkzlUUqgQ1vS3nksiuSEC/eiktUUTr3dKpLs +Rd5TMZuBZInHw77k57Hkw45ZcZaQ3U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-124-QaxqV_GGPc-UL_KKq1DTLg-1; Fri, 23 Jun 2023 15:43:46 -0400 X-MC-Unique: QaxqV_GGPc-UL_KKq1DTLg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9BDBF835262; Fri, 23 Jun 2023 19:43:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF0B4207B2BC; Fri, 23 Jun 2023 19:43:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230623100040.4ebbeeb2@kernel.org> References: <20230623100040.4ebbeeb2@kernel.org> <20230623114425.2150536-1-dhowells@redhat.com> <20230623114425.2150536-4-dhowells@redhat.com> To: Jakub Kicinski , Ilya Dryomov , Xiubo Li Cc: dhowells@redhat.com, netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Layton , ceph-devel@vger.kernel.org Subject: Re: [PATCH net-next v4 03/15] ceph: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2611114.1687549406.1@warthog.procyon.org.uk> Date: Fri, 23 Jun 2023 20:43:26 +0100 Message-ID: <2611115.1687549406@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspamd-Queue-Id: 57CFD40009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: oxx3zrejkfn5umscofw8ad8euicjom6p X-HE-Tag: 1687549436-77872 X-HE-Meta: U2FsdGVkX19/YfB6f89ZahSL6NF21wXJBrHvbd2TQ5NMI3P/En7JNYGtdnUloVMvAsRZw+modpr0zD8mqmJ+ETxv4GyL/Q/+tKTIe6BlJCtQC1Z7VtpZxZmTxWfD++BJ2a3y33LtQx8s5Wj941QiboM9ujv2joo+ni8Vu6PqaLDnEsV3biFyCe68bpYDyM33g67phg88cegl6j0leaV2O6ZvtIXuQYon1pKfNrv+RFs0TIhwj9b72WSAzNxbg/R1ja5OmQvpukyTHIjxl5sqM/o04SRQ9B0HIR6ovniQAMbZsKg1N8WLP4WNHzDB1a3KuC/7J+xMGHuJ3asCmA42eCTzqzHH8monyEty5qImbqSpJevMhC6Sg6V8GbfWAY7GmI1kQmU2hBhFSoFJB3K7Vn9IBnIidVuHzCaVa0e8GtnDZsdscOzoEvq/+XMtEe6cz5KQTSOI3BPs0ONGNooChuE4Hqxga5IB+42rXGcss2zg6Foq6h8S114ktM3s/HwqOrzU8r32FiISr/DrxWUycMcM5UJ21JJBd9KtAP1QR/sYUrL16hEHvbj9DKffjtHBOonfOMqZyYW7VhlzovXkTy9jvayZDnw8SHYLWlvlbO095betc7yRI3M3Ava9Sskx0eZFPG4unfnd/Feo+u0o9EhxSBrvjVjbyqS/ISvy6M+C157HBoEEfahKet2nN0+MQKkQ6Hyg0fXRdtkFiBMKW33s7CkUbDFrL80+rZICtUFynukuxAZMtJJRbFn3+Ymda18ndKJRV6kVytWZo/Z70SaDc5680UrKr3BH8DH/WM8MzniXFN07NB9LsrEh6yYM6BUsMwZxQUGp5WpUQOse6HHb1yiD9pAFVM9Q66bBm+DGdzOsdTSYQ3OJ/ca98oVBCI9wXK/FUcha5i+BXCJ53VHgwDOY//nSE4Mx97IdESKwt3VotSdUirwdNyQphN5XAa39oafg1Qhxfz2/4N0 VekBt2iX mffEmoLxKFQad8EGqITdhJNi5YBRMBH9Qd8afBGbH0P6NxjZJ5cJ20Jj8KrG9hYJSgBb90vrrtT2hXLkjW20UttJ0rLfgTKzkLLb2ZFT/yDYctT7vrMC03CTmQG6WQAfpdZQEFtuKhpi8F9JyUzGUW/5ZVOKGk/W4NSXlWRFv4JKYbAnEGcsumb+Tlc/8wf/Z4OlvHsiKmi1Hj3A6dkuxuADY8/dXOVNMqlZjlyJB/iIC2KaCweV3sQmAyyZRdJdFrNL3aq+y5XnTIqOVx2snhAvwF44aXU0iegvCz2L8kGTX56xPO1z25ScFb/2odcrorglyeOQpO3omwTg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jakub Kicinski wrote: > > if (length == cursor->total_resid) > > - more = MSG_MORE; > > - ret = ceph_tcp_sendpage(con->sock, page, page_offset, length, > > - more); > > + msghdr.msg_flags |= MSG_MORE; > > Should the condition also be flipped here, like you did below? > (can be a follow up if so) Yeah - the "==" in the if-statement needs flipping to "!=". I can send a follow-up patch for it or respin if you prefer. David