From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91FD6C47073 for ; Wed, 10 Jan 2024 17:25:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4A906B008C; Wed, 10 Jan 2024 12:25:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FA366B0092; Wed, 10 Jan 2024 12:25:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C23A6B0093; Wed, 10 Jan 2024 12:25:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 79FF26B008C for ; Wed, 10 Jan 2024 12:25:25 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 242C712058E for ; Wed, 10 Jan 2024 17:25:25 +0000 (UTC) X-FDA: 81664077810.11.DFACCE8 Received: from mail.stoffel.org (mail.stoffel.org [172.104.24.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 97BAF10004D for ; Wed, 10 Jan 2024 17:25:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=stoffel.org; spf=pass (imf05.hostedemail.com: domain of john@stoffel.org designates 172.104.24.175 as permitted sender) smtp.mailfrom=john@stoffel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704907510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IekxBvl4GzXpFxV1vIvwGpgw1AZ0DwMNq4Ckjy6RaQg=; b=b2dNMdAI5EUKQHH+07cPDUDcfHuF5MIHfJAw78lKw4Rj0vZYpYmxYDOKD/wjlUcJSz3hbY DOaWOKnZpQGcCYXpboedHy4ZL6RPW3v7HlA1SH65IGKxZw89KU+NJh0lYtdpg3Aaz+E2FV iyni8bYBMLQbdo1ZNZPD5i+51SyLjLA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=stoffel.org; spf=pass (imf05.hostedemail.com: domain of john@stoffel.org designates 172.104.24.175 as permitted sender) smtp.mailfrom=john@stoffel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704907510; a=rsa-sha256; cv=none; b=XAGtBYi3vC2C7LMIyvqu4YJsBy7NO28+nItJ2yaj9BvZXt1WGE2OMGOHu0KNLsuIWWbpln lFuTbmKhhTt9LTIxHwzk93LXhqdVBneK12dyfZYPVEu4PHxoxlEE79Q7yzPNTrbgHx9/J0 yI1Ay+LUOHd+yTzFVIC6JG2KB7FkIY4= Received: from quad.stoffel.org (097-095-183-072.res.spectrum.com [97.95.183.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.stoffel.org (Postfix) with ESMTPSA id 17DD91E12E; Wed, 10 Jan 2024 12:25:07 -0500 (EST) Received: by quad.stoffel.org (Postfix, from userid 1000) id A9991A8E30; Wed, 10 Jan 2024 12:25:06 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <26014.54002.663705.978220@quad.stoffel.home> Date: Wed, 10 Jan 2024 12:25:06 -0500 From: "John Stoffel" To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] netfs: Don't use certain internal folio_*() functions In-Reply-To: <20240109180117.1669008-2-dhowells@redhat.com> References: <20240109180117.1669008-1-dhowells@redhat.com> <20240109180117.1669008-2-dhowells@redhat.com> X-Mailer: VM 8.2.0b under 28.2 (x86_64-pc-linux-gnu) X-Rspam-User: X-Stat-Signature: 4jo4knyrwo4psfk75ktsshd71dcgw7qu X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97BAF10004D X-HE-Tag: 1704907509-579763 X-HE-Meta: U2FsdGVkX18mD8LHKp1YLEEk7ASKE5qokBV9gdVZ+PvxYe3RIWKwjSeWrQdStloEv3+EgOzehmCw46yUOmiZBrahCH6O2dMhQQlrhV6U7GNu2tUxrSYqvrRhA6mbMj+vB7ZjFRVNjZAFWbfcrM14Y2oNx7Hqz9yYJbnQUUcnJajtDp1dHyxEKZUyjIG/V3NSwJ/R+chsj9swRC1DnkdnOX8kHTKqsYqeSBQGxf0s7N6ikbutYDb8W5HfBwMHEkrtmJ21C/+hs9lkUEVZH5JxHNA00vTwmfrzCmc7d5N/jZ37km8dnLVicWzFLC1++wf5ebtcfZbrJZgOPd9Ybd+9e95m0pSRkWrI9rGENTy0DqO0Ykj6NCGgwKyKD7FS7bVt+D2vxYNUvXq5IeK0sgJmbzgYPjnWEge26sj139ARshUSIQmnxzuKLhOP6yK11BLmn/geaAT/O92oY7DiVdRcBMUcNKaOPDk5uaijO3xSyc82obbRO8blDMX1qeTPedmPeG2EHfPI+y96YjQPBoAxZX+2iffP0kueZB/eg6gqdQA9OGIJUaOK42DgDBHNSpLrgkBttQ1j3lNOXrnVNOkpAvfeeqs4WSnTUjHB2oYZWRZPUY7bQXaW2+eNxBtZiY0oJYSWbZWyT1QBEkojcx79uTCazDjMGUYembwIUi0V6D8GT/rbsIe9G/h8Ckkd9lSTm5H2IcYLruox3bx5a4MZR5QckoHNh6jBize+NUf1Wd/bOpa/K2CgJM6ventFlbKNM/820O42zSWrq9SUxI57gO+ukAasdsnKfftViF5AVibpdPWq0xCFuw+CFXzPVV2aoPXHICP5ILVCMUz8qJf1F92XHkJoJJDhFuyHqWcaHBQSeKGzwpFKBu0OMAbmB7YhYue97M5hJAbXjF8hx85vlOmRRjLcvANaua1Jk3BrsR1/eLQA22m6eGpqSpM0gt516GqEjcydEKZRLew2oty HjbuzceD AjM2tEaG05oVyj7/jmxwwG7qgVJ6v9Fyr2TYglrvsQBcDj5ffQ781G1ZKR3Jv/qwgXDA1YYB/25KoTfRFnM3gJyhLqpCO4XNinzx369OITiM65Cdyf+C2hv6Wj7Likm7kX1EM998ljhYWES8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>>> "David" == David Howells writes: > Filesystems should not be using folio->index not folio_index(folio) ^^^ I think you have an extra 'not' in all four patch comments. > and folio-> mapping, not folio_mapping() or folio_file_mapping() in > filesystem code.