From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F2ED5CC9A for ; Wed, 30 Oct 2024 11:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42D6A6B0093; Wed, 30 Oct 2024 07:28:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E5506B00AA; Wed, 30 Oct 2024 07:28:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 255336B00AC; Wed, 30 Oct 2024 07:28:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 011646B0093 for ; Wed, 30 Oct 2024 07:28:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 784BE809E3 for ; Wed, 30 Oct 2024 11:28:43 +0000 (UTC) X-FDA: 82730044866.13.3392577 Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) by imf15.hostedemail.com (Postfix) with ESMTP id 28DC8A002E for ; Wed, 30 Oct 2024 11:28:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b="u/6VJLcR"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="A qQJFqY"; spf=pass (imf15.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.154 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730287640; a=rsa-sha256; cv=none; b=osDHdD9rsOSkChMO78AX6KzgBE/030tgRfzVTnA/X73baB+EqXCSAn9GGaZEcLdy2nDtMQ YgoNk8T87onZJeUf9ZOQMlD0fWk37JHefawNQHLwb5nDHIvqVKikGZ6IfH/Yz7uKjtbU6s nGWNluxYMjEYyP2sdmRdtvTmhobjuUI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm2 header.b="u/6VJLcR"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="A qQJFqY"; spf=pass (imf15.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.154 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730287640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YhdUNtgLpwlg0s7fFfw2y8g0iLgCT7JGX061N6SrdjU=; b=xM3N+9B4fObAErlYBM8dkKu44BlkK2qTlIk1Qkjw9rXNJneHZIKa50MKJICqnIkWgsSRJH Z7JYP93kC/jjeLLZgwK62ehUU5tZTfVzjg7IBFolrLfsLd80REYE0j47PZNiUwxyFxfsTE kDH3ceLk/+/4PXmxx29whNJ+Yk2iQeo= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8228411401EA; Wed, 30 Oct 2024 07:28:40 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Wed, 30 Oct 2024 07:28:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1730287720; x=1730374120; bh=YhdUNtgLpwlg0s7fFfw2y8g0iLgCT7JGX061N6SrdjU=; b= u/6VJLcRRNo/+OSfY+kpkg/FmR1ARNp93AYbiPfqNiL0ys9ZF9aFi/jdQjisQDg7 clirLI75K9h/XjPuR/33VyFzT/BXXVEjZfG1wYuLAna4bJLfw5CS4o+mNLsmjZLW Myj+yikY5qsqaolTG1VwVEC+jXvBu6Li0BvD52hLJrZWQysys+6DFhHR1YMMXx8a ZcdjEDnfG0sgAZxwPOD3G1tr2DY+WWeOYpVN+crVsAz5fjvODaewPMBcdwxamyp4 QzUw7cQvze7sVRy5BmvjsoyoADcCMaszswO3gI17zPIMJ8gaeowEZ/4F2fmvgZbK gdG805KW/fp+0nYwZatX4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1730287720; x= 1730374120; bh=YhdUNtgLpwlg0s7fFfw2y8g0iLgCT7JGX061N6SrdjU=; b=A qQJFqYh9Yj/0EUyoycEfGx9/vSFzvVkG5WcDQnWIyvhx9fvnxreI3DmGUqO3hT+Q OdmhkkNBFkD4cq05iFJyDAg7Lrro37L2lazu3r0yfoQ5SrF3RS/28KQJ1BrgnOTa sWb44fY5quMUnmE4lQ/Ppb6iAKkQbJhE0CefhfeOhJWoPVBmJLdaaLtw8vCbv4I4 RB8PJDc3XT/oDVA12NBKTIinTyuuZx0cB2WLXCeAJp4RJJfk2V5IpSR6fysd3zbX hJ4foCVreDM2sKrnkClwNEWVtGtmm7AQJVFhzUCecyuNVE4G/bEDPTmqVNF8mqYl K1pXM794hwxb84Ia7S28g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekfedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhepfefhheetffduvdfgieeghfejtedvkeetkeejfeek keelffejteevvdeghffhiefhnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghr nhgusgdruggvpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtph htthhopehjthhhohhughhhthhonhesghhoohhglhgvrdgtohhmpdhrtghpthhtohephihu iihhrghosehgohhoghhlvgdrtghomhdprhgtphhtthhopehlkhhpsehinhhtvghlrdgtoh hmpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtohep rghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopehovg dqkhgsuhhilhguqdgrlhhlsehlihhsthhsrdhlihhnuhigrdguvghv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id E48592220071; Wed, 30 Oct 2024 07:28:39 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Wed, 30 Oct 2024 11:28:18 +0000 From: "Arnd Bergmann" To: "James Houghton" , "Andrew Morton" Cc: "kernel test robot" , linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev, "Yu Zhao" Message-Id: <25faaaf4-d2c3-4dc0-86d4-55dd25568c12@app.fastmail.com> In-Reply-To: <20241025192106.957236-1-jthoughton@google.com> References: <202410252141.djLwbAYF-lkp@intel.com> <20241025192106.957236-1-jthoughton@google.com> Subject: Re: [linux-next:pending-fixes 301/373] mm/vmscan.c:3498: undefined reference to `pmdp_test_and_clear_young' Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Stat-Signature: qsbqkrofbkawxbtmugw5kcrusksqei1h X-Rspamd-Queue-Id: 28DC8A002E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730287694-237127 X-HE-Meta: U2FsdGVkX18aDAfATjHRrBiMNmisiX7IG7uOVG4Tt4HU37RRVZrS/QSCy/WqWLqGg2lMpqp2vbeGVjPEO8Ho31DmtNeMTGXnxLlYeDDRy5xIeA+j5SbPam9N9E8En6lE03n40APsmD3Ex0s3VEGKT2OSq6pQ9GKhQJ1eJSUUGQ3+VpSER274onMSaj+Qg/IiGtU3WYxsdCa7WU3ko345+7h8S5+0xt5/IopEP1KWN975Ky7ztHoHaFuRD6Uiyvd3iWfp7uITMkIB9sV+Kv0gCS0PSR9v49CP7URhLeNX/Ha5nQMVuQ0m71nYVDqxBFUMuTj1YG/OelgBcgF6aBxsH2+vlvjZOaFf1gyIFPCXwvcCO1vnMwa6+gcWrYrkFFOppVj+WE/wJmSTDg1+b65/JzAabP0K5pEie9gGZ/0F1DUxtmNBvnFO/7tmJ1zE979OpApO0OpOqlhjZa8poUCIqM6RZe9CGw1QAb9cMwP2smzPsfzLX3xHeRhvpOvGmxZ4ucQevQkTW/EfYAHJseXsKuC8ZiF5/0pbheWDTqopKGVoHoXCFn2KdwgVDEMC4dsXlr9KatW7cGFSVlOt889sXKlG3cDz5EUanm/hNfcBfRvGMGqnFWNaml9SbUjw25GL2yDk4aVRgbrPdp9HjFQxvIRop8AreuSnUGjPlKK1U8NhWdtx18nlzX+toLxkEVms4Xa3BRYaNCk+ymilU+BEFGTbt+s5/E1Zdh3MQ17fG8BHyEMVcEYUReHdXB4lvZiKdaKIWmkMSTuu1pHO5d0KoGUbEvMIgNuys7IeKkhJH23umv6a/p59ovXiT/gduzaV2W6SYWX0S2O+OhvVyMwZsEgh4eY8iF0kvHcQhH3mSeouyw/a4GVpI5zHOa2IxK4fDwlhPrioeicwkJb46CXOANZqIGvrf0AtZEpQztEdSUv93RfW8WPvVRIbwMEQBUyMQzj8cmUxet/kkIqBe0S HUEEhjS5 ZJW6jv20zMQli7HHTpKA0fLNl4p1QeJK85NK9Rt/8iamebAAyxEZN5hhFY1k2tInfsBNDnFLDdFJ461ZUpUnH42NJsxedrTFgvuNU9ObI1vuVl2wjWNHGQ/WWZk/pXhKzrlJrZ7WpgH6ZQeVk027ImZvTm/VeBdL3DNBRAHb8Wp6YggOmzQsoVcjptYVzej9L4KfZD4awbj/J+5l8Yp2a7uV1/Ud+qcSxy2pzdWZiJof2k5zx0lfwXei1o0+SVR7FAPNddJbFPUXPJhxAQFNe2e6kDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024, at 19:21, James Houghton wrote: > Hi Andrew, > > The following diff applied to the second patch[1] fixes this error. The > diff is functionally a no-op; the get_pmd_pfn() immediately following > the code here would return -1 in the !pmd_present() case. > > I can send a brand new patch if you'd prefer. > > [1]: > https://lore.kernel.org/linux-mm/20241019012940.3656292-3-jthoughton@google.com/ I ran into another problem with the build failure below, and found that your fixup address this as well. Arnd In file included from : In function 'pmdp_test_and_clear_young', inlined from 'walk_pmd_range_locked.constprop.isra' at mm/vmscan.c:3504:8: include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_401' declared with attribute error: BUILD_BUG failed 517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:498:25: note: in definition of macro '__compiletime_assert' 498 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:517:9: note: in expansion of macro '_compiletime_assert' 517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ include/linux/pgtable.h:383:9: note: in expansion of macro 'BUILD_BUG' 383 | BUILD_BUG(); | ^~~~~~~~~