From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9814AC4829A for ; Tue, 13 Feb 2024 14:56:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B4F46B0078; Tue, 13 Feb 2024 09:56:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 064F46B007B; Tue, 13 Feb 2024 09:56:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E20AD6B0082; Tue, 13 Feb 2024 09:56:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CE04A6B0078 for ; Tue, 13 Feb 2024 09:56:20 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9E799C0B7A for ; Tue, 13 Feb 2024 14:56:20 +0000 (UTC) X-FDA: 81787081320.17.188DE98 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 2C0D1A0025 for ; Tue, 13 Feb 2024 14:56:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DiHQcjrL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+mPykfoK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DiHQcjrL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+mPykfoK; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707836178; a=rsa-sha256; cv=none; b=k6DWORhF/I+DLesxfreAS0hsxpmBDWlaUCAs1xXycEHE5KObPZxMRsiOEM2wa6nz3rGSEP 4fQ4/F+4yMWqFQ3FZ57yi6qWGgWYfgovMsoJYPQIdNgt6pl25P7BB4KLz0tGp8FR++X7Qd O7iiNOnfkGadIZMOjkoqXfnz1l7bJDg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DiHQcjrL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+mPykfoK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=DiHQcjrL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+mPykfoK; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707836178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b1g8t9w8mOs8leh8n6Zjz85Vov4skANTzgCxAT47VW0=; b=nqdU8381dVGm3dhpuuqyT3P1odHgcABL3JXVVP+ZUvR4yBZF8DEUD2KjZBuE4oeOPHrm9p We/0tIcb8TaAwMiZm8mCxUnAlBl3cxd4KqFuV0t88bW74xELIV8kmVzf42JE/ZFxHS7Yxn 713tv83wZPm7uOL6ahDhrwa9gPFiRIg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AE9F02119E; Tue, 13 Feb 2024 14:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707836174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1g8t9w8mOs8leh8n6Zjz85Vov4skANTzgCxAT47VW0=; b=DiHQcjrLMK4mx/z9/bYB1uFVaOrPXM8EddspOekZxMPHk2kaJdCL0HK/Qe2XZO9QP5ljq9 TereFf2D89nesaacLczgf9TuVDR/GHgWiovoUgePENsL7y7MzrPMBCo88dKA2HKN/VlEKU nuPn0/kwSaeBL2EGdiFrN1FEI6FQhYg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707836174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1g8t9w8mOs8leh8n6Zjz85Vov4skANTzgCxAT47VW0=; b=+mPykfoKC8L5Bcg7+bmgSCgnijof1TmVnYhh55toN4x7bECyoMYK31BfGyVW85Zi4k25SW B7AShECFZo0afEBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707836174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1g8t9w8mOs8leh8n6Zjz85Vov4skANTzgCxAT47VW0=; b=DiHQcjrLMK4mx/z9/bYB1uFVaOrPXM8EddspOekZxMPHk2kaJdCL0HK/Qe2XZO9QP5ljq9 TereFf2D89nesaacLczgf9TuVDR/GHgWiovoUgePENsL7y7MzrPMBCo88dKA2HKN/VlEKU nuPn0/kwSaeBL2EGdiFrN1FEI6FQhYg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707836174; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1g8t9w8mOs8leh8n6Zjz85Vov4skANTzgCxAT47VW0=; b=+mPykfoKC8L5Bcg7+bmgSCgnijof1TmVnYhh55toN4x7bECyoMYK31BfGyVW85Zi4k25SW B7AShECFZo0afEBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9C9C513404; Tue, 13 Feb 2024 14:56:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2JnqJQ6Dy2WSMgAAD6G6ig (envelope-from ); Tue, 13 Feb 2024 14:56:14 +0000 Message-ID: <25f8fa78-53e1-4b53-a70b-6b758d671452@suse.cz> Date: Tue, 13 Feb 2024 15:56:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 4/5] mm,page_owner: Filter out stacks by a threshold Content-Language: en-US To: Oscar Salvador , Marco Elver Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Andrey Konovalov , Alexander Potapenko References: <20240212223029.30769-1-osalvador@suse.de> <20240212223029.30769-5-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2C0D1A0025 X-Stat-Signature: os7qenu8ecsc185uyai9q5fz913dgon3 X-HE-Tag: 1707836177-85534 X-HE-Meta: U2FsdGVkX1+6upmLDb5GVqLLw2UsMf97DKDUJbkyUAFRI8v+rnBI+DopoYgDOlbyZ0qbNHdonXFrVY198HHe327EHjGIgwdmZq5F4cQk1dl5w4D+1Ib1054+Bhl725SohWYFr3EGGQmDqMteQ5NZ4lPCLFnA+dZZVEWTzm7CDHafmWy/qSBGESTKR1+O0rPsgXAkKLLBO2qoJ4omthg/Qnr/lKBbmIUrZD26wQo7QpAH1DbvJgGzIMsvWnfbxZW+atN4o+WFlOg8hVSK9hesfeV+eP5m7bAcxViIPErCI1wMsN3zAjWrh3EtHHKtRzWUTspNKho7yK4PWoEG7Asn4iuuuNnCGT8GRqhKW8oMsq1NyJCmERRygCEFDyiO4B/Q302TxfTim7o1TfgEZRTI2euYnr+w9zT/r+QxfbG3kjLZP1MV0yYnuszdKz1EhJk6KbGKHVHeZ+RtmzUvWtMnrADooYwVMqXJ+iTh24v3Mu3t4oAgSlLHXUZKbMQ3OcKxHt5rLMbZBRnqjZtGSYk04eog5IAP7Pkw3VPdKBkER1JMjndvjtuFeqTGWsTmd7uhsxtyeQM6LVUCGDrjzc/nL7y0tHDpamsB1nv4sw6ZAJtq2bqobbCra6QJdMxG+aUC4Uz8VTc+mjWVbR8Vr7EcC7ixKK+juluY5caOle4n2gCOb5YhzDORF4s9mRe+dIqpIQTaAksmjzF1WZvVnzrwdbLWOO0wx5fx5sCF2uq8yv8aKouA3dLzkGK019K0X7ZYKv+OUd5z+IGYQ81CbLRH92Onn6t2k8H8lB6g72p79tHOJZtTvkVTHuj9L5qoOmkQNFPo55YMjePv1OtUMSlJSxBMN0At1qjXtNks/H7taDAU147Gn+Nh5RUesu41VRN5ddfYF2oSqc17VFk7MnDrKtUZfUEDPPx1MqL/2v5wDJ/njPnQAUfUp/1CDRl3mTOIEZDHGr0+FnKexyO2r20 OyykzoFS LLY5rBkfTWYI+bjCpk1APXdaNXWNW427bR0Af5z93KQerdz05OICIoWCX+YPwaIDhBk9VgTrTQYwUf1ta1Di+Zv1mn2V0pB6+wjhx0ZkmJ9RVuf4sqhQiDgcRDroQr1lKkEwWtTmMVI+jsr1ZfXhYNraR+krK/SSjdod63AYq3ODCej9WXVGAWX0/ybYkMwBhFqFAPxkUmJUDxdRh8Ltkfu/flGIZcmv7Em9Qd4d7K6XO0aqj1wibucFiSGpq/k2TgoJKIPeW7atxcAbB6LQVL9WY0Nbf0TH0L0t2LKH8hlFhCGwcK4tkZQSVNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000487, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/24 10:21, Oscar Salvador wrote: > On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote: >> On Mon, 12 Feb 2024 at 23:29, Oscar Salvador >> wrote: >>> + debugfs_create_file("set_threshold", 0600, dir, NULL, + >>> &proc_page_owner_threshold); >> >> Can't you also read from "set_threshold", so the name "set_threshold" >> is misleading. Why not just "threshold"? > > Yes, it can also be read. I guess I was too focused on the set part. Maybe name it "count_threshold" so it's more clear of whate exactly it's the threshold of? > I will rename that one, plus add the {READ,WRITE}_ONCE. > > Thanks! >