From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DA3C369DC for ; Tue, 29 Apr 2025 09:19:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43D2B6B0006; Tue, 29 Apr 2025 05:19:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BF8D6B0012; Tue, 29 Apr 2025 05:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 216F76B0022; Tue, 29 Apr 2025 05:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 008DA6B0006 for ; Tue, 29 Apr 2025 05:19:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C7804C6B1A for ; Tue, 29 Apr 2025 09:19:38 +0000 (UTC) X-FDA: 83386533636.18.0DB7B15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 55980160006 for ; Tue, 29 Apr 2025 09:19:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DESTQ1tA; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745918376; a=rsa-sha256; cv=none; b=PJQu2WvJYjrAte4mmQNfexNDbj9snoxSmobhWuAN3XeARFN2YWC1Sh7lUYIt+Z8ijsXWXZ KhYnSULcrM3q2SPS4rU9JsGwZe4G2EwmjbVkUF/30H2phFXnwxi6SOJdmk+XtSc3lihJMF ikfaUdGGa81e/VojBYhZAwZnXyb3kbc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DESTQ1tA; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745918376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ntwleF0FJ9CC762cUGTggs8PS8FomkuxI5oL0NEGw1s=; b=AwIxp160l9iROLoLuVaUvsTKIXK+YHVEY18jrWRHqCKz/xM8aJXreQQdVJh/xs7MXswxi8 zJDkp4O1HdDlqy8jo2ZWAGd3EoGTjmWzL+vlUPmjLzhgKKzok/Nqu9closC/c6s7nsp8Bb /3XTHNMjiWowp1ZsHzluXm+sBo+03P0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745918375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ntwleF0FJ9CC762cUGTggs8PS8FomkuxI5oL0NEGw1s=; b=DESTQ1tAkeCewXF1hhuuK99sC1cVydwuty6bu7MjjiCs+y/vAwhV1838jOg/kokQJy0ZuX cMSeXJExg8xg1tqvgxPDsJ9IFpN6QupxUprG/RkeaboHPf9p4una+9oDAZ71wooDXvLi3n r/UY+S6yYrfTc0ZhCcTu45XeRgvftfs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-KpzeTYhQMEegYMp7WEN3Gw-1; Tue, 29 Apr 2025 05:19:33 -0400 X-MC-Unique: KpzeTYhQMEegYMp7WEN3Gw-1 X-Mimecast-MFC-AGG-ID: KpzeTYhQMEegYMp7WEN3Gw_1745918372 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39ac9b0cb6aso2405835f8f.2 for ; Tue, 29 Apr 2025 02:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745918372; x=1746523172; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ntwleF0FJ9CC762cUGTggs8PS8FomkuxI5oL0NEGw1s=; b=pbWp3Tn1zU/aTUF0h13dMEC7b337xaY/X5/7N1+elOEBKQ0ja/qAy2B7Y6+rMaEAL4 H+eU57RzbrNSTSTn1ncdXRslkFETfpdQDpvzGJ7GxHEK6WIhyHP5thImgtoUxcjhVB9R xUlGBPMXZOc+pv+i6nTPcSmf15WpJ2HZP5IRnL0mDtpokf/rF2JqdJLdYez7dF9E+0oE Oa3z34PUc9f14ckel+r4tIQ6FHlIteLas/DmP4qtg+C3+EWPP+6D30eFdrpfFrJD0t/S Qu1ts/WGQiuN8VTQqryei6f8iFHztHYr080KXOpQk9iaO8S5WdKEHlMpTGpErCnS3iah SSeg== X-Forwarded-Encrypted: i=1; AJvYcCXe3zXCjGJ6nm5y9V6q8vVrAN/0I8s42mthpsJm9a6jrlSwlVxbY4WI9qjjs6SxDWpoIE/S7i3HJA==@kvack.org X-Gm-Message-State: AOJu0YxICteiRfhVU+VojgGST7VegwnaJi7B9Jty6Xz/mcgUCU7mVpAx Z0P3hHpMIffa2DIzqhy73wT0SzGTQklzPJJzh4BEIvvXgF1/yMflX972J2qaYsjw01inJG9zTWC rONvDcfy0DZWSGdL7WGx0XGPeTyvqA9dC0ALQViAgyUArzC/q X-Gm-Gg: ASbGnctD6IzdB3K/qBeqOe2ikwcsTwOA9zMSWvU6uHdrymyEOnfTHcq+5nNR6A7L9Yx GSPFbaX5hHt9JYZZSe2ae1laKlanJHaQVpizb63Net4ec3/gAFqk5Vg5wn/T4fsVAZUzH3AFXee eGbahDl+r5vGHusL2bzaLccIn1DkAqV7DbEV9GF2FalDO6aM2Oq/Xbw5kWg7fbspcbtyn3VAvIJ EcGw8TgIZquOHBtgtzZxHIpEcOvcTQM68rFg0rNoSCSCBMmhNVzaXRWxx4pJm4zo9DZqBlRH5TW uMYHWW3TSTXafhXAhLb/wwfZKhjVfI9x823Hp6o0z76iDKp19AcjyonZS3n8Od8FuAUDoRbeu5b nvl0gixQ4B+3dgmFB0bvA+kgXk7Dpm7J/nFSpMIg= X-Received: by 2002:a5d:5888:0:b0:39f:4591:32bd with SMTP id ffacd0b85a97d-3a08ad46e8emr1499769f8f.34.1745918372374; Tue, 29 Apr 2025 02:19:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJXM/BXGCU8UpZr4p6oVQgqq+V2FSJ/lkBP36jdCgXf4fmHFinYxCqBefOh3t374kwrG7LcQ== X-Received: by 2002:a5d:5888:0:b0:39f:4591:32bd with SMTP id ffacd0b85a97d-3a08ad46e8emr1499730f8f.34.1745918372002; Tue, 29 Apr 2025 02:19:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e460b2sm13560519f8f.70.2025.04.29.02.19.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 02:19:31 -0700 (PDT) Message-ID: <25dcf969-e479-4d4a-a95c-0e83706af99e@redhat.com> Date: Tue, 29 Apr 2025 11:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] mm: Batch around can_change_pte_writable() To: Dev Jain , akpm@linux-foundation.org Cc: ryan.roberts@arm.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <20250429052336.18912-1-dev.jain@arm.com> <20250429052336.18912-7-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250429052336.18912-7-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZFsC9oS83n7oYlgHRyn0Gm9nhc8xE8uofED3bZZrZaA_1745918372 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 55980160006 X-Rspamd-Server: rspam04 X-Stat-Signature: shjh1tdf5n6t8b6axt9gj7rz1a5f1xjt X-HE-Tag: 1745918376-428659 X-HE-Meta: U2FsdGVkX1/sKoZxpTru/vc6jT02sDI4XwOZNxDFmpiHtCJr9Rv/kdvzGnXNmr8IDbAGYAFdTlo20kGUobmuNXZbc5zC9HEuEGrKk13A6ygbuzzO1ENONt0jg+p4CBv0yFvCBWCTp5wQHtCjPn6dPvidVHpasK5wVqRIFKFMvWs88ez1C18mGDY1sRJoomU3QNO5c3iNn17qEcNQsVqY8AGSX6CJAbeg+JqJQw32O8J/1W4UMPMXiBsATvWhkowQjcNpCBmN2YFy/3zhO6ZcaplcbKKaVU9jbnai4+abr+GDs8pm6rEDhhnyylzrFp5NYwfnkhaX8F/R9x1vDBjw4xyu5iwx8v3+PjlwLeySIaHd3VPhzncj3gUtf++pKHF1Nc7cElZl8tUsi8ZsrBJ28IfTOuwqGJOt45HQo731yqEEAlgK+wNNZ5kGdH//Zd1lg0N+ACAiir4jdYKlq73UVl9z2+clczYnRZLrefcL5SIrWPuJa+57Oq8tpudjV8iIx8BuNEyTES6ZCI2Q/dV+Y09TBNSANh19NeiODhxfgx8m9vgO5sDDOGaMqLR5twOIAzO92CKhqNeIf/MOZUocSTvIi5gFy3/+VydL+MmLNqMH0A8bFAUOJL20CcOzclKAoRuIQNMQlyzUDKeNuXQAIsAwJ3E4Eh8+e1a+rLrx7AA4PRztjGGLdKJw247GrBLGxxnIqo+TEt4lAjR5UzBUHN4HPWiLRfwmBz7Yrp7qgHLx8XNW/y/P797yTDRc0r1MXIrkntnWO9OXXINQHWpcL1tLhWUc5H6uPu+tuvIsGbn7S7yrzf4UaqoeBxPjI9d8dNYtonV9AFw3VLuItj5Tax32vZv0IBq8NqW5ExQGPfyQjFhf9AHD0j/d6KbzXQBYhMdvq0TB/zJj2kqaUdWr2rP8MWmU/KsyEZ13qi0nrSyJnMhMbSfS9JGmMUJVFF1UZm/SJ2XuqAHM3kkzKuQ 8/XGNIA/ KNBaA5pYUPum6MVnH6YH/c6NIU9fsgCzT9KFduatxiKpXlaSnm4mBFJpfxN+n3IZA8iD3xvN8yRuvcaYZvlS5n9stFMytU0wMW3IiHM66cEgy7bWjkJ5pfkVSXNzlZfRfVCcWYQwwWUfkuo7Kf0ZcbwBy4zq3e8QM4lSTb00jqQVI3mXNADTKqw89qbzhnt5gCnd8OWO5BKZASDVj3HUD0NnO9y7S0doS00fcfuLl+azY5ETGq/TJfjM8MBIzGzlGWVIc16ch4Nag8SFX2Fb9+o/3AUulqrPri8mBjaiB/odQQZKrpu/Ym/Df92cUsizWS1viicl1HRWbe1MsepTVEd4fFYqje0Ms9IGzuL66NILRScq3Nqk1EgirK5kOhHhTveruMCWswfCxlFUrJGcV13nDb2LdkvichKyMN3yeEjv8HwsLd4KXlqZYR46HBtSevTuOmRSN9aadejM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > #include "internal.h" > > -bool can_change_pte_writable(struct vm_area_struct *vma, unsigned long addr, > - pte_t pte) > +bool can_change_ptes_writable(struct vm_area_struct *vma, unsigned long addr, > + pte_t pte, struct folio *folio, unsigned int nr) > { > struct page *page; > > @@ -67,8 +67,9 @@ bool can_change_pte_writable(struct vm_area_struct *vma, unsigned long addr, > * write-fault handler similarly would map them writable without > * any additional checks while holding the PT lock. > */ > - page = vm_normal_page(vma, addr, pte); > - return page && PageAnon(page) && PageAnonExclusive(page); > + if (!folio) > + folio = vm_normal_folio(vma, addr, pte); > + return folio_test_anon(folio) && !folio_maybe_mapped_shared(folio); Oh no, now I spot it. That is horribly wrong. Please understand first what you are doing. -- Cheers, David / dhildenb