From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14678D0BB7F for ; Thu, 24 Oct 2024 09:48:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691EE6B0082; Thu, 24 Oct 2024 05:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6422C6B0083; Thu, 24 Oct 2024 05:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 509546B0085; Thu, 24 Oct 2024 05:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 317656B0082 for ; Thu, 24 Oct 2024 05:48:46 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D92271C6D65 for ; Thu, 24 Oct 2024 09:48:24 +0000 (UTC) X-FDA: 82708020528.01.177EA3F Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf06.hostedemail.com (Postfix) with ESMTP id EE29D180011 for ; Thu, 24 Oct 2024 09:48:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VHVlEFWR; spf=pass (imf06.hostedemail.com: domain of wladislav.kw@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=wladislav.kw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729763172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F8BZO8UMhk9f5gARVSgM1x6fEmct9HcXbugVM0Zv/jE=; b=PWrJeVWurruLQhAy4hHp+CxOLL+kQhvDbIFUU0fEVFfLmV0WJf0xX1wOmUUB1ECTKWWTls 4pFBOAf5cKAPHlpLVJGnvN4cO9XzS/B4sOtw+3HOUBxyiKq3YyFf+7Gtl9yC6jbZbMZX55 hzWoqR8Ln43RV7wlEqAmPDA285H/lpE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729763172; a=rsa-sha256; cv=none; b=RNtgo+acyQehPDbX1HgsXzkl853/owqEHMMw+R+PlHhih8hdpdIehGROTen7cvliNZo00m 9BIQVotinY8gNE3dYdAUxaQ0NMr0zoAWhwmkBF8EafyCiYcm6/2yIM7oGmf7Dl3mUnDXx2 Qq4NAn2Oauy41mZefhFF3ZO0RpdkHuA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VHVlEFWR; spf=pass (imf06.hostedemail.com: domain of wladislav.kw@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=wladislav.kw@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-37d41894a32so500197f8f.1 for ; Thu, 24 Oct 2024 02:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729763322; x=1730368122; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=F8BZO8UMhk9f5gARVSgM1x6fEmct9HcXbugVM0Zv/jE=; b=VHVlEFWRRf0kSwK4e1HkCZSBi4/CBJQc9FJXVMFq5qhmcyMTGoggwoMTuRIOUcJ/6w 0Ul55rEcoD6UNOFOCyvB8lNdinAfBanLkLWBhi2Q25a/HQl+IL8l9QasRWnnHViowzM7 WqpeNRoE8PGfN8Ja5Urt6IjMGd32qkIVAU3qwV4eATYi9vTXyGUvDMVfQ1bSDsXhkISY ZPBpRuUuBN70VvnPn4xco0IrZo2O3u+QaiakOXs7rKJKt+c5kUxTzG8teFTt5ddLKQJc x9Ks5xAu3Eag8wg7wecF8xxCQK6gDitFx97GmaUZ53HEMGXzT9te2qrlKH3lu5iA93Zd AOmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729763322; x=1730368122; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=F8BZO8UMhk9f5gARVSgM1x6fEmct9HcXbugVM0Zv/jE=; b=ZonhTJHu/g7zSjKk8MO25JrS/g+ira98g4gMtb8hkURxO6Q1ybJ4hFaDp3iVxaHZKP +Zfe7rtBOceMu6tD6VDdD5DUojNXnZmWkB2b6AbA0pS+lDk4w/rtj1rLsHVhjk8y+LxE 3l6UFiqzCoicEU+U1+LROvE2NyU41S0wJCBWFTLDdi7KQ/8DwhVnqkDE/A7oh41ibq5V dIqdc5sM7tsY9OPGYNAzEjThNPK+Np888zbrITnCZvXpj3nqEVflmSapeAlL/7kcDm5J vk5ANsU506cZfa6lCBDncmUTvhLTnwoagTOr8KIf3g93P0aupCalvW+JEvsKYpjZ7zIY ikvw== X-Gm-Message-State: AOJu0YyWSRNxl/D6Q636qCj3bziROwvrjQNmJ5GmJ/Us3yv1m2YHlEXi 7MHkHU89HRmTXZCQ445spXhbjgCwMrYTGrHz/8ygLlsbL2G319gb X-Google-Smtp-Source: AGHT+IHN5AR8ffhQUJ/Cu2oVbvyYCcnPaticb9PKfFa56t66E7hCSKpQWG+wuvvIeJs/NxAsAsrt0Q== X-Received: by 2002:adf:e602:0:b0:37d:43a8:dee0 with SMTP id ffacd0b85a97d-3803ac7d59bmr942850f8f.17.1729763322146; Thu, 24 Oct 2024 02:48:42 -0700 (PDT) Received: from [192.168.2.39] (ip-109-192-223-157.um38.pools.vodafone-ip.de. [109.192.223.157]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b566f11sm12048495e9.20.2024.10.24.02.48.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 02:48:41 -0700 (PDT) Message-ID: <25ca154e-d960-49f7-9e5f-3a4233a0396b@gmail.com> Date: Thu, 24 Oct 2024 11:48:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka References: <20241023165115.b524c51e80c36e120edabb36@linux-foundation.org> From: Wladislav Wiebe In-Reply-To: <20241023165115.b524c51e80c36e120edabb36@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EE29D180011 X-Stat-Signature: r6nstnjuqsdc481zzxqcjnbbee8oebtj X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729763310-545308 X-HE-Meta: U2FsdGVkX19ThJ/My60pmeC5QykSQdSWx+n8mDUWEeyRgfDRW2bsMkKvKJpwmIMbluykVBtEJLIk5P8MGr11MSjbGXLpDTkgPqR/YraBY9xNmFOnU0Xv/aS7Q3aRHA0HtKbODKbwbElPNLKL3+wQvb06DALf21awDiHbWenVpwLLoz9LpQEbk6Kl600INbu+zBcTCq9VtMbRzEuX2kdbWQQaN4JaqgkapM30vXeZc2JqgeR0uSqpnMLpzJ3C/bLbT325Rh3OjZOW5D9l/qNQgwfyoiXlrp/T57GH1gdIYZNt6+DLWQ2LUS5qNg8WKd9XGGZZrVr/7/QGTiSZIJI7AdMfXrannJS4vLT4SxOJBEuA6HaiPegPbuU/GCoKaKzWs324dKkq6CFomfheEg69qzG1eLELmW0pE27bn9C54E4C6AL10x13gGJHyMQN3NmSaNps9u7iYIH9YV7YJlVzdVByHQcfDj4yqO5bFASnDTXl4kUjKRLZX13tF62ePE19/DRJT1J8wJpH5Xwptl1FPG80dLuenlhKq23bbjLR8iLm4xbz8YQaKT58MO1PxoODnEIly+asvMzqUNsbmkwEYp4ju5/0JprHF1aBnTTybAUKuYuyDtpKC/I7P3Bg6gQ1/6Dy1x3sbLlHvw7Sd7ljC5uUFBXFUGNzuimM/dZp4Ib61kbuSmpfg7lEhq2OnRv+x7MGEKy6cFDFlDERWOeaGfJdzw+2av8WXHFPtL+Xab+jYnpPqdCLV+jS/7kP65uqpFUeyJRhiEwVd9dRVM1LdOVr0DQuMqELUCZ9CtDQ7iU4yd2iJDcpcr0eIzXxwLNLZr8UnReFcHmlZVFwUsiJfsh7aY/UagjERSlBqORWXecZK4v4plgJC9vV6wdHyZp0tkzlvjK/1LE3tu87pwH/pBidVsOlCWxlAlr77kh7DexZGniXpFJPVSiqgE0TAW9Nk1xRcf2sCpgVG7cIcHM fPSlZrMv t6nJVB7QS3qJ8U+yHe1AyXtdap7I34O/5g5OlU97NA4MQ5t+KUFFnOOm6UDLk+fFrBUZ8Ps62UDBtSXxyouTJ444Y1Qx5WR2fSnZklGh33ei/HL7VJLllEjKALlW9Z4SUUjHTLYACvPyE5g9IqFH1oqOzm1KYEgjRpd47mCIBnPZfhQHdoU89pc7K/SQt2NLznDTx7iijBQQjw0qiB2G79hJPNl9AbpBaIrmAPj6uxYE+eEUV600+LbpvtmD45Vug3EiAUln8rGTcAW8Lxwt4NnDI0qbEEALEndXr8xqxaoqnMjrBAwwsgvXzpCHn4B3S7KS/45c/JgNmTrCUhS+U+N+VdBIHVB6lEDYf4cHpcmZkkPJ49rbzay4qdTSG6N+cPi62RBTGxffCD1UfS+gglqmSYQ9wMS3SL+X/Aampk7jk8u7vtRaUBoYrdWa27KxTbrPx4mrQ5dcPonmdVmJA0St43+dpphyvqSsU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/10/2024 01:51, Andrew Morton wrote: > On Tue, 22 Oct 2024 19:21:13 +0200 Wladislav Wiebe wrote: > >> Commit e6d2c436ff693 ("tools/mm: allow users to provide >> additional cflags/ldflags") passes now CFLAGS to Makefile. >> With this, build systems with default -Werror enabled found: >> >> slabinfo.c:1300:25: error: ignoring return value of 'chdir' >> declared with attribute 'warn_unused_result' [-Werror=unused-result] >>                          chdir(".."); >>                          ^~~~~~~~~~~ >> page-types.c:397:35: error: format '%lu' expects argument of type >> 'long unsigned int', but argument 2 has type 'uint64_t' >> {aka 'long long unsigned int'} [-Werror=format=] >>                          printf("%lu\t", mapcnt0); >>                                  ~~^     ~~~~~~~ >> .. >> >> Fix page-types by using PRIu64 for uint64_t prints and check >> in slabinfo for return code on chdir(".."). >> > Thanks. > > Your email client messed this up in strange ways, so I basically typed > it in again. I added the Fixes: target and a cc:stable. thanks for the feedback, seems something went wrong after updating my mail client, I will fix it.