From: Wladislav Wiebe <wladislav.kw@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] tools/mm: -Werror fixes in page-types/slabinfo
Date: Thu, 24 Oct 2024 11:48:40 +0200 [thread overview]
Message-ID: <25ca154e-d960-49f7-9e5f-3a4233a0396b@gmail.com> (raw)
In-Reply-To: <20241023165115.b524c51e80c36e120edabb36@linux-foundation.org>
On 24/10/2024 01:51, Andrew Morton wrote:
> On Tue, 22 Oct 2024 19:21:13 +0200 Wladislav Wiebe <wladislav.kw@gmail.com> wrote:
>
>> Commit e6d2c436ff693 ("tools/mm: allow users to provide
>> additional cflags/ldflags") passes now CFLAGS to Makefile.
>> With this, build systems with default -Werror enabled found:
>>
>> slabinfo.c:1300:25: error: ignoring return value of 'chdir'
>> declared with attribute 'warn_unused_result' [-Werror=unused-result]
>> chdir("..");
>> ^~~~~~~~~~~
>> page-types.c:397:35: error: format '%lu' expects argument of type
>> 'long unsigned int', but argument 2 has type 'uint64_t'
>> {aka 'long long unsigned int'} [-Werror=format=]
>> printf("%lu\t", mapcnt0);
>> ~~^ ~~~~~~~
>> ..
>>
>> Fix page-types by using PRIu64 for uint64_t prints and check
>> in slabinfo for return code on chdir("..").
>>
> Thanks.
>
> Your email client messed this up in strange ways, so I basically typed
> it in again. I added the Fixes: target and a cc:stable.
thanks for the feedback, seems something went wrong after updating my mail client, I will fix it.
prev parent reply other threads:[~2024-10-24 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 17:21 Wladislav Wiebe
2024-10-23 23:51 ` Andrew Morton
2024-10-24 9:48 ` Wladislav Wiebe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ca154e-d960-49f7-9e5f-3a4233a0396b@gmail.com \
--to=wladislav.kw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox