From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E932C433EF for ; Fri, 8 Oct 2021 13:33:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C442361042 for ; Fri, 8 Oct 2021 13:33:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C442361042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EAD30900002; Fri, 8 Oct 2021 09:33:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5D2E6B0072; Fri, 8 Oct 2021 09:33:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D241A900002; Fri, 8 Oct 2021 09:33:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id C36F36B0071 for ; Fri, 8 Oct 2021 09:33:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 80FA418023431 for ; Fri, 8 Oct 2021 13:33:27 +0000 (UTC) X-FDA: 78673362054.11.52447E0 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf07.hostedemail.com (Postfix) with ESMTP id 7437B1001C8B for ; Fri, 8 Oct 2021 13:33:26 +0000 (UTC) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HQptb6nDpzbmq7; Fri, 8 Oct 2021 21:28:55 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 8 Oct 2021 21:33:20 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.8; Fri, 8 Oct 2021 21:33:19 +0800 Message-ID: <25c6cc97-f436-8966-9052-a1841f68e81a@huawei.com> Date: Fri, 8 Oct 2021 21:33:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v4 0/3] arm64: support page mapping percpu first chunk allocator Content-Language: en-US From: Kefeng Wang To: , , , , , , , , , , CC: References: <20210910053354.26721-1-wangkefeng.wang@huawei.com> <5cd6631f-0bac-bd74-3369-1fa4a744687f@huawei.com> In-Reply-To: <5cd6631f-0bac-bd74-3369-1fa4a744687f@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggeme709-chm.china.huawei.com (10.1.199.105) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 7437B1001C8B X-Stat-Signature: zrptpz1d75akyyqkz5cz67rzdbhkh5h7 Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspamd-Server: rspam06 X-HE-Tag: 1633700006-186019 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/28 15:48, Kefeng Wang wrote: > Hi Catalin and Andrew, kindly ping again, any comments, thanks. Looks no more comments, Catalin and Andrew, ping again, any one of you could merge this patchset, many thanks. >=20 > On 2021/9/10 13:33, Kefeng Wang wrote: >> Percpu embedded first chunk allocator is the firstly option, but it >> could fails on ARM64, eg, >> =C2=A0=C2=A0 "percpu: max_distance=3D0x5fcfdc640000 too large for vmal= loc space=20 >> 0x781fefff0000" >> =C2=A0=C2=A0 "percpu: max_distance=3D0x600000540000 too large for vmal= loc space=20 >> 0x7dffb7ff0000" >> =C2=A0=C2=A0 "percpu: max_distance=3D0x5fff9adb0000 too large for vmal= loc space=20 >> 0x5dffb7ff0000" >> >> then we could meet "WARNING: CPU: 15 PID: 461 at vmalloc.c:3087=20 >> pcpu_get_vm_areas+0x488/0x838", >> even the system could not boot successfully. >> >> Let's implement page mapping percpu first chunk allocator as a fallbac= k >> to the embedding allocator to increase the robustness of the system. >> >> Also fix a crash when both NEED_PER_CPU_PAGE_FIRST_CHUNK and=20 >> KASAN_VMALLOC enabled. >> >> Tested on ARM64 qemu with cmdline "percpu_alloc=3Dpage" based on v5.14= . >> >> V4: >> - add ACK/RB >> - address comments about patch1 from Catalin >> - add Greg and Andrew into list suggested by Catalin >> >> v3: >> - search for a range that fits instead of always picking the end from >> =C2=A0=C2=A0 vmalloc area suggested by Catalin. >> - use NUMA_NO_NODE to avoid "virt_to_phys used for non-linear address:= " >> =C2=A0=C2=A0 issue in arm64 kasan_populate_early_vm_area_shadow(). >> - add Acked-by: Marco Elver to patch v3 >> >> V2: >> - fix build error when CONFIG_KASAN disabled, found by lkp@intel.com >> - drop wrong __weak comment from kasan_populate_early_vm_area_shadow()= , >> =C2=A0=C2=A0 found by Marco Elver >> >> Kefeng Wang (3): >> =C2=A0=C2=A0 vmalloc: Choose a better start address in vm_area_registe= r_early() >> =C2=A0=C2=A0 arm64: Support page mapping percpu first chunk allocator >> =C2=A0=C2=A0 kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_= VMALLOC >> >> =C2=A0 arch/arm64/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 4 ++ >> =C2=A0 arch/arm64/mm/kasan_init.c | 16 ++++++++ >> =C2=A0 drivers/base/arch_numa.c=C2=A0=C2=A0 | 82 +++++++++++++++++++++= ++++++++++++----- >> =C2=A0 include/linux/kasan.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 += ++ >> =C2=A0 mm/kasan/init.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 5 +++ >> =C2=A0 mm/vmalloc.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 19 ++++++--- >> =C2=A0 6 files changed, 116 insertions(+), 16 deletions(-) >>