From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E53C48BE5 for ; Tue, 15 Jun 2021 12:57:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 13D2C61463 for ; Tue, 15 Jun 2021 12:57:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13D2C61463 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=sangfor.com.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8F96A6B006E; Tue, 15 Jun 2021 08:57:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A9956B0071; Tue, 15 Jun 2021 08:57:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7230F6B0072; Tue, 15 Jun 2021 08:57:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3CFD26B006E for ; Tue, 15 Jun 2021 08:57:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D521D1DFB for ; Tue, 15 Jun 2021 12:57:19 +0000 (UTC) X-FDA: 78255958998.04.EAA34FB Received: from mail-m118208.qiye.163.com (mail-m118208.qiye.163.com [115.236.118.208]) by imf25.hostedemail.com (Postfix) with SMTP id D42486000148 for ; Tue, 15 Jun 2021 12:57:07 +0000 (UTC) Received: from [0.0.0.0] (unknown [116.24.56.76]) by mail-m118208.qiye.163.com (Hmail) with ESMTPA id 2A0CFE03EC; Tue, 15 Jun 2021 20:57:10 +0800 (CST) Subject: Re: [PATCH v1 2/6] mm/hwpoison: remove race consideration To: Naoya Horiguchi , linux-mm@kvack.org Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , Michal Hocko , Tony Luck , "Aneesh Kumar K.V" , Naoya Horiguchi , linux-kernel@vger.kernel.org References: <20210614021212.223326-1-nao.horiguchi@gmail.com> <20210614021212.223326-3-nao.horiguchi@gmail.com> From: Ding Hui Message-ID: <25c69dc8-0ce2-8330-dfb0-506481dc9a53@sangfor.com.cn> Date: Tue, 15 Jun 2021 20:57:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210614021212.223326-3-nao.horiguchi@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZGU0fTlZIT0MdSBpPQ0hPTUNVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWUFZT0tIVUpKS0 hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6KxA6Qxw4Kz8KK0hDTxY#PCxK GjQKFEpVSlVKTUlITE1KQ0hKTE5DVTMWGhIXVR8SFRwTDhI7CBoVHB0UCVUYFBZVGBVFWVdZEgtZ QVlKSk1VSU9VTk1VTE1ZV1kIAVlBSUxCSjcG X-HM-Tid: 0a7a0fbf46472c17kusn2a0cfe03ec Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=sangfor.com.cn; spf=pass (imf25.hostedemail.com: domain of dinghui@sangfor.com.cn designates 115.236.118.208 as permitted sender) smtp.mailfrom=dinghui@sangfor.com.cn X-Rspamd-Server: rspam02 X-Stat-Signature: faiabuq8n76azx9rgdhrp8wg9hcrqu8x X-Rspamd-Queue-Id: D42486000148 X-HE-Tag: 1623761827-239622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/6/14 10:12, Naoya Horiguchi wrote: > @@ -1956,17 +1938,6 @@ int unpoison_memory(unsigned long pfn) > goto unlock_mutex; > } > > - /* > - * unpoison_memory() can encounter thp only when the thp is being > - * worked by memory_failure() and the page lock is not held yet. > - * In such case, we yield to memory_failure() and make unpoison fail. > - */ > - if (!PageHuge(page) && PageTransHuge(page)) { > - unpoison_pr_info("Unpoison: Memory failure is now running on %#lx\n", > - pfn, &unpoison_rs); > - goto unlock_mutex; > - } > - if a huge page is in process of alloc or free, HUGETLB_PAGE_DTOR can be set after __SetPageHead() or be cleared before __ClearPageHead(), so this condition may be true in racy. Do we need the racy test for this situation? > if (!get_hwpoison_page(p, flags)) { > if (TestClearPageHWPoison(p)) > num_poisoned_pages_dec(); -- Thanks, - Ding Hui